fix: unify cdp approach to fix devtools in electron #26573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 75bb681.
1 flaky tests on run #45892 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| baseUrl > should add baseUrl warning when going from good to bad config |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
ryanthemanuel
changed the title
ryanthemanuel
changed the title
ryanthemanuel
changed the title
chrisbreiding
approved these changes
Apr 24, 2023
mschile
approved these changes
Apr 24, 2023
cli/CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ _Released 04/25/2023 (PENDING)_ | |||
|
|
|||
| - Fixed an issue where setting `videoCompression` to `0` would cause the video output to be broken. `0` is now treated as false. Addresses [#5191](https://github.com/cypress-io/cypress/issues/5191) and [#24595](https://github.com/cypress-io/cypress/issues/24595). | |||
| - Fixed an issue on the [Debug page](https://on.cypress.io/debug-page) where the passing run status would appear even if the Cypress Cloud organization was over its monthly test result limit. Addresses [#26528](https://github.com/cypress-io/cypress/issues/26528). | |||
| - Fixed an issue in Electron where devtools gets out of sync with the DOM occasionally. Addresses [#15932](https://github.com/cypress-io/cypress/issues/15932). | |||
There was a problem hiding this comment.
lets move this up. this is more important than videoCompression
There was a problem hiding this comment.
I'll refactor this after the release today.
There was a problem hiding this comment.
This has been refactored
|
I tested this out, it does indeed fix #15932 We could consider making the default browser electron - since it's the only one guaranteed to be on all systems. I believe this was the intention and how older Cypress versions worked, but we changed it due to this bug. Either way, very excited to see this this is finally fixed! |
ryanthemanuel
commented
Apr 27, 2023
ryanthemanuel
added a commit
that referenced
this pull request
May 1, 2023
Co-authored-by: Matt Henkes <[email protected]> Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <[email protected]> Co-authored-by: Leosvel Pérez Espinosa <[email protected]> Co-authored-by: astone123 <[email protected]> Co-authored-by: Mark Noonan <[email protected]> Co-authored-by: Mike Plummer <[email protected]> Co-authored-by: Mike Plummer <[email protected]> Co-authored-by: Lachlan Miller <[email protected]> Co-authored-by: Stokes Player <[email protected]> Co-authored-by: Stokes Player <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Stone-Lord <[email protected]> Co-authored-by: Ben M <[email protected]> Co-authored-by: Jordan <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Barthélémy Ledoux <[email protected]> fix: Treat Video compression 0 as false. (#26503) fix: don't display run passing status if Cloud org is over run limit (#26533) fix: unify cdp approach to fix devtools in electron (#26573)
tgriesser
added a commit
that referenced
this pull request
May 3, 2023
* feat/protocol: refactor: migrate from windi to tailwind (#26516) chore: update v8 generation vars so that from scratch depends implies updating the metafile (#26472) chore: Update Vite to 4.3.0 (#26553) fix: unify cdp approach to fix devtools in electron (#26573) dependency(deps): update dependency deps-ok to v1.4.1 🌟 (#26612) chore: update 12.11.0 release date (#26587) chore: 12.11.0 release (#26582) chore: implement experimental ESM stub/spy for Vite (#26536) chore: try triggering mouseleave on buttons to ensure that tooltips aren't showing (#26524) chore: add support for Angular 16 (#26052) chore: upgrade Vue to 3.2.47 (#26555) chore: Update v8 snapshot cache (#26537) chore: add missing utm parameters for cloud links to Debug page (#26556) chore: update stalebot to respect new labels and up process rate (#26552) fix: don't display run passing status if Cloud org is over run limit (#26533) chore: update vm2 to 3.9.17 (#26534) feat: display a limit warning on the run navigation component when there are 100 total runs (#26523) chore: Update v8 snapshot cache (#26476) chore: upgrade vm2 (#26495) fix: Treat Video compression 0 as false. (#26503)
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15932
Additional details
Electron has issues when you attach to
win.webContents.debuggerwhere it causes devtools to get out of sync with the DOM. This can be fixed by attaching to electron in a similar fashion to how we attach to other chromium browsers. This PR makes that transitionSteps to test
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?