-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade Vue to 3.2.47 #26555
chore: upgrade Vue to 3.2.47 #26555
Conversation
@@ -48,6 +48,7 @@ export const registerMountFn = ({ plugins }: MountFnOptions = {}) => { | |||
}, | |||
}) | |||
|
|||
// @ts-ignore todo: figure out the correct types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I messed with the type errors in this file for a while... still not sure what needs to change. We already ignore some types in this file (see line 27)
Passing run #45738 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Hm, the regression mentioned in #23909 (comment) is no longer an issue? |
@astone123 I think https://app.circleci.com/pipelines/github/cypress-io/cypress/51862/workflows/bdae02be-0adc-4fc6-b034-fb4b0b19edcd/jobs/2139937/tests#failed-test-0 is a real regression - might be worth taking a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems fine, I think we have a regression: https://app.circleci.com/pipelines/github/cypress-io/cypress/51862/workflows/bdae02be-0adc-4fc6-b034-fb4b0b19edcd/jobs/2139937/tests#failed-test-0
Yeah, I didn't see this regression after the upgrade. I'll look into the other regression |
@lmiller1990 that test was failing because I updated a default prop to satisfy some new types. I updated the assertion so we should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd percy change, but I'll approve assuming that's just flake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it out, looks good!
I hope we can hit Vue 3.3 soon when it's out. Many nice things landing, like generic components 😎
* feat/protocol: refactor: migrate from windi to tailwind (#26516) chore: update v8 generation vars so that from scratch depends implies updating the metafile (#26472) chore: Update Vite to 4.3.0 (#26553) fix: unify cdp approach to fix devtools in electron (#26573) dependency(deps): update dependency deps-ok to v1.4.1 🌟 (#26612) chore: update 12.11.0 release date (#26587) chore: 12.11.0 release (#26582) chore: implement experimental ESM stub/spy for Vite (#26536) chore: try triggering mouseleave on buttons to ensure that tooltips aren't showing (#26524) chore: add support for Angular 16 (#26052) chore: upgrade Vue to 3.2.47 (#26555) chore: Update v8 snapshot cache (#26537) chore: add missing utm parameters for cloud links to Debug page (#26556) chore: update stalebot to respect new labels and up process rate (#26552) fix: don't display run passing status if Cloud org is over run limit (#26533) chore: update vm2 to 3.9.17 (#26534) feat: display a limit warning on the run navigation component when there are 100 total runs (#26523) chore: Update v8 snapshot cache (#26476) chore: upgrade vm2 (#26495) fix: Treat Video compression 0 as false. (#26503)
Additional details
This PR upgrades Vue to version
3.2.47
in the monorepo.Steps to test
Launch Cypress and do some manual smoke testing to make sure that nothing broke
How has the user experience changed?
n/a
PR Tasks
mountFragment
?cypress-documentation
?type definitions
?