Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synchronous build method #110

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Add synchronous build method #110

merged 1 commit into from
Sep 4, 2020

Commits on Sep 3, 2020

  1. feat: add buildSync method to Mocker class

    Add a new `buildSync` method alongside the existing `build` method to allow the generator to be used where synchronous flow is required.
    
    This is a simple non-breaking surface-level change. The library does not currently include any internal async logic. The async behavior of the `build` method is designed to avoid an unwanted breaking interface change in the future if async logic is added (discussed [here](danibram#100)). If async generators are added in the future, I suggest that they be excluded from the set of generators available for use when calling `buildSync` - this could be achieved cleanly in typescript by giving the `Mocker` class a generic `Schema` type that is referenced in conditional types on the `build` and `buildSync` methods. This would also require adding strict type inference to the schema interface, but doing so could have the added benefit of returning non-opaque typed data.
    10xjs committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    772b20d View commit details
    Browse the repository at this point in the history