Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid showing the bounding box when the scene is still loading assets #906

Merged
merged 10 commits into from
Feb 29, 2024

refactor: get scene nodes

5782731
Select commit
Loading
Failed to load commit list.
Merged

fix: Avoid showing the bounding box when the scene is still loading assets #906

refactor: get scene nodes
5782731
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 28, 2024 in 0s

67.13% (+0.32%) compared to 2c5f6a7

View this Pull Request on Codecov

67.13% (+0.32%) compared to 2c5f6a7

Details

Codecov Report

Attention: Patch coverage is 86.33094% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 67.13%. Comparing base (2c5f6a7) to head (5782731).

Files Patch % Lines
...es/@dcl/inspector/src/redux/scene-metrics/types.ts 0.00% 6 Missing and 1 partial ⚠️
...nspector/src/lib/babylon/decentraland/EcsEntity.ts 25.00% 6 Missing ⚠️
...es/@dcl/inspector/src/redux/scene-metrics/index.ts 92.59% 4 Missing ⚠️
packages/@dcl/inspector/src/redux/store.ts 80.00% 1 Missing ⚠️
packages/@dcl/inspector/src/tooling-entrypoint.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
+ Coverage   66.81%   67.13%   +0.32%     
==========================================
  Files         524      529       +5     
  Lines       16542    16676     +134     
  Branches     2111     2132      +21     
==========================================
+ Hits        11052    11196     +144     
+ Misses       5155     5143      -12     
- Partials      335      337       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.