Refactor Future sidebar #233
Comments
|
@bridgetkromhout - I assume that events without dates should NOT show up in the grey bar? But we do need to add the "TBD" events to the blue footer. |
Correct. |
|
Thanks, @mattstratton! Now one event with a blank start date will appear in the Future section, but not two. To reproduce: $ grep "^startdate: #" data/events/*
Then remove Ohio, and Madison shows up: Bridgets-MacBook-Air:devopsdays-web bridget$ rm data/events/2016-ohio.yml
|
|
Even with Kiel's year corrected, this also affects Kiel/Seattle. So, more broadly, it's the "same dates can't both show up" issue (now appearing in Future). |
|
Gah. I might have to refactor that entire code - future is a little easier to handle for it because it's built to account for multi-year but we don't need that just yet. The problem is that I didn't write the code for that initially and I don't completely understand it. I don't know if @m1keil has any ideas? |
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue. Resolves #247 Resolves #246 Resolves #233
bridgetkromhout
changed the title
|
I'm assuming this is still open for "tech debt" reasons? |
|
Never mind. I see the comments in the PR. Yeah, it's super sloppy but it will do for the moment. |
|
This is probably being handled with #405, which makes everything cleaner. |
Fixes devopsdays#233 Former-commit-id: 74d76e7
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue. Resolves devopsdays#247 Resolves devopsdays#246 Resolves devopsdays#233 Former-commit-id: 73d7178
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue. Resolves #247 Resolves #246 Resolves #233
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue. Resolves #247 Resolves #246 Resolves #233 Former-commit-id: 73d7178
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue. Resolves #247 Resolves #246 Resolves #233
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue. Resolves #247 Resolves #246 Resolves #233 Former-commit-id: 73d7178
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue. Resolves #247 Resolves #246 Resolves #233
The Upcoming Events box above the map and the Future Events sidebar do not line up for events that do not have dates attached to them yet.
For example: http://devopsdays.github.io/events/2016-madison/ does not have dates attached, and shows up in the grey box above the map, but not in the Future Events sidebar.
vs.
The text was updated successfully, but these errors were encountered: