Refactor future footer #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue. Resolves #247 Resolves #246 Resolves #233
|
@bridgetkromhout - can you take a look at this and double-test it for me to make sure it does fix the issues? I think I got it handled. |
|
This works to band-aid the listed issues, hackish as it may be. It doesn't display 2017 events well (it places them right after the last of the 2016 events with dates and doesn't display the year) but that's something we can deal with later. |
benjohnson77
pushed a commit
to benjohnson77/devopsdays-web
that referenced
this pull request
May 22, 2016
…or-future Refactor future footer Former-commit-id: bd8c866
yvovandoorn
pushed a commit
that referenced
this pull request
May 22, 2016
Refactor future footer Former-commit-id: bd8c866
yvovandoorn
pushed a commit
that referenced
this pull request
May 29, 2016
Refactor future footer Former-commit-id: bd8c866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue.
Resolves #247
Resolves #246
Resolves #233