Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

different behavior of "year" key for future and past events on events page #247

Closed
mattstratton opened this issue May 6, 2016 · 4 comments
Closed

different behavior of "year" key for future and past events on events page #247

mattstratton opened this issue May 6, 2016 · 4 comments
Assignees
@mattstratton
Labels
bug
Milestone
Future Enhancements

Comments

@mattstratton
Copy link
Member

If the event is "past" then it needs to be in quotes, if it's "current" it needs to not be in quotes. This is a problem :)
@mattstratton mattstratton added this to the Future Enhancements milestone May 6, 2016
@bridgetkromhout
Copy link
Collaborator

I thought this bug applied to the actual year:

year: "YYYY" has to be in quotes for current.
year: YYYY can't be in quotes for past.

not to the status:

status: "current" or status "past" both work.

@mattstratton
Copy link
Member Author

oh, whoops.

@bridgetkromhout bridgetkromhout changed the title different behavior of "status" key for future and past events in the sidebar different behavior of "year" key for future and past events in the sidebar May 6, 2016
mattstratton added a commit that referenced this issue May 6, 2016
@mattstratton
Refactor future footer
73d7178 
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue.

Resolves #247
Resolves #246
Resolves #233
@mattstratton mattstratton mentioned this issue May 6, 2016
Merged
@mattstratton mattstratton self-assigned this May 6, 2016
benjohnson77 pushed a commit to benjohnson77/devopsdays-web that referenced this issue May 22, 2016
@mattstratton
Refactor future footer
d6decb6 
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue.

Resolves devopsdays#247
Resolves devopsdays#246
Resolves devopsdays#233


Former-commit-id: 73d7178
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Refactor future footer
ac1f054 
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue.

Resolves #247
Resolves #246
Resolves #233
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Refactor future footer
1f305e5 
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue.

Resolves #247
Resolves #246
Resolves #233


Former-commit-id: 73d7178
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Refactor future footer
472c3ae 
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue.

Resolves #247
Resolves #246
Resolves #233
yvovandoorn pushed a commit that referenced this issue May 29, 2016
@mattstratton
Refactor future footer
1be0833 
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue.

Resolves #247
Resolves #246
Resolves #233


Former-commit-id: 73d7178
yvovandoorn pushed a commit that referenced this issue May 29, 2016
@mattstratton
Refactor future footer
e41955e 
It's somewhat sloppy, and has the year 2016 hardcoded into it for now, but it works. This removes the issue with the "events on the same date" (only for future footer; the issue still exists for past events for now) and it also takes care of the "year in quotes" issue.

Resolves #247
Resolves #246
Resolves #233
@bridgetkromhout bridgetkromhout changed the title different behavior of "year" key for future and past events in the sidebar different behavior of "year" key for future and past events on events page Jun 4, 2016
@bridgetkromhout
Copy link
Collaborator

This bug still exists with the current http://www.devopsdays.org/events/ page.

@bridgetkromhout bridgetkromhout mentioned this issue Aug 16, 2016
Merged
@mattstratton mattstratton mentioned this issue Aug 18, 2016
Closed
@mattstratton
Copy link
Member Author

This is fixed by #885

The year field isn't used by the events page anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattstratton mattstratton

Labels
bug
Projects
None yet
Milestone
Future Enhancements
Development

No branches or pull requests
2 participants
@mattstratton @bridgetkromhout