Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document super reactions #6056

Merged
merged 4 commits into from
Aug 24, 2023
Merged

document super reactions #6056

merged 4 commits into from
Aug 24, 2023

Conversation

Mateo-tem
Copy link
Contributor

@Mateo-tem Mateo-tem commented Apr 6, 2023

This PR documents the information about the super reactions feature.

@Lulalaby
Copy link
Contributor

Lulalaby commented Apr 6, 2023

Can bots even create super reactions?

@Mateo-tem
Copy link
Contributor Author

Can bots even create super reactions?

I tried to create super reactions with a bot and it worked. If I am not mistaken, I created two super reactions, but now, I am trying again and this error appears: No available burst currency for user.

As far as I know, Discord is giving two free super reactions for users, but I think this is also happening in bots. Is this a bug?

image

@Lulalaby
Copy link
Contributor

Lulalaby commented Apr 6, 2023

I believe bots shouldn't be able to do this. It's probably not gonna be checked for bot

docs/resources/Channel.md Outdated Show resolved Hide resolved
docs/resources/Channel.md Outdated Show resolved Hide resolved
docs/resources/Channel.md Show resolved Hide resolved
docs/resources/Channel.md Outdated Show resolved Hide resolved
@sklein12
Copy link
Contributor

sklein12 commented Apr 6, 2023

👋 thanks for doing this, however, there's still some updates we need to make to the shape of the API response so let's hold off on merging this.

@thehatkid
Copy link

Also for now GET /channels/{channel.id}/messages/{message.id}/reactions/{emoji} takes new query parameter type.
Type 0 for getting normal reaction users list and 1 for getting burst (super) reaction users list.
(e.g. GET /channels/{channel.id}/messages/{message.id}/reactions/{emoji}?type=1)

@jaw0r3k
Copy link
Contributor

jaw0r3k commented Apr 10, 2023

Also for now GET /channels/{channel.id}/messages/{message.id}/reactions/{emoji} takes new query parameter type. Type 0 for getting normal reaction users list and 1 for getting burst (super) reaction users list. (e.g. GET /channels/{channel.id}/messages/{message.id}/reactions/{emoji}?type=1)

Btw default type is 0

@JJRcop
Copy link
Contributor

JJRcop commented May 20, 2023

MESSAGE_REACTION_ADD also has updates, which aren't in this PR. Is this usable yet or still subject to changes?

Screenshots

Screenshot_20230520_103159

Screenshot_20230520_102004

@advaith1
Copy link
Contributor

advaith1 commented May 20, 2023

api surface is still unstable. hopefully soon:tm:

@NeloBlivion
Copy link

Any further updates on this?

docs/resources/Channel.md Outdated Show resolved Hide resolved
docs/resources/Channel.md Outdated Show resolved Hide resolved
docs/resources/Channel.md Outdated Show resolved Hide resolved
docs/resources/Channel.md Outdated Show resolved Hide resolved
docs/resources/Channel.md Outdated Show resolved Hide resolved
@JJRcop
Copy link
Contributor

JJRcop commented Jul 14, 2023

MESSAGE_REACTION_ADD also has updates, which aren't in this PR.

Will these be added? They are missing from documentation.

@Mateo-tem Any feedback?

@Mateo-tem
Copy link
Contributor Author

MESSAGE_REACTION_ADD also has updates, which aren't in this PR.

Will these be added? They are missing from documentation.

@Mateo-tem Any feedback?

We might wait for a staff response, because as it was said, the API needs to be updated

@Jay-Madden
Copy link

Is there any movement on this? has the api stabilized?

@shaydewael shaydewael merged commit b1bed46 into discord:main Aug 24, 2023
@Mateo-tem Mateo-tem deleted the super-reactions branch August 24, 2023 22:49
@MinnDevelopment
Copy link
Contributor

These docs are very confusing to me.

  • What are the colors used for and why are they hex? Does this imply it can also be #FFF equivalent of #FFFFFF?
  • Why is it an array if the reaction only has 1 color in the UI?
  • Why are there 2 different counts now? The client doesn't let you send a normal reaction of the same emoji

image

I would prefer if the documentation would be more detailed than "this is a color thats used".

@advaith1
Copy link
Contributor

advaith1 commented Aug 30, 2023

for the last one, that's only for one user - different people can super react and normal react with the same emoji, but one person could not do both (though that has changed)

Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Sep 17, 2023
lukellmann added a commit to lukellmann/kord that referenced this pull request Sep 28, 2023
suneettipirneni added a commit to twilight-rs/twilight that referenced this pull request Oct 7, 2023
Ref:
- discord/discord-api-docs#6056

This PR also adds a new `HexColor` struct for efficiently storing hex
strings.
shaydewael added a commit to Jupith/discord-api-docs that referenced this pull request May 14, 2024
* document super reactions

* delete me_burst field

Co-authored-by: Lala Sabathil <[email protected]>

* add error code 90002

* apply suggestions

Co-authored-by: shay <[email protected]>

---------

Co-authored-by: Lala Sabathil <[email protected]>
Co-authored-by: shay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.