Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add super-reactions to gateway events #6375

Merged
merged 1 commit into from
May 15, 2024

Conversation

JJRcop
Copy link
Contributor

@JJRcop JJRcop commented Aug 24, 2023

Adds super-reactions related event members missing from #6056
Was originally a PR to #6056 in Mateo-tem#1, but #6056 was just recently merged before the author of #6056 merged my PR.

I have observed these super-reaction related members in the MESSAGE_REACTION_ADD and MESSAGE_REACTION_REMOVE events as demonstrated below:

Add and Remove Screenshots

Screenshot_20230714_133238

Screenshot_20230714_133004-1

burst_colors was left out of MESSAGE_REACTION_REMOVE because my findings show it is always empty even if it was a super-reaction

I have also observed similar members in the MESSAGE_REACTION_REMOVE_EMOJI event, but they don't seem to work the same way so they were omitted.

Add and Remove All Emoji Screenshots

Screenshot_20230714_134227-1

Screenshot_20230714_135019

@JJRcop JJRcop changed the title Add super-reactions to MESSAGE_REACTION_ADD and MESSAGE_REACTION_REMOVE Add super-reactions to gateway events Aug 24, 2023
TTtie added a commit to projectdysnomia/dysnomia that referenced this pull request Aug 26, 2023
DonovanDMC added a commit to OceanicJS/Oceanic that referenced this pull request Sep 3, 2023
TTtie added a commit to projectdysnomia/dysnomia that referenced this pull request Sep 20, 2023
TTtie added a commit to projectdysnomia/dysnomia that referenced this pull request Oct 10, 2023
@JJRcop
Copy link
Contributor Author

JJRcop commented Dec 14, 2023

I haven't tested this in a while, but can anyone confirm it still works this way? I will do some tests soon to make sure.

@bsian03
Copy link
Contributor

bsian03 commented Jan 23, 2024

type is missing from both events. 0 for normal, 1 for burst

also what's the word on getting this merged (or not merged even?)

Copy link
Contributor

@colinloretz colinloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition! I'll open a PR to add type after this one.

@colinloretz colinloretz merged commit f71e8a5 into discord:main May 15, 2024
suneettipirneni added a commit to twilight-rs/twilight that referenced this pull request Jul 13, 2024
Refs:
- discord/discord-api-docs#6375
- discord/discord-api-docs#6377

This PR renames the old `ReactionType` to `EmojiReactionType` as the
concept of a reaction type now exists in the API.
TTtie added a commit to projectdysnomia/dysnomia that referenced this pull request Jul 13, 2024
TTtie added a commit to projectdysnomia/dysnomia that referenced this pull request Jul 13, 2024
* feat: super reactions

Ref: discord/discord-api-docs@b1bed46

Ref: discord/discord-api-docs#6375

* fix ts lint

* feat: allow getting reactions by type over REST

* refactor: move the reaction object references to a variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants