Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Update to aspnetcore 2.1.0-preview1-28275 and react to feed layout changes #8611

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Update to aspnetcore 2.1.0-preview1-28275 and react to feed layout changes #8611

merged 1 commit into from
Feb 14, 2018

Conversation

natemcmaster
Copy link

React to aspnet/Universe#886.

Aspnetcore is changing the layout of files on the dotnetcli feed to be in its own subfolder. See aspnet/Universe#878 for more context.

Changes:

  • Update to aspnetcore 2.1.0-preview1-28275
  • Update dotnet-install.ps1/sh to use the new feed layout
  • Update to use Microsoft.AspNetCore.App instead of .All as the default aspnetcore runtime

cc @leecow @eerhardt

@johnbeisner
Copy link

johnbeisner commented Feb 14, 2018

@natemcmaster
Since there is only one approved version of the install scripts [dotnet-install.ps1; dotnet-install.sh] for all releases/versions/channels, and I am assuming that this PR represents the changes for aspnet going forward, all aspnetcore runtime assets that do not match the newer URL convention are now no longer supported by this install method.

@natemcmaster
Copy link
Author

Yes, that's correct. We want to get this layout change in now before we make the 2.1.300-preview1 release so we don't have to support the old url format. URL format should be "$azurefeed/aspnetcore/Runtime/", not "$azurefeed/Runtime" going forward.

@johnbeisner
Copy link

@natemcmaster
Microsoft.DotNet.Web.ItemTemplates 2.1.0-preview1-28275 doesn't seem to be published at: https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json; however 2.1.0-preview1-28272 is published.

@natemcmaster
Copy link
Author

I updated the aspnetcore-release feed to ensure 2.1.0-preview1-28275 is there.

@dotnet-bot test please

@natemcmaster
Copy link
Author

Hmm, that didn't trigger.

@dotnet-bot test this please

@pranavkm
Copy link

:shipit:

@natemcmaster
Copy link
Author

@johnbeisner PR validation passed now. Okay to merge?

@johnbeisner
Copy link

@natemcmaster
Do you need us to merge this?

@natemcmaster
Copy link
Author

Yes. I don't have permissions.

Also, should I make a PR to update dotnet-install.ps1/sh on other branches? Is release/2.0.0 still the "official" copy of these scripts?

@johnbeisner
Copy link

@natemcmaster
"should I make a PR to update dotnet-install.ps1/sh on other branches" - I'll take care of this - thanks for the offer.

@johnbeisner johnbeisner merged commit 62ce305 into dotnet:release/2.1.3xx Feb 14, 2018
@natemcmaster natemcmaster deleted the aspnetcore-feed branch February 14, 2018 19:50
@livarcocc livarcocc added this to the 2.1.3xx milestone Feb 14, 2018
livarcocc added a commit that referenced this pull request Feb 15, 2018
…ease/2.1.3xx-to-master

* dotnet/release/2.1.3xx:
  Update to aspnetcore 2.1.0-preview1-28275 and react to feed layout changes (#8611)
  "ExternalRestoreSources" needs to be set in the docker container (#8602)
  Signing nupkg contents (Cli.Utils and MSBuildResolver) along with the rest of the compiled assemblies.
  Use satellites from roslyn package, not cli-deps-satellites
  Update to roslyn 2.7.0-beta3-62612-07 for 2.1.1xx
  Support TildeSlash expand (#8589)
  Port Kernel Version telemetry to preview1
  Do not create a directory with a trailing space; it cannot be deleted by conventional methods. (#8587)
  Consume generic aspnetcore rpm installers
  Insert NuGet Build 4.6.0-rtm-4918 into cli
  Adding roslyn to automatic dependency flow through maestro.
  Fixing update dependency by using the new APIs. We broke this when we updated the version of VersionTools.
  MSBuild 15.6.81
  Update SDK to 2.1.300-preview1-62608-07
  MSBuild 15.6.80

 Conflicts:
	build/DependencyVersions.props
	test/Microsoft.DotNet.ShellShim.Tests/ShellShimMakerTests.cs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants