Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion: Suggest "await" after dot of awaitable expression #55817

Merged
merged 107 commits into from
Oct 19, 2021
Merged

Completion: Suggest "await" after dot of awaitable expression #55817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
107 commits
Select commit Hold shift + click to select a range
ca1226b
Suggest "await" after dotting an awaitable expression (suggestion onl…
MaStr11 Aug 23, 2021
56ab5cf
WIP:
MaStr11 Aug 24, 2021
3b169f8
CS Completion for await and async
MaStr11 Aug 24, 2021
d138ad7
Rename some tests
MaStr11 Aug 24, 2021
244e40a
Add tests for ValueTask and CustomAwaiter
MaStr11 Aug 24, 2021
6db9239
Add support for cursor in the middle of DotDot token
MaStr11 Aug 24, 2021
5ff9d09
Add support for corner cases
MaStr11 Aug 24, 2021
a32ccbc
Fix formatting
MaStr11 Aug 25, 2021
d0fae3c
Simplify test
MaStr11 Aug 25, 2021
e94955c
GetMarkup: Enclose {source} in CDATA
MaStr11 Aug 25, 2021
f2b6774
Add tests for different expressions.
MaStr11 Aug 25, 2021
00aab7a
Don't offer on the Task type
MaStr11 Aug 25, 2021
07d2455
Change delgate test case
MaStr11 Aug 25, 2021
5e6e6d0
Small test enhancements.
MaStr11 Aug 25, 2021
b8c0e43
Add completion test for different expressions
MaStr11 Aug 25, 2021
8d1b928
Add support for "ConfigureAwait" with one end-to-end test
MaStr11 Aug 25, 2021
1831669
Get syntaxKinds from syntaxFacts
MaStr11 Aug 25, 2021
c2fe20a
Use compilation.TaskType() for the IsConfigureAwaitable check.
MaStr11 Aug 26, 2021
74b7b20
Refactor GetTypeSymbolOfExpression
MaStr11 Aug 26, 2021
808fe46
Refactoring: Replace CompletionChangeEdit enum with keys in completio…
MaStr11 Aug 26, 2021
97e7956
Revert changes in GetTypeSymbolOfExpression
MaStr11 Aug 26, 2021
e6e840b
Use CompletionItem.FilterText to force "af" to select awaitf from the…
MaStr11 Aug 26, 2021
5311982
Change DotAwaitCompletionAddsAwaitInFrontOfExpressionForDifferentExpr…
MaStr11 Aug 26, 2021
66e8960
Add suggestion tests for await in lambdas
MaStr11 Aug 26, 2021
bf645ef
Move test case
MaStr11 Aug 26, 2021
e09ef9f
Transport targetToken position into GetChangeAsync. Addresses bugs, b…
MaStr11 Aug 26, 2021
ce779cd
Add combinatorial test for completion in lambdas.
MaStr11 Aug 26, 2021
189892d
Avoid the "local" completion bug in tests and enable "locals" test ca…
MaStr11 Aug 27, 2021
dd6325c
Add range operator test.
MaStr11 Aug 30, 2021
d241013
Fix VB AwaitCompletionProviderTests
MaStr11 Aug 30, 2021
5e5fbc9
VB: Add DotAwaitInAsyncSub test
MaStr11 Aug 30, 2021
2498bcb
Implement abstract members in VBs AwaitCompletionProvider
MaStr11 Aug 30, 2021
dd8f7fd
VB: WalkDownParentheses on MemberaccessExpression.Expression
MaStr11 Aug 31, 2021
08f5386
Convert remaining C# tests to VB (Part 1)
MaStr11 Aug 31, 2021
6fa6ab7
Convert remaining C# tests to VB (Part 2)
MaStr11 Aug 31, 2021
f4305ca
VB: Exclude Query context from Await completion
MaStr11 Aug 31, 2021
293ab38
Convert C# completion tests to VB (part 1)
MaStr11 Aug 31, 2021
27cedea
Convert C# completion tests to VB (part 2)
MaStr11 Aug 31, 2021
e5d2d98
Merge branch 'main' into AwaitCompletionAfterDot
MaStr11 Sep 2, 2021
8742e3c
Fix build errors after merge of main
MaStr11 Sep 2, 2021
581c422
Rename includeingAwaitf parameter to awaitf
MaStr11 Sep 3, 2021
07a8f56
Move GetDotAwaitKeywordContext to base class.
MaStr11 Sep 3, 2021
78ebf77
Add completion item description for "dotAwait"
MaStr11 Sep 6, 2021
01efce1
Add xlf files
MaStr11 Sep 6, 2021
bb72f5b
C#: Add support for "expectedDescriptionOrNull" in AwaitCompletionPro…
MaStr11 Sep 6, 2021
83b560e
VB: Add support for "expectedDescriptionOrNull" in AwaitCompletionPro…
MaStr11 Sep 6, 2021
4b7cd02
VB Tests: Fix missing expectedDescription handling in awaitf case
MaStr11 Sep 6, 2021
0fcd688
Formatting and refactorings in VerifyKeywordAsync
MaStr11 Sep 7, 2021
ab7dc34
Add partially written "await" tests to C#: DotAwaitCompletionAddsAwai…
MaStr11 Sep 7, 2021
2d9a142
C# test: Make sure, awaitf is not suggested on a custom awaitable, e…
MaStr11 Sep 7, 2021
c03b284
Merge branch 'main' into AwaitCompletionAfterDot
MaStr11 Sep 7, 2021
17f2bdd
Document formatting
MaStr11 Sep 7, 2021
cabd453
Be more explicit about the exact syntaxtree in GetAsyncSupportingDecl…
MaStr11 Sep 8, 2021
ca6b9ec
IsConfigureAwaitable: Add ValueTask
MaStr11 Sep 8, 2021
dd34761
Add workitem for skipped test TestDotAwaitSuggestBeforeLocalFunction
MaStr11 Sep 8, 2021
bc86dca
Add completion tests if "ConfigureAwait(false)" is already present.
MaStr11 Sep 8, 2021
8e78404
Refactor VB memberAccess cast
MaStr11 Sep 8, 2021
6f0da29
Remove line
MaStr11 Sep 8, 2021
5c7c1ed
Refactor DotAwaitCompletionAddsAwaitInFrontOfExpressionInLambdas
MaStr11 Sep 9, 2021
2de160c
Refactor DotAwaitCompletionAddsAwaitInFrontOfExpressionInLambdas: Mak…
MaStr11 Sep 9, 2021
b564816
Change "private protected" to "protected"
MaStr11 Sep 9, 2021
e3658fa
Rename ShouldBeTreatedAsTypeInsteadOfExpression to ShouldNameExpressi…
MaStr11 Sep 9, 2021
4da09b7
Don't say "awaitf-Keyword" in description.
MaStr11 Sep 9, 2021
d94e9de
Merge branch 'AwaitCompletionAfterDot' of https://github.com/MaStr11/…
MaStr11 Sep 9, 2021
cd69af1
Add test cases for VB query expressions.
MaStr11 Sep 9, 2021
45771df
VB: Await in Query clause: IsAwaitKeywordContext returns true in case…
MaStr11 Sep 9, 2021
6c80fc5
Add commit test for VB in query
MaStr11 Sep 9, 2021
ad9abb4
C#: Add support for Await in Query: From clause
MaStr11 Sep 9, 2021
ec72d9f
C#: Add support for Await in Query: Join clause
MaStr11 Sep 9, 2021
0d892bf
C#: await in query completion tests
MaStr11 Sep 9, 2021
ab23585
Null forgiving operator: Add test for "offer await".
MaStr11 Sep 13, 2021
b98212c
Completion test for null forgiving operator.
MaStr11 Sep 13, 2021
047d098
Merge remote-tracking branch 'upstream/main' into AwaitCompletionAfte…
MaStr11 Sep 16, 2021
8875d87
Merge remote-tracking branch 'upstream/main' into AwaitCompletionAfte…
MaStr11 Sep 22, 2021
5c5a96c
Merge remote-tracking branch 'upstream/main' into AwaitCompletionAfte…
MaStr11 Sep 22, 2021
6a9cba9
Merge remote-tracking branch 'upstream/main' into AwaitCompletionAfte…
CyrusNajmabadi Oct 12, 2021
ad4ef46
Fix typo
MaStr11 Oct 13, 2021
2616001
Make LanguageVersion optional
MaStr11 Oct 13, 2021
2e8631a
Apply suggestions from code review
MaStr11 Oct 13, 2021
b951736
Mark ConfigureAwait as locked in resx.
MaStr11 Oct 13, 2021
3e65e5b
xlf generated
MaStr11 Oct 13, 2021
9299d86
Revert some changes from CodeReview and fix compile errors
MaStr11 Oct 13, 2021
48f91b5
Refactor GetTypeSymbolOfExpression.
MaStr11 Oct 13, 2021
5c40d56
Remove private static class AwaitCompletionChange
MaStr11 Oct 13, 2021
3b80d14
Debug.Fail instead of Debug.Assert false
MaStr11 Oct 13, 2021
e0db13d
IsAwaitableNonDynamic is handling null and is annotated (NotNullWhenT…
MaStr11 Oct 13, 2021
80543c2
Make syntactic checks before semantic.
MaStr11 Oct 13, 2021
d25bb3b
Add yield break; before local function
MaStr11 Oct 13, 2021
e445020
Inline AddKey helper method.
MaStr11 Oct 13, 2021
53ac841
Unify GetDotTokenLeftOfPosition between AwaitCompletionProvider and U…
MaStr11 Oct 13, 2021
5020a2f
Remove "Make container async" inline description.
MaStr11 Oct 14, 2021
a47d491
Remove unsed parameter after removal of inlineDescription
MaStr11 Oct 14, 2021
71aa4c6
Cache and lazy evaluate awaitDisplayText, falseKeyword, awaitfDisplay…
MaStr11 Oct 14, 2021
e8dfec2
Remove unused makeContainerAsync parameter from VB test
MaStr11 Oct 14, 2021
72c214a
Add some more tests for statements after the dot
MaStr11 Oct 14, 2021
7624178
Remove unused makeContainerAsync parameter in VB tests
MaStr11 Oct 14, 2021
3e1c2d1
Merge remote-tracking branch 'upstream/main' into AwaitCompletionAfte…
CyrusNajmabadi Oct 19, 2021
59154fc
Simplify
CyrusNajmabadi Oct 19, 2021
02d98b5
Invert
CyrusNajmabadi Oct 19, 2021
69d5a74
Simplify
CyrusNajmabadi Oct 19, 2021
1e6544d
Cleanup
CyrusNajmabadi Oct 19, 2021
7f88a26
Make private and inline
CyrusNajmabadi Oct 19, 2021
9e6144e
Simplify
CyrusNajmabadi Oct 19, 2021
d0d5a39
Simplify
CyrusNajmabadi Oct 19, 2021
f0ebe68
cleanup imports
CyrusNajmabadi Oct 19, 2021
4653402
Consistent impl
CyrusNajmabadi Oct 19, 2021
5f4f162
Deal with no token found
CyrusNajmabadi Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...atures/CSharpTest/Completion/CompletionProviders/AbstractCSharpCompletionProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ protected static string GetMarkup(string source, LanguageVersion languageVersion
=> $@"<Workspace>
<Project Language=""C#"" AssemblyName=""Assembly1"" CommonReferences=""true"" LanguageVersion=""{languageVersion.ToDisplayString()}"">
<Document FilePath=""Test2.cs"">
<![CDATA[
{source}
]]>
</Document>
</Project>
</Workspace>";
Expand Down
Loading