Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight the search term in the options page #61301

Merged
merged 4 commits into from
Jun 30, 2022

Conversation

davidwengier
Copy link
Contributor

@davidwengier davidwengier commented May 13, 2022

Looks like this:
OptionsDialog

@davidwengier davidwengier force-pushed the OptionsPageHighlighting branch 2 times, most recently from ca414cf to e064dcf Compare June 21, 2022 03:29
@davidwengier davidwengier marked this pull request as ready for review June 21, 2022 04:00
@davidwengier davidwengier requested a review from a team as a code owner June 21, 2022 04:00
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this and think we will want to schedule a UX review to get feedback.

Copy link
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this :)

@davidwengier
Copy link
Contributor Author

✅ UX team have signed off

@davidwengier davidwengier added the UX Review Complete UX Review Complete label Jun 30, 2022
@davidwengier davidwengier enabled auto-merge (squash) June 30, 2022 20:14
@davidwengier davidwengier merged commit e101ceb into dotnet:main Jun 30, 2022
@ghost ghost added this to the Next milestone Jun 30, 2022
@davidwengier davidwengier deleted the OptionsPageHighlighting branch June 30, 2022 21:56
333fred added a commit that referenced this pull request Jul 5, 2022
…ures/semi-auto-props

* upstream/main: (887 commits)
  Ensure elastic trivia for reusable syntax in field generator (#62346)
  Fix typos in the incremental generators doc (#62343)
  Theme The "Generate Overrides" Dialog (#62244)
  Walk green-nodes in incremental-generator attribute-finding path (#62295)
  Cache the hash in compilation options (#62289)
  Respect dotnet_style_namespace_match_folder (#62310)
  Remove unreachable condition
  Specify builder capacities in incremental generation to avoid wasted scratch arrays. (#62285)
  Skip the test (#62287)
  Revert "Revert "Add Move Static Member To Existing Type (#61519)"" (#62284)
  Highlight the search term in the options page (#61301)
  Synch handlers with fix (#62209)
  Disable integration tests
  Fix
  Set capacity of builder to avoid expensive garbage.
  Add public APIs for opened and closed event handling for non-source documents
  Handle possible null symbols in `getAttributeTarget` (#62137)
  Perform a lookahead rather than a parsing attempt in order to determine if current token starts a conversion operator declaration. (#62240)
  Fix a race in CachingDictionary. (#62248)
  Simplify
  ...
@allisonchou allisonchou modified the milestones: Next, 17.4 P1 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants