-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme The "Generate Overrides" Dialog #62244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -56,7 +63,8 @@ | |||
<GroupBox x:Uid="MemberSelectionGroupBox" | |||
Margin="0, 9, 0, 0" | |||
Grid.Row="1" | |||
Header="{Binding ElementName=dialog, Path=PickMembersTitle}"> | |||
Header="{Binding ElementName=dialog, Path=PickMembersTitle}" | |||
Foreground="{DynamicResource {x:Static vs:ThemedDialogColors.HeaderTextBrushKey}}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a Theme color we should be using for the box Border?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be automatically done with vs:ThemedDialogStyleLoader.UseDefaultThemedDialogStyles="True"
@Youssef1313 I'm working on themeing across the board. See an updated #55971 for some of these. I think what's left will be
I'll get those last 3 in another PR after #55971 gets in |
…ures/semi-auto-props * upstream/main: (887 commits) Ensure elastic trivia for reusable syntax in field generator (#62346) Fix typos in the incremental generators doc (#62343) Theme The "Generate Overrides" Dialog (#62244) Walk green-nodes in incremental-generator attribute-finding path (#62295) Cache the hash in compilation options (#62289) Respect dotnet_style_namespace_match_folder (#62310) Remove unreachable condition Specify builder capacities in incremental generation to avoid wasted scratch arrays. (#62285) Skip the test (#62287) Revert "Revert "Add Move Static Member To Existing Type (#61519)"" (#62284) Highlight the search term in the options page (#61301) Synch handlers with fix (#62209) Disable integration tests Fix Set capacity of builder to avoid expensive garbage. Add public APIs for opened and closed event handling for non-source documents Handle possible null symbols in `getAttributeTarget` (#62137) Perform a lookahead rather than a parsing attempt in order to determine if current token starts a conversion operator declaration. (#62240) Fix a race in CachingDictionary. (#62248) Simplify ...
fixes #61812
We were in a mix of themed and unthemed. This PR themes the entire dialog for use.
Original (Before Fix)
Blue Theme
Dark Theme