Walk green-nodes in incremental-generator attribute-finding path #62295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to walk the syntax tree both to find the global aliases that may be in a file, and also to look for attributes.
This change has us walk the green tree instead, especially so we can bail out from checking trees that don't have any attributes, without realizing the red-tree. This save 100MB of ram in incremental testing (About 7.5%).
Before:
After: