Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to features/required-members #61328

Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from main into features/required-members.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/main-to-features/required-members
git reset --hard upstream/features/required-members
git merge upstream/main
# Fix merge conflicts
git commit
git push upstream merges/main-to-features/required-members --force

tmat and others added 30 commits May 4, 2022 17:18
* Revert to pass isBlocking as a parameter

* link
…to-release/dev16.11-vs-deps

Merge release/dev16.9-vs-deps to release/dev16.11-vs-deps
…rges/release/dev16.11-vs-deps-to-release/dev17.0-vs-deps
…-to-release/dev17.0-vs-deps

Merge release/dev16.11-vs-deps to release/dev17.0-vs-deps
…to-release/dev17.1

Merge release/dev17.0-vs-deps to release/dev17.1
…ocal-function

Suggest `fixed` keyword in unsafe local functions
Add EA layer for ASP.NET Core.
Hard select item from default source when filter text is empty
ryzngard and others added 17 commits May 12, 2022 22:33
With the new experience no longer blocking the UI thread, we want to enable this feature by default in 17.3
* Update dependency versions for 4.2.0 publishing

Updates our nuget versions for 4.2.0, so that all published binaries will depend on publicly-available non-prerelease packages. As part of this, I removed explicit MSBuild references where they were unneeded, now that Microsoft.VisualStudio.Shell.15.0 is advertising their MSBuild dependency.
Use SegmentedHashSet<T> to eliminate LOH allocations in AsyncBatchingWorkQueue
More SyntaxContext sharing among CompletionProviders
* Fix several LSP completion kind mappings

* Extension method
…se/dev17.3

Merge release/dev17.2 to release/dev17.3
Fix crash when a multi-line raw literal becomes a skipped token.
Add an UWP OptProf test for IDE
…rmatter. (#60522)

* Implement IDkmClrFullNameProvider2 in Roslyn's ResultProvider Formatter.

Issue:
- Debugger added IDkmClrFullNameProvider2 API with https://devdiv.visualstudio.com/DevDiv/_git/Concord/pullrequest/301518
- It is currently temporarily implement in Concord, needs to be implemented in Roslyn so implementation can be removed from Concord.

Changes:
1. Formatter:
- Implement IDkmClrFullNameProvider2. It has 2 methods, one to format local names and the other given field metadata.
- Currently only implemented for C#. I'm not that familiar with VB and the GeneratedNames stuff in VB needs some splitting and moving around to get working.

2. Unit tests:
- Add unit tests for the common cases of hoisted locals, synthesized locals, etc.

3. Versions.props:
Update MicrosoftVSSDKVSDConfigToolVersion to a newer version which recognizes IDkmClrFullNameProvider2.

* PR feedback - fix casing of MetadataImport

* PR feedback - move GetOriginalLocalVariableName, GetOriginalFieldName back to CSharpFormatter

Co-authored-by: Ramkumar Ramesh <[email protected]>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@dotnet-bot dotnet-bot merged commit 9b63c76 into features/required-members May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.