Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev17.4 to release/dev17.5-vs-deps #68149

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from release/dev17.4 into release/dev17.5-vs-deps.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/release/dev17.4-to-release/dev17.5-vs-deps
git reset --hard upstream/release/dev17.5-vs-deps
git merge upstream/release/dev17.4
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.4-to-release/dev17.5-vs-deps --force

dibarbet and others added 30 commits May 26, 2022 10:49
The package becomes public accidentally so we don't need to add the nuget feeds
MSRC fix. According to the mail, we should update to 16.5.28.

The feature branch is based on #66423
The last checked in bug fix is #66359

Since QB doesn't want to approve #66398 now. I feel we shouldn't wait for that change to merge
…411.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22524.5 -> To Version 7.0.0-beta.23211.2
… darc-release/dev17.0-vs-deps-aa698329-9cc5-493d-a240-5ac8bfeee6c1
* Don't overwrite binary logs

Several of our legs were calling `build.ps1 -binaryLog` in a row and
that re-uses the binary log file name which causes an overwrite. This
change allows us to specify the name and adds a warning if we do
accidentally overwrite in the future.

* enable trace for diff issue

* Work around NuGet static graph restore bug

NuGet/Home#12373
* Don't overwrite binary logs in CI

This will make it an error whenever we overwrite a binary log during CI.
Doing so means we've lost one of our main tools for investigating build
failures. Turning this into an error so we don't make the mistake
again.

* actually fail

* fixup
* Disable static restore in more locations

* Run compilers CI when build scripts change

* Include compiler generators in compilers code change check

* Remove separate restore in bootstrap build
…421.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.23211.2 -> To Version 7.0.0-beta.23221.2
Flow the telemetry update change from feature branch to 17.0 release branch
Flow the telemetry update change from feature branch to 17.2 release branch
…merges/release/dev17.0-vs-deps-to-release/dev17.2
…to-release/dev17.2

Merge release/dev17.0-vs-deps to release/dev17.2
…428.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.23211.2 -> To Version 7.0.0-beta.23228.7
@dotnet-bot dotnet-bot requested review from a team as code owners May 10, 2023 00:02
@dotnet-bot dotnet-bot added Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch. labels May 10, 2023
@dotnet-bot
Copy link
Collaborator Author

⚠ This PR has merge conflicts. @dibarbet

@dotnet-bot dotnet-bot enabled auto-merge May 10, 2023 00:02
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@dotnet-bot dotnet-bot merged commit 870c38d into release/dev17.5-vs-deps May 11, 2023
@Cosifne Cosifne assigned Cosifne and unassigned dibarbet May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants