Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge internal fork of LSP tools back into Roslyn #68461

Merged
merged 393 commits into from
Jun 8, 2023

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Jun 6, 2023

This merges the internal fork of the LSP tools host code (powering the new pre release version of the C# extension) back into Roslyn main.

Insertion validation (internal) - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/476965

ryzngard and others added 8 commits May 26, 2023 00:48
NodeJS launched processes do not have a default error mode of 0 (the system default), so Windows Error Reporting won't work on the server process.
… dependencies directory

Will allow us to avoid inserting extra assemblies with Roslyn DevKit that are already in the shared dependencies inserted by vs-green-server.

Shared dependencies are loaded only withing the load context of the DevKit extension.

Follow ups:
- https://devdiv.visualstudio.com/DevDiv/_git/vscode-csharp-next/pullrequest/473154
- https://dev.azure.com/dnceng/internal/_git/dotnet-roslyn/pullrequest/31422
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 6, 2023
@dibarbet dibarbet force-pushed the dev/dibarbet/merge_lsp_tools_host branch from c29306a to cb093f2 Compare June 6, 2023 23:35
@dibarbet dibarbet force-pushed the dev/dibarbet/merge_lsp_tools_host branch from cb093f2 to 6a9eb9e Compare June 6, 2023 23:58
@dibarbet
Copy link
Member Author

dibarbet commented Jun 8, 2023

Speedometer and RPS both passed. This is good to go as soon as CI finishes

@dibarbet dibarbet marked this pull request as ready for review June 8, 2023 17:38
@dibarbet dibarbet requested review from a team as code owners June 8, 2023 17:38
@dibarbet dibarbet enabled auto-merge June 8, 2023 17:51
@dibarbet dibarbet merged commit 384f18b into dotnet:main Jun 8, 2023
@ghost ghost added this to the Next milestone Jun 8, 2023
@RikkiGibson RikkiGibson modified the milestones: Next, 17.7 P3 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.