Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge internal fork of LSP tools back into Roslyn #68461

Merged
merged 393 commits into from
Jun 8, 2023
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Mar 22, 2023

  1. Docs

    CyrusNajmabadi committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    e6c2906 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de79450 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4eb534f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aaaab06 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Configuration menu
    Copy the full SHA
    f12904e View commit details
    Browse the repository at this point in the history
  2. Fix tests

    dibarbet committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    23f6748 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    06ec2b5 View commit details
    Browse the repository at this point in the history
  4. Simplify

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    16e6510 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2e90ae2 View commit details
    Browse the repository at this point in the history
  6. Fixup tests

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    4f0f25d View commit details
    Browse the repository at this point in the history
  7. Add tesT

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    4b2c6d8 View commit details
    Browse the repository at this point in the history
  8. Add test

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    9eb829b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d42cf2a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    8a3a60e View commit details
    Browse the repository at this point in the history
  11. Latest updates

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    8a969dc View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    bed5cb3 View commit details
    Browse the repository at this point in the history
  13. Add comment

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    bc06cb3 View commit details
    Browse the repository at this point in the history
  14. Make void again

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    7c58f3c View commit details
    Browse the repository at this point in the history
  15. Revert

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    2e0a509 View commit details
    Browse the repository at this point in the history
  16. Simplify

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    f95bd61 View commit details
    Browse the repository at this point in the history
  17. Revert

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    1797707 View commit details
    Browse the repository at this point in the history
  18. Update tests

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    068999a View commit details
    Browse the repository at this point in the history
  19. Update tests

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    b1bf39d View commit details
    Browse the repository at this point in the history
  20. Add docs

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    d38197e View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    a82ee63 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    8260eef View commit details
    Browse the repository at this point in the history
  23. Update comment

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    4aa580b View commit details
    Browse the repository at this point in the history
  24. Add docs

    CyrusNajmabadi committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    29a6d67 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    5556afc View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Configuration menu
    Copy the full SHA
    e387f9c View commit details
    Browse the repository at this point in the history
  2. Merged PR 30203: merge roslyn

    dibarbet authored and CyrusNajmabadi committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    d2b1726 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f51176c View commit details
    Browse the repository at this point in the history
  4. revert

    CyrusNajmabadi committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    1ae61f2 View commit details
    Browse the repository at this point in the history
  5. Warning

    CyrusNajmabadi committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    c45987e View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Configuration menu
    Copy the full SHA
    1f42d67 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f9cec1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e714fac View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5890599 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9b4b52c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e01f9f7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d8d34c8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b1d3f8a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    81bfdd5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    70b69d1 View commit details
    Browse the repository at this point in the history
  11. Merged PR 30204: Have LanguageServerWorkspace implement new ILspWorkp…

    …ace api
    
    Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1691478
    
    This allows the workpsace in vscode to have changes push-through to the in-memory workspace, avoiding the need to fork the solution so often.  Implements the work done in dotnet#67443.
    CyrusNajmabadi committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    176d64d View commit details
    Browse the repository at this point in the history
  12. Review feedback

    dibarbet committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    fb93453 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    5f282e3 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Configuration menu
    Copy the full SHA
    b494f08 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Configuration menu
    Copy the full SHA
    e0590a9 View commit details
    Browse the repository at this point in the history
  2. Merged PR 30283: Add telemetry MEF import for VS Dev kit

    Gets us publishing an npm package that will be added as a component to VS Dev kit.
    
    Left to do:
    
    * [ ] Import the new service in LSP
    * [ ] Make changes to VS Dev kit repo to add component
    * [ ] Add integration tests in VS Dev kit
    ryzngard committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    759fe7e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    92c1e22 View commit details
    Browse the repository at this point in the history
  4. Revert

    CyrusNajmabadi committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    55ae57f View commit details
    Browse the repository at this point in the history
  5. Add todo

    CyrusNajmabadi committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    7e0c54f View commit details
    Browse the repository at this point in the history
  6. Merged PR 30344: Properly hook up file open/close handling

    Properly hook up file open/close handling
    CyrusNajmabadi committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    6458965 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Split apart the LanguageServerProjectSystem type

    There are two responsbilities of this type, currently:
    
    1. Actually creating the workspace and associated types.
    2. Loading a solution, running design time builds, and populating the
       stuff created in 1.
    
    This splits those responsbilities into two types. The latter is kept
    in the same name, the former is renamed to the very pithy
    "LanguageServerWorkspaceFactory".
    jasonmalinowski committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    a15f420 View commit details
    Browse the repository at this point in the history
  2. Rename disposalToken to cancellationToken

    This can also be cancelled if we were to cancel the work in the queue.
    jasonmalinowski committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    e88ae11 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5ba3e9e View commit details
    Browse the repository at this point in the history
  4. Remove the --solutionPath flag entirely

    If you need to open a solution, now send the solution/open LSP
    notification.
    jasonmalinowski committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    74cae5a View commit details
    Browse the repository at this point in the history
  5. Merged PR 30239: Remove the --solutionPath flag and add a LSP notific…

    …ation instead
    
    Commit at a time will break this down a bit.
    jasonmalinowski committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    c6ee1b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Configuration menu
    Copy the full SHA
    202da66 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee4f153 View commit details
    Browse the repository at this point in the history
  3. Merged PR 30325: Semantic snippets - turn feature off in C# extension

    Disabling until we have a plan to remove the existing snippets.
    
    Tracking here: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1782057
    akhera99 committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    2feb670 View commit details
    Browse the repository at this point in the history
  4. Merged PR 30375: Lack of ruleset service should not crash LanguageServer

    Lack of ruleset service should not crash the language server
    arunchndr committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    e220220 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Configuration menu
    Copy the full SHA
    ee242ed View commit details
    Browse the repository at this point in the history
  2. PR feedback

    davidwengier committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    6ef07a7 View commit details
    Browse the repository at this point in the history
  3. More PR feedback

    davidwengier committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    e5b5c3e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    be8f1d8 View commit details
    Browse the repository at this point in the history
  5. Merged PR 30345: Hook up fault telemetry initialize if it's available

    Hook up fault telemetry initialize if it's available. This now fully works as long as the right binaries are manually added to the extension folder
    
    * [X] Tested with and without binaries being available
    * [X] Tested that nupkg is produced with right dependencies
    * [ ] Add as an ILogger implementation to report telemetry
    * [ ] NPM package is produced
    ryzngard committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    15b0d1d View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Configuration menu
    Copy the full SHA
    2806d33 View commit details
    Browse the repository at this point in the history
  2. Merged PR 30400: Add Logger.SetLogger to initializer

    This sets it so the VSCode fault reporter also signs up to report telemetry that is sent through Logger.Log
    ryzngard committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    72fb9bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    25749a9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4569382 View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'origin/features/lsp_tools_host' into de…

    …v/dawengie/InitializeRazor
    davidwengier committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    2800607 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2cedd3e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Fix vesrion number

    davidwengier committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    79fbf7a View commit details
    Browse the repository at this point in the history
  2. Merged PR 30445: Fix compliance warnings by moving npmrc next to pack…

    …age.json
    
    Fix compliance warnings by moving npmrc next to package.json
    dibarbet committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    2fc6096 View commit details
    Browse the repository at this point in the history
  3. Merged PR 30465: Merge roslyn/main

    dibarbet authored and arunchndr committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    032a53e View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Configuration menu
    Copy the full SHA
    eb6785a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    456b18a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5b7fe14 View commit details
    Browse the repository at this point in the history
  4. Merged PR 30378: Initialize the Razor workspace listener when we find…

    … out there is at least one Razor file
    
    Call into Razor when there is a razor file so Razor can produce the project.razor.vscode.json file to make things work.
    
    Not merging until Razor bits are in and packages available. Razor PR is dotnet/razor#8559
    
    Part of https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1782085
    davidwengier authored and phil-allen-msft committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    b42dbf7 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Configuration menu
    Copy the full SHA
    2491f4f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e039a3a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    030a51e View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Configuration menu
    Copy the full SHA
    a636e94 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    67a8e41 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    57ff1bf View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Merged PR 30539: Update Razor ExternalAccess.Roslyn version

    Update Razor ExternalAccess.Roslyn version (contains Dustin's change dotnet/razor#8586)
    allisonchou committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    fe10be7 View commit details
    Browse the repository at this point in the history
  2. updating assembly load

    lacomc committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    b72925a View commit details
    Browse the repository at this point in the history
  3. removing unused parameter

    lacomc committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    e51d34d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a351222 View commit details
    Browse the repository at this point in the history
  5. Merged PR 30538: Add a LSP command to handle complex completion edit

    Add a LSP command to handle complex completion edit
    
    Address https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1777136
    
    Corresponding PR in vscode extension:
    https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/vscode-csharp-next/pullrequest/464748
    
    TODO:
    Add test in LanguageServer.Tests
    genlu committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    6d433db View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Configuration menu
    Copy the full SHA
    cf6feda View commit details
    Browse the repository at this point in the history
  2. Implement an LSP-based file watcher

    This delegates file watching to the LSP client via the LSP file watching
    protocol, if it's supported. This allows us to avoid having to deal with
    all the platform-specific challenges of file watching if we can.
    jasonmalinowski committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    9975bff View commit details
    Browse the repository at this point in the history
  3. Create our directory watches for references more lazily

    This allows us to deal with a circularity in initialization of LSP,
    where we don't know if we can use LSP yet to watch for files until
    we've already tried to watch for files.
    jasonmalinowski committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    8f190b6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    52bb76d View commit details
    Browse the repository at this point in the history
  5. Work around an issue in Microsoft.VisualStudio.LanguageServer.Protocol

    There is a DataMember attribute that has a "correct" spelling, but
    the LSP spec itself has a misspelling that we must match.
    jasonmalinowski committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    0c35d2d View commit details
    Browse the repository at this point in the history
  6. Merged PR 30498: Implement an LSP-based file watcher

    This delegates file watching to the LSP client via the LSP file watching protocol, if it's supported. This allows us to avoid having to deal with all the platform-specific challenges of file watching if we can.
    jasonmalinowski committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    af03916 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d94a6a7 View commit details
    Browse the repository at this point in the history
  8. missing slash

    lonitra committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    3cfb4a5 View commit details
    Browse the repository at this point in the history
  9. change check to if statement

    lonitra committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    6e4745d View commit details
    Browse the repository at this point in the history
  10. Merged PR 30615: Add Scheme for Virtual Files

    Roslyn assumes that the scheme portion of a URI is 'file:', however this is not the scheme for razor csharp files and the correct scheme is needed when looking up what razor documents are being tracked by Roslyn. This is a temporary workaround that checks to see if the passed in file path is one of razor's csharp files and adds the correct scheme before creating the URI.
    lonitra committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    ee23dcd View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Merged PR 30494: IntelliCode: Loading Required Assemblies for Telemetry

    - loading additional assemblies into IntelliCode Starred Suggestions ALC
      - assemblies are packaged with the starred suggestions npm package
    lacomc committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    00d6310 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    95c1bfa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5216e3e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5be2dd7 View commit details
    Browse the repository at this point in the history
  5. Add code style options

    Cosifne committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    e755cbe View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    09f1b28 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    20e22cd View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2023

  1. Configuration menu
    Copy the full SHA
    359f2b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Configuration menu
    Copy the full SHA
    f0b57dc View commit details
    Browse the repository at this point in the history
  2. Merged PR 30703: Workaround codelens resolving for old version

    Still trying to get the client to stop sending the request, but in the meantime this should avoid flashing the missing command string
    
    microsoft/vscode-internalbacklog#3884 (comment)
    
    Since we technically only care about the version for calculating the references and the client always sends a correct request later on, it should be ~ok to return a command with an empty set of references.
    
    What it looks like with this change
    https://user-images.githubusercontent.com/5749229/232164240-2c9620db-3c4d-4ddd-8770-f8d951d9f48f.gif
    dibarbet committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    f602951 View commit details
    Browse the repository at this point in the history
  3. Merged PR 30711: Don't throw if the complex text edit display text is…

    … shorter than the list range
    
    Don't throw if the complex text edit display text is shorter than the list range
    dibarbet committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ea83ea8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7d833d2 View commit details
    Browse the repository at this point in the history
  5. Fix test

    Cosifne committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    f3f4d0b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f8ad615 View commit details
    Browse the repository at this point in the history
  7. Merge remote-tracking branch 'dnceng/features/lsp_tools_host' into de…

    …v/shech/AddCodeStyleOptions
    Cosifne committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    0187c25 View commit details
    Browse the repository at this point in the history
  8. Merged PR 30520: Add refresh support for inlay hints and code lens

    Abstracted out the refresh work that Semantic Tokens does.
    Inlay hints need to be refreshed on any option change as well.
    
    Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1784802
    akhera99 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    688b151 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    37d2c3e View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Configuration menu
    Copy the full SHA
    9f0333e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    686b557 View commit details
    Browse the repository at this point in the history
  3. Merged PR 30699: Add code style options to configuration refresh list

    Add code style options to the configuration refresh list.
    By convention, we don't want to have any global fallback for code-style options.
    However, vscode already has these configurations on its configuration page, it would be good to link these configuration to the server.
    
    Client-side change: https://devdiv.visualstudio.com/DevDiv/_git/vscode-csharp-next/pullrequest/463184
    Cosifne committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    ce1e885 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b27410e View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'mirror/features/lsp_tools_host' into de…

    …v/dibarbet/diagnostic_adjustments
    dibarbet committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    daa121d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0ae93eb View commit details
    Browse the repository at this point in the history
  7. Implement IExtensionManager in our LSP host

    This is a trivial implementation that just reports the error back
    via the error log; we probably should do something fancier but this
    at least means we aren't swallowing problems.
    jasonmalinowski committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    7bbc488 View commit details
    Browse the repository at this point in the history
  8. Remove error logging since exceptions are already logged

    Now that we're logging all stuff from our IExtensionManager
    implementation, we don't need explicit logging. This allows for further
    cleanup then.
    jasonmalinowski committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    97c05c8 View commit details
    Browse the repository at this point in the history
  9. Merged PR 30780: Implement IExtensionManager in our LSP host

    This is a trivial implementation that just reports the error back via the error log; we probably should do something fancier but this at least means we aren't swallowing problems.
    
    Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1782895/
    jasonmalinowski committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    0cf773b View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Use simple hello world to prevent callback from throwing if green has…

    …n't registered the service
    dibarbet committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    fa9388e View commit details
    Browse the repository at this point in the history
  2. Watch Razor files

    davidwengier committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    a03d0fd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    567407b View commit details
    Browse the repository at this point in the history
  4. Merged PR 30486: Add option to enable telemetry

    Following https://code.visualstudio.com/api/extension-guides/telemetry we should use VS Code settings for telemetry levels. https://devdiv.visualstudio.com/DevDiv/_git/vscode-csharp-next/pullrequest/464145?_a=files adds the corresponding change on the extension side
    ryzngard committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    de200b1 View commit details
    Browse the repository at this point in the history
  5. Extract local

    davidwengier committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    c08f955 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e72d577 View commit details
    Browse the repository at this point in the history
  7. Merged PR 30786: Watch Razor files

    This makes sure that changes to razor files make it into the workspace.
    davidwengier committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    0390b9b View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Configuration menu
    Copy the full SHA
    f25ae52 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e817d06 View commit details
    Browse the repository at this point in the history
  3. DiagnosticRefresher

    tmat committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    8d84bab View commit details
    Browse the repository at this point in the history
  4. Mvoe to nested type

    tmat committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    3c5a4e7 View commit details
    Browse the repository at this point in the history
  5. Rename

    tmat committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    af885f4 View commit details
    Browse the repository at this point in the history
  6. Fix comments

    tmat committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    7f47ff2 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Merged PR 30836: IntelliCode: Changing Text from Green to C# Dev Kit

    - updating text and renaming files
    lacomc committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    5974adc View commit details
    Browse the repository at this point in the history
  2. Feedback

    tmat committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    98b1283 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2ccef84 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f541e67 View commit details
    Browse the repository at this point in the history
  5. Merged PR 30835: Adds DiagnosticRefreshQueue and IDiagnosticRefresher…

    … that can be used to trigger pull diagnostic refresh
    
    ... from the server.
    tmat committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    c12e7f8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a2cf59a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    190e947 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Merged PR 30849: Switch to ServerGC in LanguageServer

    Well, should we do it? ;)
    genlu committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    efdbe7b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec78083 View commit details
    Browse the repository at this point in the history
  3. Merged PR 30834: Add component wrapper for telemetry

    This changes telemetry to use a component wrapper, similar to intellicode. This ensures we don't need MEF to call to the component if it's available, and loads it into it's own ALC.
    
    This also removes any dependencies the internal component has on Roslyn code, which allows it to exist in an isolated way.
    ryzngard committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    5cf3a31 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    53a9de1 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Fix

    tmat committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    7a4b41d View commit details
    Browse the repository at this point in the history
  2. Merged PR 30841: Use VS host workspace services

    Use VS host workspace services
    dibarbet committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    99ed3cf View commit details
    Browse the repository at this point in the history
  3. Merged PR 30844: Reduce payload size for completion request

    first part of https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1804538
    
    The benchmark result (for 10k items)
    
    Before:
    ```
    BenchmarkDotNet=v0.13.0, OS=Windows 10.0.22621
    Intel Core i9-10885H CPU 2.40GHz, 1 CPU, 16 logical and 8 physical cores
      [Host]     : .NET Framework 4.8 (4.8.9139.0), X86 LegacyJIT
      Job-FTOBUC : .NET Framework 4.8 (4.8.9139.0), X86 LegacyJIT
    
    InvocationCount=1  UnrollFactor=1
    
    |        Method |     Mean |   Error |  StdDev |     Gen 0 |     Gen 1 | Gen 2 | Allocated |
    |-------------- |---------:|--------:|--------:|----------:|----------:|------:|----------:|
    | Serialization | 148.4 ms | 1.94 ms | 1.81 ms | 2000.0000 | 2000.0000 |     - |     24 MB |
    ```
    
    after
    ```
    BenchmarkDotNet=v0.13.0, OS=Windows 10.0.22621
    Intel Core i9-10885H CPU 2.40GHz, 1 CPU, 16 logical and 8 physical cores
      [Host]     : .NET Framework 4.8 (4.8.9139.0), X86 LegacyJIT
      Job-FTOBUC : .NET Framework 4.8 (4.8.9139.0), X86 LegacyJIT
    
    InvocationCount=1  UnrollFactor=1
    
    |        Method |     Mean |    Error |   StdDev |     Gen 0 |     Gen 1 | Gen 2 | Allocated |
    |-------------- |---------:|---------:|---------:|----------:|----------:|------:|----------:|
    | Serialization | 56.02 ms | 1.699 ms | 4.873 ms | 1000.0000 | 1000.0000 |     - |     10 MB |
    ```
    genlu committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    7dff3db View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Merged PR 30895: Merge main

    arunchndr committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    fc1582a View commit details
    Browse the repository at this point in the history
  2. Add missing rename service

    Cosifne committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    0c21c57 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a8d498 View commit details
    Browse the repository at this point in the history
  4. Revert "Change the ApplyChangesOperation"

    This reverts commit 6a8d498.
    Cosifne committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    d98cb48 View commit details
    Browse the repository at this point in the history
  5. Revert "Add missing rename service"

    This reverts commit 0c21c57.
    Cosifne committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    94dc877 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    93f8a8c View commit details
    Browse the repository at this point in the history
  7. Merged PR 30906: Check if ISymbolRenamedCodeActionOperationFactoryWor…

    …kspaceService is missing when rename for naming violation
    
    Fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1806593
    LSP server don't need to do extra works in ISymbolRenamedCodeActionOperationFactoryWorkspaceService.
    So we should check the if it's null or not
    Cosifne committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    245ebb5 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Merged PR 30919: Fix path to npmrc

    ryzngard authored and arunchndr committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    df3a6ab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5565de4 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Merged PR 30816: Add publish for npm package

    Add publish for npm package to dotnet-tools-internal
    ryzngard committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    fc647e3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    31f979c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c624b63 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. Configuration menu
    Copy the full SHA
    9415d4a View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2023

  1. Bump Razor

    davidwengier committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    c548c5c View commit details
    Browse the repository at this point in the history
  2. Fix comment

    davidwengier committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    b73891e View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Configuration menu
    Copy the full SHA
    005e13b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf41f7b View commit details
    Browse the repository at this point in the history
  3. Merged PR 30955: Fix regression in complex edit completion

    Fix ComplexEdit completion
    genlu committed May 1, 2023
    Configuration menu
    Copy the full SHA
    c6186a2 View commit details
    Browse the repository at this point in the history
  4. Remove sln file

    ryzngard committed May 1, 2023
    Configuration menu
    Copy the full SHA
    f2240e0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7e7c9c0 View commit details
    Browse the repository at this point in the history
  6. Add runtime dependencies

    ryzngard committed May 1, 2023
    Configuration menu
    Copy the full SHA
    8b7a623 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ce0e855 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Merged PR 30977: Update npm package

    Best reviewed commit by commit.
    
    * Rename the package
    * Update the package by adding runtime dependencies in the pack
    ryzngard committed May 2, 2023
    Configuration menu
    Copy the full SHA
    6c2f8ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    303bf4e View commit details
    Browse the repository at this point in the history
  3. Tests

    tmat committed May 2, 2023
    Configuration menu
    Copy the full SHA
    007a7b9 View commit details
    Browse the repository at this point in the history
  4. Fix merge

    tmat committed May 2, 2023
    Configuration menu
    Copy the full SHA
    5ed4c92 View commit details
    Browse the repository at this point in the history
  5. Merged PR 30865: Move StarredCompletions to AssemblyContextWrapper

    Move StarredCompletions to AssemblyContextWrapper
    ryzngard committed May 2, 2023
    Configuration menu
    Copy the full SHA
    f323044 View commit details
    Browse the repository at this point in the history
  6. Rename option

    tmat committed May 2, 2023
    Configuration menu
    Copy the full SHA
    96bef14 View commit details
    Browse the repository at this point in the history
  7. Rename

    tmat committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9177773 View commit details
    Browse the repository at this point in the history
  8. More PR feedback

    davidwengier committed May 2, 2023
    Configuration menu
    Copy the full SHA
    4530a8d View commit details
    Browse the repository at this point in the history
  9. Merged PR 30981: Update npmrc path

    The npmrc file was moved and the pipelines were not updated.
    ryzngard committed May 2, 2023
    Configuration menu
    Copy the full SHA
    7c4b6d1 View commit details
    Browse the repository at this point in the history
  10. Generalize extension loading

    tmat committed May 2, 2023
    Configuration menu
    Copy the full SHA
    d043301 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    26f3fb1 View commit details
    Browse the repository at this point in the history
  12. Fix formatting

    tmat committed May 2, 2023
    Configuration menu
    Copy the full SHA
    73439a6 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7a13438 View commit details
    Browse the repository at this point in the history
  14. Fixes

    tmat committed May 2, 2023
    Configuration menu
    Copy the full SHA
    318d85f View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Merged PR 30958: Include LanguageServer.Internal in MEF composition

    Convert telemetry service to a MEF component.
    
    Moves DevKit-specific tests from DevKit.UnitTests project to LanguageServer.UnitTests. In there we create MEF composition that includes DevKit in the same way the product does. This way our test assembly loading from the DevKit extension directory is the same as in product.
    tmat committed May 3, 2023
    Configuration menu
    Copy the full SHA
    5370182 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    915f3c3 View commit details
    Browse the repository at this point in the history
  3. Even more PR feedback

    davidwengier committed May 3, 2023
    Configuration menu
    Copy the full SHA
    8e1a8fc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ffff7a3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7f90556 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    937180b View commit details
    Browse the repository at this point in the history
  7. Merge remote-tracking branch 'mirror/features/lsp_tools_host' into de…

    …v/dibarbet/log_mef_failures
    dibarbet committed May 3, 2023
    Configuration menu
    Copy the full SHA
    2d64967 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5197617 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e1f6fd4 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Merged PR 30922: Defer initialization of the Razor components until t…

    …he extension tells us that its needed
    
    When opening a solution, we immediately go and discover all of the dynamic files, and were telling Razor about them. We don't actually need that information until the user starts using a Razor project, so this change introduces a command and LSP notification so that the extension is in charge of when to initialize Razor.
    
    Note: This won't compile until dotnet/razor#8639 is in, and Versions.props updated, but thought it would be good to get eyes on first.
    
    The extension side of this is https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/vscode-csharp-next/pullrequest/468200
    davidwengier committed May 4, 2023
    Configuration menu
    Copy the full SHA
    414793b View commit details
    Browse the repository at this point in the history
  2. Merged PR 30847: Add global state version to DiagnosticRefresher

    Add global state version to DiagnosticRefresher
    tmat committed May 4, 2023
    Configuration menu
    Copy the full SHA
    1bc7a43 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Configuration menu
    Copy the full SHA
    819d9f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    af00d35 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Merged PR 31158: FIX: IntelliCode Completion Provider Errors Causing …

    …Completion Failure
    
    - when getting completion provider fails, store failed status and don't retry to prevent persistent errors
    lacomc committed May 8, 2023
    Configuration menu
    Copy the full SHA
    f1f1b9f View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Configuration menu
    Copy the full SHA
    76bd2a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7436931 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    05773d0 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Merged PR 31185: Send notification to the client when the initial sol…

    …ution load completes
    
    Send notification to the client when the initial solution load completes
    
    Client side PR - https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/vscode-csharp-next/pullrequest/470863
    dibarbet committed May 10, 2023
    Configuration menu
    Copy the full SHA
    c1eae1f View commit details
    Browse the repository at this point in the history
  2. Merged PR 31194: Merge main

    arunchndr committed May 10, 2023
    Configuration menu
    Copy the full SHA
    801368f View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Configuration menu
    Copy the full SHA
    fb200c7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9211736 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f8cdd29 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Merged PR 31216: Upgrade the telemetry package and include more requi…

    …red runtime dependencies
    
    The telemetry package update includes needed fixes for csdevkit.
    
    The runtime dependencies were being silently swallowed as exceptions and could cause telemetry to not function appropriately.
    ryzngard committed May 16, 2023
    Configuration menu
    Copy the full SHA
    22a7389 View commit details
    Browse the repository at this point in the history
  2. Merged PR 31260: Merge main

    arunchndr committed May 16, 2023
    Configuration menu
    Copy the full SHA
    b7dabc7 View commit details
    Browse the repository at this point in the history
  3. Merged PR 31266: Only prepend "virtual-csharp' if not present

    Noticed while looking into diagnostics on Linux. This gets us closer to working, and is a small fix.
    ryzngard committed May 16, 2023
    Configuration menu
    Copy the full SHA
    9b37f50 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e7090cd View commit details
    Browse the repository at this point in the history
  5. Accept the service broker pipe name via LSP rather than a switch

    By requiring the pipe name to be passed as a switch, we were requiring
    that the Dev Kit server processes had to be running before we could
    launch our process. This isn't strictly necessary; by moving to an LSP
    notification we can connect to it asynchronously once the process is
    running.
    jasonmalinowski committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ea02897 View commit details
    Browse the repository at this point in the history
  6. Update StarredCompletionsAssemblyHelper to deal with missing service …

    …brokers
    
    Now that we can be in a situation where Dev Kit is installed but we
    don't have a service broker connection yet, we have to deal with that
    situation. This ensures we will not fail, but create it once we
    do have a service broker connection.
    jasonmalinowski committed May 16, 2023
    Configuration menu
    Copy the full SHA
    528530d View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. PR feedback

    davidwengier committed May 17, 2023
    Configuration menu
    Copy the full SHA
    43904bb View commit details
    Browse the repository at this point in the history
  2. Merged PR 31250: Accept the service broker pipe name via LSP rather t…

    …han a switch
    
    By requiring the pipe name to be passed as a switch, we were requiring that the Dev Kit server processes had to be running before we could launch our process. This isn't strictly necessary; by moving to an LSP notification we can connect to it asynchronously once the process is running.
    jasonmalinowski committed May 17, 2023
    Configuration menu
    Copy the full SHA
    6a179f5 View commit details
    Browse the repository at this point in the history
  3. Merged PR 31233: Don't use a FileTextLoader for dynamic files, which …

    …don't exist on disk
    
    This pairs with dotnet/razor#8691 and https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/vscode-csharp-next/pullrequest/471570 to solve the generated document sync issues in Razor.
    
    This isn't quite the solution we talked about (going back to the TextLoader to make an LSP call) but it gets us over the line until someone on the Roslyn team can advise how to get to that solution, if we think we still want to. Right now every time a change is made, we lose the TextLoader that the document was originally created with.
    
    We probably have a few options, but at the end of the day, for Razor generated files, the content in the workspace is correct already and we don't seem to need an LSP call to make things work.
    davidwengier committed May 17, 2023
    Configuration menu
    Copy the full SHA
    01d954f View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Merged PR 31301: Add session id so we can correlate with green

    The typescript side will get the same session id that green uses and pass to us, so we're not generating a random session.
    ryzngard committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1775fde View commit details
    Browse the repository at this point in the history
  2. Merged PR 31316: Fix DynamicFileInfo Filepath for Virtual Files

    Fix DynamicFileInfo Filepath for Virtual Files and remove workaround in ProtocolConversions.cs
    lonitra committed May 18, 2023
    Configuration menu
    Copy the full SHA
    ff35b0b View commit details
    Browse the repository at this point in the history
  3. Merged PR 30952: IntelliCode: Adding GetDescription Method to Starred…

    … Completion Provider
    
    **Changes**
    - adding a GetDescription method to starred completion provider that calls our inner GetDescription method
    - allowing Microsoft.CodeAnalysis.LanguageServer to accesss internals of Microsoft.CodeAnalysis.Features
       - this is required for us to override the GetDescription method in Microsoft.CodeAnalysis.LanguageServer
    
    **Note**
      - we can't move the StarredCompletionProvider into Microsoft.CodeAnalysis.Features because it relies on StarredCompletionAssemblyHelper, which would introduce a circular dependency between the two
       - we might be able to move both StarredCompletionAssemblyHelper and StarredCompletionProvider into Microsoft.CodeAnalysis.Features, but we would need to add a bunch of references to enable things like passing the service broker into the dll, which I'm not sure we want to do
    
    **Fixes**
    [Bug 1804646: Starred suggested completion description empty](https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1804646/?view=edit)
    lacomc committed May 18, 2023
    Configuration menu
    Copy the full SHA
    baf347f View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Configuration menu
    Copy the full SHA
    e19f650 View commit details
    Browse the repository at this point in the history
  2. Allow --extension instead of --extensions

    The command line parsing library expects a switch infront of each
    extension; you can't do --extensions A.dll B.dll. The name of the switch
    implies otherwise, so let's name this better.
    jasonmalinowski committed May 19, 2023
    Configuration menu
    Copy the full SHA
    e5084b7 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Merged PR 31421: Generate assets uses solution instead of project in …

    …green (part 2)
    
    Previously, generate assets would generate a tasks.json file that only builds the executable project you picked to debug. Now, it uses the solution if there is a solution available.
    
    Completes the fix for: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1800252/
    akhera99 committed May 22, 2023
    Configuration menu
    Copy the full SHA
    622e3b5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    af8ec2b View commit details
    Browse the repository at this point in the history
  3. Merged PR 31319: Allow --extension instead of --extensions

    The command line parsing library expects a switch in front of each extension; you can't do --extensions A.dll B.dll. The name of the switch implies otherwise, so let's name this better.
    jasonmalinowski committed May 22, 2023
    Configuration menu
    Copy the full SHA
    123a85c View commit details
    Browse the repository at this point in the history
  4. Merged PR 31391: Update GetDocumentIds URI logic

    When using source control git compare on VS Code, the LSP request context may contain the wrong document. The original/left side (git://filePath) is specified in the request parameters, but the request context  has the new/right side (file://filePath) document. This causes an ArgumentOutOfRange exception because the range requested for the git document might not match the number of lines in the file document.
    
    The root cause of this is the use of LocalPaths in the LSP workspace manager. The local paths, which strip out the schema information, don't differentiate between the git and file documents. This means the request context returns the file document when the git document is requested.
    
    This fix updates GetDocumentIds to only use local file path for documents of type file.
    
    Tested...
    - Problem source control scenario
    - New untitled file
    - Razor file
    
    Bug: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1798996/
    Becca McHenry committed May 22, 2023
    Configuration menu
    Copy the full SHA
    0490d22 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e1f0eba View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Merged PR 31465: FIX: Duplicate IntelliCode Initialization Causes Error

    - fix for [Bug 1822454: IntelliCode issue on JSON RPC attach - Unable to create the StarredCompletionProvider](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1822454)
      - we see an error when initialization is done twice because our brokered service can't be attached to twice
      - returning completionProvider inside lock in case method has already exited successfully
    lacomc committed May 23, 2023
    Configuration menu
    Copy the full SHA
    2244596 View commit details
    Browse the repository at this point in the history
  2. Merged PR 31357: Emulate soft-selection when filter text is empty

    In the gif below, I typed `"` in both cases, the difference is the first time filter text is empty, the second time "s" was typed. You can see the selected item was not committed in the first case. This behavior is consistent with VS
    
    The downside of this approach is there's no telling in UI whether the item would only be committed via TAB
    
    ![completion-selection.gif](https://dnceng.visualstudio.com/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/git/repositories/7b863b8d-8cc3-431d-b06b-7136cc32bbe6/pullRequests/31357/attachments/completion-selection.gif)
    genlu committed May 23, 2023
    Configuration menu
    Copy the full SHA
    73ed405 View commit details
    Browse the repository at this point in the history
  3. Merged PR 31464: Merge main

    arunchndr authored and tmat committed May 23, 2023
    Configuration menu
    Copy the full SHA
    df5a1ed View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Merged PR 31498: Fix commit character promotion

    Noticed this while working on other bugs.
    Fix commit character promotion, when promoting the most used commit char array on to the list, if it is not the default one, we need to adjust default items properly.
    genlu committed May 25, 2023
    Configuration menu
    Copy the full SHA
    e8216a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1bafe77 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Merged PR 31561: Call SetErrorMode on Windows

    NodeJS launched processes do not have a default error mode of 0 (the system default), so Windows Error Reporting won't work on the server process.
    ryzngard committed May 26, 2023
    Configuration menu
    Copy the full SHA
    8cc1f83 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7caf7f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fb93e47 View commit details
    Browse the repository at this point in the history
  4. Merged PR 31531: Add assembly loader that loads from C# DevKit shared…

    … dependencies directory
    
    Will allow us to avoid inserting extra assemblies with Roslyn DevKit that are already in the shared dependencies inserted by vs-green-server.
    
    Shared dependencies are loaded only withing the load context of the DevKit extension.
    
    Follow ups:
    - https://devdiv.visualstudio.com/DevDiv/_git/vscode-csharp-next/pullrequest/473154
    - https://dev.azure.com/dnceng/internal/_git/dotnet-roslyn/pullrequest/31422
    tmat committed May 26, 2023
    Configuration menu
    Copy the full SHA
    4e425f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Add EnC brokered service

    tmat committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    661d353 View commit details
    Browse the repository at this point in the history
  2. Fix

    tmat committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    f1fa7f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Configuration menu
    Copy the full SHA
    cc655a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Merge remote-tracking branch 'mirror/features/lsp_tools_host' into de…

    …v/dibarbet/merge_lsp_tools_host
    dibarbet committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    b5e75d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a9eb9e View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Configuration menu
    Copy the full SHA
    2e75cb0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9ce16ea View commit details
    Browse the repository at this point in the history
  3. Merge branch 'dev/dibarbet/merge_lsp_tools_host' of https://github.co…

    …m/dibarbet/roslyn into dev/dibarbet/merge_lsp_tools_host
    dibarbet committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    9401f98 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Configuration menu
    Copy the full SHA
    ba65199 View commit details
    Browse the repository at this point in the history