-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge internal fork of LSP tools back into Roslyn #68461
Merge internal fork of LSP tools back into Roslyn #68461
Commits on Mar 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e6c2906 - Browse repository at this point
Copy the full SHA e6c2906View commit details -
Configuration menu - View commit details
-
Copy full SHA for de79450 - Browse repository at this point
Copy the full SHA de79450View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4eb534f - Browse repository at this point
Copy the full SHA 4eb534fView commit details -
Merge branch 'features/lsp_tools_host' of https://dnceng.visualstudio…
….com/internal/_git/dotnet-roslyn into features/lsp_tools_host
Configuration menu - View commit details
-
Copy full SHA for aaaab06 - Browse repository at this point
Copy the full SHA aaaab06View commit details
Commits on Mar 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f12904e - Browse repository at this point
Copy the full SHA f12904eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23f6748 - Browse repository at this point
Copy the full SHA 23f6748View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06ec2b5 - Browse repository at this point
Copy the full SHA 06ec2b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16e6510 - Browse repository at this point
Copy the full SHA 16e6510View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e90ae2 - Browse repository at this point
Copy the full SHA 2e90ae2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f0f25d - Browse repository at this point
Copy the full SHA 4f0f25dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b2c6d8 - Browse repository at this point
Copy the full SHA 4b2c6d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9eb829b - Browse repository at this point
Copy the full SHA 9eb829bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d42cf2a - Browse repository at this point
Copy the full SHA d42cf2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a3a60e - Browse repository at this point
Copy the full SHA 8a3a60eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a969dc - Browse repository at this point
Copy the full SHA 8a969dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for bed5cb3 - Browse repository at this point
Copy the full SHA bed5cb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc06cb3 - Browse repository at this point
Copy the full SHA bc06cb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c58f3c - Browse repository at this point
Copy the full SHA 7c58f3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e0a509 - Browse repository at this point
Copy the full SHA 2e0a509View commit details -
Configuration menu - View commit details
-
Copy full SHA for f95bd61 - Browse repository at this point
Copy the full SHA f95bd61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1797707 - Browse repository at this point
Copy the full SHA 1797707View commit details -
Configuration menu - View commit details
-
Copy full SHA for 068999a - Browse repository at this point
Copy the full SHA 068999aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1bf39d - Browse repository at this point
Copy the full SHA b1bf39dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d38197e - Browse repository at this point
Copy the full SHA d38197eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a82ee63 - Browse repository at this point
Copy the full SHA a82ee63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8260eef - Browse repository at this point
Copy the full SHA 8260eefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4aa580b - Browse repository at this point
Copy the full SHA 4aa580bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29a6d67 - Browse repository at this point
Copy the full SHA 29a6d67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5556afc - Browse repository at this point
Copy the full SHA 5556afcView commit details
Commits on Mar 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e387f9c - Browse repository at this point
Copy the full SHA e387f9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2b1726 - Browse repository at this point
Copy the full SHA d2b1726View commit details -
Configuration menu - View commit details
-
Copy full SHA for f51176c - Browse repository at this point
Copy the full SHA f51176cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ae61f2 - Browse repository at this point
Copy the full SHA 1ae61f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c45987e - Browse repository at this point
Copy the full SHA c45987eView commit details
Commits on Mar 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1f42d67 - Browse repository at this point
Copy the full SHA 1f42d67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f9cec1 - Browse repository at this point
Copy the full SHA 6f9cec1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e714fac - Browse repository at this point
Copy the full SHA e714facView commit details -
Merge branch 'features/lsp_tools_host' of https://dnceng.visualstudio…
….com/internal/_git/dotnet-roslyn into features/lsp_tools_host
Configuration menu - View commit details
-
Copy full SHA for 5890599 - Browse repository at this point
Copy the full SHA 5890599View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b4b52c - Browse repository at this point
Copy the full SHA 9b4b52cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e01f9f7 - Browse repository at this point
Copy the full SHA e01f9f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8d34c8 - Browse repository at this point
Copy the full SHA d8d34c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1d3f8a - Browse repository at this point
Copy the full SHA b1d3f8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 81bfdd5 - Browse repository at this point
Copy the full SHA 81bfdd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70b69d1 - Browse repository at this point
Copy the full SHA 70b69d1View commit details -
Merged PR 30204: Have LanguageServerWorkspace implement new ILspWorkp…
…ace api Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1691478 This allows the workpsace in vscode to have changes push-through to the in-memory workspace, avoiding the need to fork the solution so often. Implements the work done in dotnet#67443.
Configuration menu - View commit details
-
Copy full SHA for 176d64d - Browse repository at this point
Copy the full SHA 176d64dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb93453 - Browse repository at this point
Copy the full SHA fb93453View commit details -
Merged PR 30293: [Part1] Implement simple debug configuration provider
Implement simple debug configuration provider. Client side change - https://devdiv.visualstudio.com/DevDiv/_git/vscode-csharp-next/pullrequest/461233
Configuration menu - View commit details
-
Copy full SHA for 5f282e3 - Browse repository at this point
Copy the full SHA 5f282e3View commit details
Commits on Mar 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b494f08 - Browse repository at this point
Copy the full SHA b494f08View commit details
Commits on Mar 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e0590a9 - Browse repository at this point
Copy the full SHA e0590a9View commit details -
Merged PR 30283: Add telemetry MEF import for VS Dev kit
Gets us publishing an npm package that will be added as a component to VS Dev kit. Left to do: * [ ] Import the new service in LSP * [ ] Make changes to VS Dev kit repo to add component * [ ] Add integration tests in VS Dev kit
Configuration menu - View commit details
-
Copy full SHA for 759fe7e - Browse repository at this point
Copy the full SHA 759fe7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92c1e22 - Browse repository at this point
Copy the full SHA 92c1e22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55ae57f - Browse repository at this point
Copy the full SHA 55ae57fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e0c54f - Browse repository at this point
Copy the full SHA 7e0c54fView commit details -
Merged PR 30344: Properly hook up file open/close handling
Properly hook up file open/close handling
Configuration menu - View commit details
-
Copy full SHA for 6458965 - Browse repository at this point
Copy the full SHA 6458965View commit details
Commits on Mar 31, 2023
-
Split apart the LanguageServerProjectSystem type
There are two responsbilities of this type, currently: 1. Actually creating the workspace and associated types. 2. Loading a solution, running design time builds, and populating the stuff created in 1. This splits those responsbilities into two types. The latter is kept in the same name, the former is renamed to the very pithy "LanguageServerWorkspaceFactory".
Configuration menu - View commit details
-
Copy full SHA for a15f420 - Browse repository at this point
Copy the full SHA a15f420View commit details -
Rename disposalToken to cancellationToken
This can also be cancelled if we were to cancel the work in the queue.
Configuration menu - View commit details
-
Copy full SHA for e88ae11 - Browse repository at this point
Copy the full SHA e88ae11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ba3e9e - Browse repository at this point
Copy the full SHA 5ba3e9eView commit details -
Remove the --solutionPath flag entirely
If you need to open a solution, now send the solution/open LSP notification.
Configuration menu - View commit details
-
Copy full SHA for 74cae5a - Browse repository at this point
Copy the full SHA 74cae5aView commit details -
Merged PR 30239: Remove the --solutionPath flag and add a LSP notific…
…ation instead Commit at a time will break this down a bit.
Configuration menu - View commit details
-
Copy full SHA for c6ee1b7 - Browse repository at this point
Copy the full SHA c6ee1b7View commit details
Commits on Apr 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 202da66 - Browse repository at this point
Copy the full SHA 202da66View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee4f153 - Browse repository at this point
Copy the full SHA ee4f153View commit details -
Merged PR 30325: Semantic snippets - turn feature off in C# extension
Disabling until we have a plan to remove the existing snippets. Tracking here: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1782057
Configuration menu - View commit details
-
Copy full SHA for 2feb670 - Browse repository at this point
Copy the full SHA 2feb670View commit details -
Merged PR 30375: Lack of ruleset service should not crash LanguageServer
Lack of ruleset service should not crash the language server
Configuration menu - View commit details
-
Copy full SHA for e220220 - Browse repository at this point
Copy the full SHA e220220View commit details
Commits on Apr 4, 2023
-
Initialize the Razor workspace listener when we find out there is at …
…least one Razor file
Configuration menu - View commit details
-
Copy full SHA for ee242ed - Browse repository at this point
Copy the full SHA ee242edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ef07a7 - Browse repository at this point
Copy the full SHA 6ef07a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5b5c3e - Browse repository at this point
Copy the full SHA e5b5c3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for be8f1d8 - Browse repository at this point
Copy the full SHA be8f1d8View commit details -
Merged PR 30345: Hook up fault telemetry initialize if it's available
Hook up fault telemetry initialize if it's available. This now fully works as long as the right binaries are manually added to the extension folder * [X] Tested with and without binaries being available * [X] Tested that nupkg is produced with right dependencies * [ ] Add as an ILogger implementation to report telemetry * [ ] NPM package is produced
Configuration menu - View commit details
-
Copy full SHA for 15b0d1d - Browse repository at this point
Copy the full SHA 15b0d1dView commit details
Commits on Apr 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2806d33 - Browse repository at this point
Copy the full SHA 2806d33View commit details -
Merged PR 30400: Add Logger.SetLogger to initializer
This sets it so the VSCode fault reporter also signs up to report telemetry that is sent through Logger.Log
Configuration menu - View commit details
-
Copy full SHA for 72fb9bb - Browse repository at this point
Copy the full SHA 72fb9bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25749a9 - Browse repository at this point
Copy the full SHA 25749a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4569382 - Browse repository at this point
Copy the full SHA 4569382View commit details -
Merge remote-tracking branch 'origin/features/lsp_tools_host' into de…
…v/dawengie/InitializeRazor
Configuration menu - View commit details
-
Copy full SHA for 2800607 - Browse repository at this point
Copy the full SHA 2800607View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cedd3e - Browse repository at this point
Copy the full SHA 2cedd3eView commit details
Commits on Apr 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 79fbf7a - Browse repository at this point
Copy the full SHA 79fbf7aView commit details -
Merged PR 30445: Fix compliance warnings by moving npmrc next to pack…
…age.json Fix compliance warnings by moving npmrc next to package.json
Configuration menu - View commit details
-
Copy full SHA for 2fc6096 - Browse repository at this point
Copy the full SHA 2fc6096View commit details -
Configuration menu - View commit details
-
Copy full SHA for 032a53e - Browse repository at this point
Copy the full SHA 032a53eView commit details
Commits on Apr 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eb6785a - Browse repository at this point
Copy the full SHA eb6785aView commit details -
Merged PR 30463: Remove service info from a couple of information lev…
…el logging Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1786584
Configuration menu - View commit details
-
Copy full SHA for 456b18a - Browse repository at this point
Copy the full SHA 456b18aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b7fe14 - Browse repository at this point
Copy the full SHA 5b7fe14View commit details -
Merged PR 30378: Initialize the Razor workspace listener when we find…
… out there is at least one Razor file Call into Razor when there is a razor file so Razor can produce the project.razor.vscode.json file to make things work. Not merging until Razor bits are in and packages available. Razor PR is dotnet/razor#8559 Part of https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1782085
Configuration menu - View commit details
-
Copy full SHA for b42dbf7 - Browse repository at this point
Copy the full SHA b42dbf7View commit details
Commits on Apr 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2491f4f - Browse repository at this point
Copy the full SHA 2491f4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e039a3a - Browse repository at this point
Copy the full SHA e039a3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 030a51e - Browse repository at this point
Copy the full SHA 030a51eView commit details
Commits on Apr 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a636e94 - Browse repository at this point
Copy the full SHA a636e94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67a8e41 - Browse repository at this point
Copy the full SHA 67a8e41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57ff1bf - Browse repository at this point
Copy the full SHA 57ff1bfView commit details
Commits on Apr 12, 2023
-
Merged PR 30539: Update Razor ExternalAccess.Roslyn version
Update Razor ExternalAccess.Roslyn version (contains Dustin's change dotnet/razor#8586)
Configuration menu - View commit details
-
Copy full SHA for fe10be7 - Browse repository at this point
Copy the full SHA fe10be7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b72925a - Browse repository at this point
Copy the full SHA b72925aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e51d34d - Browse repository at this point
Copy the full SHA e51d34dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a351222 - Browse repository at this point
Copy the full SHA a351222View commit details -
Merged PR 30538: Add a LSP command to handle complex completion edit
Add a LSP command to handle complex completion edit Address https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1777136 Corresponding PR in vscode extension: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/vscode-csharp-next/pullrequest/464748 TODO: Add test in LanguageServer.Tests
Configuration menu - View commit details
-
Copy full SHA for 6d433db - Browse repository at this point
Copy the full SHA 6d433dbView commit details
Commits on Apr 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cf6feda - Browse repository at this point
Copy the full SHA cf6fedaView commit details -
Implement an LSP-based file watcher
This delegates file watching to the LSP client via the LSP file watching protocol, if it's supported. This allows us to avoid having to deal with all the platform-specific challenges of file watching if we can.
Configuration menu - View commit details
-
Copy full SHA for 9975bff - Browse repository at this point
Copy the full SHA 9975bffView commit details -
Create our directory watches for references more lazily
This allows us to deal with a circularity in initialization of LSP, where we don't know if we can use LSP yet to watch for files until we've already tried to watch for files.
Configuration menu - View commit details
-
Copy full SHA for 8f190b6 - Browse repository at this point
Copy the full SHA 8f190b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52bb76d - Browse repository at this point
Copy the full SHA 52bb76dView commit details -
Work around an issue in Microsoft.VisualStudio.LanguageServer.Protocol
There is a DataMember attribute that has a "correct" spelling, but the LSP spec itself has a misspelling that we must match.
Configuration menu - View commit details
-
Copy full SHA for 0c35d2d - Browse repository at this point
Copy the full SHA 0c35d2dView commit details -
Merged PR 30498: Implement an LSP-based file watcher
This delegates file watching to the LSP client via the LSP file watching protocol, if it's supported. This allows us to avoid having to deal with all the platform-specific challenges of file watching if we can.
Configuration menu - View commit details
-
Copy full SHA for af03916 - Browse repository at this point
Copy the full SHA af03916View commit details -
Configuration menu - View commit details
-
Copy full SHA for d94a6a7 - Browse repository at this point
Copy the full SHA d94a6a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cfb4a5 - Browse repository at this point
Copy the full SHA 3cfb4a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e4745d - Browse repository at this point
Copy the full SHA 6e4745dView commit details -
Merged PR 30615: Add Scheme for Virtual Files
Roslyn assumes that the scheme portion of a URI is 'file:', however this is not the scheme for razor csharp files and the correct scheme is needed when looking up what razor documents are being tracked by Roslyn. This is a temporary workaround that checks to see if the passed in file path is one of razor's csharp files and adds the correct scheme before creating the URI.
Configuration menu - View commit details
-
Copy full SHA for ee23dcd - Browse repository at this point
Copy the full SHA ee23dcdView commit details
Commits on Apr 14, 2023
-
Merged PR 30494: IntelliCode: Loading Required Assemblies for Telemetry
- loading additional assemblies into IntelliCode Starred Suggestions ALC - assemblies are packaged with the starred suggestions npm package
Configuration menu - View commit details
-
Copy full SHA for 00d6310 - Browse repository at this point
Copy the full SHA 00d6310View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95c1bfa - Browse repository at this point
Copy the full SHA 95c1bfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5216e3e - Browse repository at this point
Copy the full SHA 5216e3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5be2dd7 - Browse repository at this point
Copy the full SHA 5be2dd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e755cbe - Browse repository at this point
Copy the full SHA e755cbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09f1b28 - Browse repository at this point
Copy the full SHA 09f1b28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20e22cd - Browse repository at this point
Copy the full SHA 20e22cdView commit details
Commits on Apr 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 359f2b1 - Browse repository at this point
Copy the full SHA 359f2b1View commit details
Commits on Apr 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f0b57dc - Browse repository at this point
Copy the full SHA f0b57dcView commit details -
Merged PR 30703: Workaround codelens resolving for old version
Still trying to get the client to stop sending the request, but in the meantime this should avoid flashing the missing command string microsoft/vscode-internalbacklog#3884 (comment) Since we technically only care about the version for calculating the references and the client always sends a correct request later on, it should be ~ok to return a command with an empty set of references. What it looks like with this change https://user-images.githubusercontent.com/5749229/232164240-2c9620db-3c4d-4ddd-8770-f8d951d9f48f.gif
Configuration menu - View commit details
-
Copy full SHA for f602951 - Browse repository at this point
Copy the full SHA f602951View commit details -
Merged PR 30711: Don't throw if the complex text edit display text is…
… shorter than the list range Don't throw if the complex text edit display text is shorter than the list range
Configuration menu - View commit details
-
Copy full SHA for ea83ea8 - Browse repository at this point
Copy the full SHA ea83ea8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d833d2 - Browse repository at this point
Copy the full SHA 7d833d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3f4d0b - Browse repository at this point
Copy the full SHA f3f4d0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8ad615 - Browse repository at this point
Copy the full SHA f8ad615View commit details -
Merge remote-tracking branch 'dnceng/features/lsp_tools_host' into de…
…v/shech/AddCodeStyleOptions
Configuration menu - View commit details
-
Copy full SHA for 0187c25 - Browse repository at this point
Copy the full SHA 0187c25View commit details -
Merged PR 30520: Add refresh support for inlay hints and code lens
Abstracted out the refresh work that Semantic Tokens does. Inlay hints need to be refreshed on any option change as well. Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1784802
Configuration menu - View commit details
-
Copy full SHA for 688b151 - Browse repository at this point
Copy the full SHA 688b151View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37d2c3e - Browse repository at this point
Copy the full SHA 37d2c3eView commit details
Commits on Apr 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9f0333e - Browse repository at this point
Copy the full SHA 9f0333eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 686b557 - Browse repository at this point
Copy the full SHA 686b557View commit details -
Merged PR 30699: Add code style options to configuration refresh list
Add code style options to the configuration refresh list. By convention, we don't want to have any global fallback for code-style options. However, vscode already has these configurations on its configuration page, it would be good to link these configuration to the server. Client-side change: https://devdiv.visualstudio.com/DevDiv/_git/vscode-csharp-next/pullrequest/463184
Configuration menu - View commit details
-
Copy full SHA for ce1e885 - Browse repository at this point
Copy the full SHA ce1e885View commit details -
Configuration menu - View commit details
-
Copy full SHA for b27410e - Browse repository at this point
Copy the full SHA b27410eView commit details -
Merge remote-tracking branch 'mirror/features/lsp_tools_host' into de…
…v/dibarbet/diagnostic_adjustments
Configuration menu - View commit details
-
Copy full SHA for daa121d - Browse repository at this point
Copy the full SHA daa121dView commit details -
Merged PR 30737: Adjust diagnostics display of hidden/unnecessary
Adjust diagnostic display to decrease visibility of hidden diagnostics Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1782197/ Now looks like: ![image.png](https://dnceng.visualstudio.com/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/git/repositories/7b863b8d-8cc3-431d-b06b-7136cc32bbe6/pullRequests/30737/attachments/image.png) Previously: ![image (2).png](https://dnceng.visualstudio.com/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/git/repositories/7b863b8d-8cc3-431d-b06b-7136cc32bbe6/pullRequests/30737/attachments/image%20%282%29.png)
Configuration menu - View commit details
-
Copy full SHA for 0ae93eb - Browse repository at this point
Copy the full SHA 0ae93ebView commit details -
Implement IExtensionManager in our LSP host
This is a trivial implementation that just reports the error back via the error log; we probably should do something fancier but this at least means we aren't swallowing problems.
Configuration menu - View commit details
-
Copy full SHA for 7bbc488 - Browse repository at this point
Copy the full SHA 7bbc488View commit details -
Remove error logging since exceptions are already logged
Now that we're logging all stuff from our IExtensionManager implementation, we don't need explicit logging. This allows for further cleanup then.
Configuration menu - View commit details
-
Copy full SHA for 97c05c8 - Browse repository at this point
Copy the full SHA 97c05c8View commit details -
Merged PR 30780: Implement IExtensionManager in our LSP host
This is a trivial implementation that just reports the error back via the error log; we probably should do something fancier but this at least means we aren't swallowing problems. Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1782895/
Configuration menu - View commit details
-
Copy full SHA for 0cf773b - Browse repository at this point
Copy the full SHA 0cf773bView commit details
Commits on Apr 19, 2023
-
Use simple hello world to prevent callback from throwing if green has…
…n't registered the service
Configuration menu - View commit details
-
Copy full SHA for fa9388e - Browse repository at this point
Copy the full SHA fa9388eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a03d0fd - Browse repository at this point
Copy the full SHA a03d0fdView commit details -
Merged PR 30784: Fix hello world exception if green has not registere…
…d service Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1784617
Configuration menu - View commit details
-
Copy full SHA for 567407b - Browse repository at this point
Copy the full SHA 567407bView commit details -
Merged PR 30486: Add option to enable telemetry
Following https://code.visualstudio.com/api/extension-guides/telemetry we should use VS Code settings for telemetry levels. https://devdiv.visualstudio.com/DevDiv/_git/vscode-csharp-next/pullrequest/464145?_a=files adds the corresponding change on the extension side
Configuration menu - View commit details
-
Copy full SHA for de200b1 - Browse repository at this point
Copy the full SHA de200b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c08f955 - Browse repository at this point
Copy the full SHA c08f955View commit details -
Configuration menu - View commit details
-
Copy full SHA for e72d577 - Browse repository at this point
Copy the full SHA e72d577View commit details -
Merged PR 30786: Watch Razor files
This makes sure that changes to razor files make it into the workspace.
Configuration menu - View commit details
-
Copy full SHA for 0390b9b - Browse repository at this point
Copy the full SHA 0390b9bView commit details
Commits on Apr 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f25ae52 - Browse repository at this point
Copy the full SHA f25ae52View commit details -
Configuration menu - View commit details
-
Copy full SHA for e817d06 - Browse repository at this point
Copy the full SHA e817d06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d84bab - Browse repository at this point
Copy the full SHA 8d84babView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c5a4e7 - Browse repository at this point
Copy the full SHA 3c5a4e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for af885f4 - Browse repository at this point
Copy the full SHA af885f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f47ff2 - Browse repository at this point
Copy the full SHA 7f47ff2View commit details
Commits on Apr 21, 2023
-
Merged PR 30836: IntelliCode: Changing Text from Green to C# Dev Kit
- updating text and renaming files
Configuration menu - View commit details
-
Copy full SHA for 5974adc - Browse repository at this point
Copy the full SHA 5974adcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98b1283 - Browse repository at this point
Copy the full SHA 98b1283View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ccef84 - Browse repository at this point
Copy the full SHA 2ccef84View commit details -
Configuration menu - View commit details
-
Copy full SHA for f541e67 - Browse repository at this point
Copy the full SHA f541e67View commit details -
Merged PR 30835: Adds DiagnosticRefreshQueue and IDiagnosticRefresher…
… that can be used to trigger pull diagnostic refresh ... from the server.
Configuration menu - View commit details
-
Copy full SHA for c12e7f8 - Browse repository at this point
Copy the full SHA c12e7f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2cf59a - Browse repository at this point
Copy the full SHA a2cf59aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 190e947 - Browse repository at this point
Copy the full SHA 190e947View commit details
Commits on Apr 24, 2023
-
Merged PR 30849: Switch to ServerGC in LanguageServer
Well, should we do it? ;)
Configuration menu - View commit details
-
Copy full SHA for efdbe7b - Browse repository at this point
Copy the full SHA efdbe7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec78083 - Browse repository at this point
Copy the full SHA ec78083View commit details -
Merged PR 30834: Add component wrapper for telemetry
This changes telemetry to use a component wrapper, similar to intellicode. This ensures we don't need MEF to call to the component if it's available, and loads it into it's own ALC. This also removes any dependencies the internal component has on Roslyn code, which allows it to exist in an isolated way.
Configuration menu - View commit details
-
Copy full SHA for 5cf3a31 - Browse repository at this point
Copy the full SHA 5cf3a31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53a9de1 - Browse repository at this point
Copy the full SHA 53a9de1View commit details
Commits on Apr 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7a4b41d - Browse repository at this point
Copy the full SHA 7a4b41dView commit details -
Merged PR 30841: Use VS host workspace services
Use VS host workspace services
Configuration menu - View commit details
-
Copy full SHA for 99ed3cf - Browse repository at this point
Copy the full SHA 99ed3cfView commit details -
Merged PR 30844: Reduce payload size for completion request
first part of https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1804538 The benchmark result (for 10k items) Before: ``` BenchmarkDotNet=v0.13.0, OS=Windows 10.0.22621 Intel Core i9-10885H CPU 2.40GHz, 1 CPU, 16 logical and 8 physical cores [Host] : .NET Framework 4.8 (4.8.9139.0), X86 LegacyJIT Job-FTOBUC : .NET Framework 4.8 (4.8.9139.0), X86 LegacyJIT InvocationCount=1 UnrollFactor=1 | Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |-------------- |---------:|--------:|--------:|----------:|----------:|------:|----------:| | Serialization | 148.4 ms | 1.94 ms | 1.81 ms | 2000.0000 | 2000.0000 | - | 24 MB | ``` after ``` BenchmarkDotNet=v0.13.0, OS=Windows 10.0.22621 Intel Core i9-10885H CPU 2.40GHz, 1 CPU, 16 logical and 8 physical cores [Host] : .NET Framework 4.8 (4.8.9139.0), X86 LegacyJIT Job-FTOBUC : .NET Framework 4.8 (4.8.9139.0), X86 LegacyJIT InvocationCount=1 UnrollFactor=1 | Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |-------------- |---------:|---------:|---------:|----------:|----------:|------:|----------:| | Serialization | 56.02 ms | 1.699 ms | 4.873 ms | 1000.0000 | 1000.0000 | - | 10 MB | ```
Configuration menu - View commit details
-
Copy full SHA for 7dff3db - Browse repository at this point
Copy the full SHA 7dff3dbView commit details
Commits on Apr 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fc1582a - Browse repository at this point
Copy the full SHA fc1582aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c21c57 - Browse repository at this point
Copy the full SHA 0c21c57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a8d498 - Browse repository at this point
Copy the full SHA 6a8d498View commit details -
Revert "Change the ApplyChangesOperation"
This reverts commit 6a8d498.
Configuration menu - View commit details
-
Copy full SHA for d98cb48 - Browse repository at this point
Copy the full SHA d98cb48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94dc877 - Browse repository at this point
Copy the full SHA 94dc877View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93f8a8c - Browse repository at this point
Copy the full SHA 93f8a8cView commit details -
Merged PR 30906: Check if ISymbolRenamedCodeActionOperationFactoryWor…
…kspaceService is missing when rename for naming violation Fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1806593 LSP server don't need to do extra works in ISymbolRenamedCodeActionOperationFactoryWorkspaceService. So we should check the if it's null or not
Configuration menu - View commit details
-
Copy full SHA for 245ebb5 - Browse repository at this point
Copy the full SHA 245ebb5View commit details
Commits on Apr 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for df3a6ab - Browse repository at this point
Copy the full SHA df3a6abView commit details -
Defer initialization of the Razor components until the extension tell…
…s us that its needed
Configuration menu - View commit details
-
Copy full SHA for 5565de4 - Browse repository at this point
Copy the full SHA 5565de4View commit details
Commits on Apr 28, 2023
-
Merged PR 30816: Add publish for npm package
Add publish for npm package to dotnet-tools-internal
Configuration menu - View commit details
-
Copy full SHA for fc647e3 - Browse repository at this point
Copy the full SHA fc647e3View commit details -
Merged PR 30920: Add support to ImportCompletion
This is disabled by default, and no change to the filtering logic yet. Address https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1798338 Looks like this: ![image.png](https://dnceng.visualstudio.com/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/git/repositories/7b863b8d-8cc3-431d-b06b-7136cc32bbe6/pullRequests/30920/attachments/image.png)
Configuration menu - View commit details
-
Copy full SHA for 31f979c - Browse repository at this point
Copy the full SHA 31f979cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c624b63 - Browse repository at this point
Copy the full SHA c624b63View commit details
Commits on Apr 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9415d4a - Browse repository at this point
Copy the full SHA 9415d4aView commit details
Commits on Apr 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c548c5c - Browse repository at this point
Copy the full SHA c548c5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b73891e - Browse repository at this point
Copy the full SHA b73891eView commit details
Commits on May 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 005e13b - Browse repository at this point
Copy the full SHA 005e13bView commit details -
Make sure to re-process any stale dynamic file notifications, if we g…
…et a race condition
Configuration menu - View commit details
-
Copy full SHA for bf41f7b - Browse repository at this point
Copy the full SHA bf41f7bView commit details -
Merged PR 30955: Fix regression in complex edit completion
Fix ComplexEdit completion
Configuration menu - View commit details
-
Copy full SHA for c6186a2 - Browse repository at this point
Copy the full SHA c6186a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2240e0 - Browse repository at this point
Copy the full SHA f2240e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e7c9c0 - Browse repository at this point
Copy the full SHA 7e7c9c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b7a623 - Browse repository at this point
Copy the full SHA 8b7a623View commit details -
Merge branch 'features/lsp_tools_host' into dev/andrha/package_runtim…
…e_dependencies_npm
Configuration menu - View commit details
-
Copy full SHA for ce0e855 - Browse repository at this point
Copy the full SHA ce0e855View commit details
Commits on May 2, 2023
-
Merged PR 30977: Update npm package
Best reviewed commit by commit. * Rename the package * Update the package by adding runtime dependencies in the pack
Configuration menu - View commit details
-
Copy full SHA for 6c2f8ad - Browse repository at this point
Copy the full SHA 6c2f8adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 303bf4e - Browse repository at this point
Copy the full SHA 303bf4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 007a7b9 - Browse repository at this point
Copy the full SHA 007a7b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ed4c92 - Browse repository at this point
Copy the full SHA 5ed4c92View commit details -
Merged PR 30865: Move StarredCompletions to AssemblyContextWrapper
Move StarredCompletions to AssemblyContextWrapper
Configuration menu - View commit details
-
Copy full SHA for f323044 - Browse repository at this point
Copy the full SHA f323044View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96bef14 - Browse repository at this point
Copy the full SHA 96bef14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9177773 - Browse repository at this point
Copy the full SHA 9177773View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4530a8d - Browse repository at this point
Copy the full SHA 4530a8dView commit details -
Merged PR 30981: Update npmrc path
The npmrc file was moved and the pipelines were not updated.
Configuration menu - View commit details
-
Copy full SHA for 7c4b6d1 - Browse repository at this point
Copy the full SHA 7c4b6d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d043301 - Browse repository at this point
Copy the full SHA d043301View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26f3fb1 - Browse repository at this point
Copy the full SHA 26f3fb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73439a6 - Browse repository at this point
Copy the full SHA 73439a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a13438 - Browse repository at this point
Copy the full SHA 7a13438View commit details -
Configuration menu - View commit details
-
Copy full SHA for 318d85f - Browse repository at this point
Copy the full SHA 318d85fView commit details
Commits on May 3, 2023
-
Merged PR 30958: Include LanguageServer.Internal in MEF composition
Convert telemetry service to a MEF component. Moves DevKit-specific tests from DevKit.UnitTests project to LanguageServer.UnitTests. In there we create MEF composition that includes DevKit in the same way the product does. This way our test assembly loading from the DevKit extension directory is the same as in product.
Configuration menu - View commit details
-
Copy full SHA for 5370182 - Browse repository at this point
Copy the full SHA 5370182View commit details -
Configuration menu - View commit details
-
Copy full SHA for 915f3c3 - Browse repository at this point
Copy the full SHA 915f3c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e1a8fc - Browse repository at this point
Copy the full SHA 8e1a8fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ffff7a3 - Browse repository at this point
Copy the full SHA ffff7a3View commit details -
Merge remote-tracking branch 'origin/features/lsp_tools_host' into De…
…ferRazorInitialization
Configuration menu - View commit details
-
Copy full SHA for 7f90556 - Browse repository at this point
Copy the full SHA 7f90556View commit details -
Configuration menu - View commit details
-
Copy full SHA for 937180b - Browse repository at this point
Copy the full SHA 937180bView commit details -
Merge remote-tracking branch 'mirror/features/lsp_tools_host' into de…
…v/dibarbet/log_mef_failures
Configuration menu - View commit details
-
Copy full SHA for 2d64967 - Browse repository at this point
Copy the full SHA 2d64967View commit details -
Merged PR 31034: Improve logging of mef composition failures
Improve logging of mef composition failures Now looks like ![image.png](https://dnceng.visualstudio.com/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/git/repositories/7b863b8d-8cc3-431d-b06b-7136cc32bbe6/pullRequests/31034/attachments/image.png)
Configuration menu - View commit details
-
Copy full SHA for 5197617 - Browse repository at this point
Copy the full SHA 5197617View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1f6fd4 - Browse repository at this point
Copy the full SHA e1f6fd4View commit details
Commits on May 4, 2023
-
Merged PR 30922: Defer initialization of the Razor components until t…
…he extension tells us that its needed When opening a solution, we immediately go and discover all of the dynamic files, and were telling Razor about them. We don't actually need that information until the user starts using a Razor project, so this change introduces a command and LSP notification so that the extension is in charge of when to initialize Razor. Note: This won't compile until dotnet/razor#8639 is in, and Versions.props updated, but thought it would be good to get eyes on first. The extension side of this is https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/vscode-csharp-next/pullrequest/468200
Configuration menu - View commit details
-
Copy full SHA for 414793b - Browse repository at this point
Copy the full SHA 414793bView commit details -
Merged PR 30847: Add global state version to DiagnosticRefresher
Add global state version to DiagnosticRefresher
Configuration menu - View commit details
-
Copy full SHA for 1bc7a43 - Browse repository at this point
Copy the full SHA 1bc7a43View commit details
Commits on May 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 819d9f0 - Browse repository at this point
Copy the full SHA 819d9f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for af00d35 - Browse repository at this point
Copy the full SHA af00d35View commit details
Commits on May 8, 2023
-
Merged PR 31158: FIX: IntelliCode Completion Provider Errors Causing …
…Completion Failure - when getting completion provider fails, store failed status and don't retry to prevent persistent errors
Configuration menu - View commit details
-
Copy full SHA for f1f1b9f - Browse repository at this point
Copy the full SHA f1f1b9fView commit details
Commits on May 9, 2023
-
Merged PR 31184: Call RegisterForReliabilityEvent on sessions
Required for watson crash data to be sent. Resolves https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1810736?src=WorkItemMention&src-action=artifact_link
Configuration menu - View commit details
-
Copy full SHA for 76bd2a7 - Browse repository at this point
Copy the full SHA 76bd2a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7436931 - Browse repository at this point
Copy the full SHA 7436931View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05773d0 - Browse repository at this point
Copy the full SHA 05773d0View commit details
Commits on May 10, 2023
-
Merged PR 31185: Send notification to the client when the initial sol…
…ution load completes Send notification to the client when the initial solution load completes Client side PR - https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/vscode-csharp-next/pullrequest/470863
Configuration menu - View commit details
-
Copy full SHA for c1eae1f - Browse repository at this point
Copy the full SHA c1eae1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 801368f - Browse repository at this point
Copy the full SHA 801368fView commit details
Commits on May 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fb200c7 - Browse repository at this point
Copy the full SHA fb200c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9211736 - Browse repository at this point
Copy the full SHA 9211736View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8cdd29 - Browse repository at this point
Copy the full SHA f8cdd29View commit details
Commits on May 16, 2023
-
Merged PR 31216: Upgrade the telemetry package and include more requi…
…red runtime dependencies The telemetry package update includes needed fixes for csdevkit. The runtime dependencies were being silently swallowed as exceptions and could cause telemetry to not function appropriately.
Configuration menu - View commit details
-
Copy full SHA for 22a7389 - Browse repository at this point
Copy the full SHA 22a7389View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7dabc7 - Browse repository at this point
Copy the full SHA b7dabc7View commit details -
Merged PR 31266: Only prepend "virtual-csharp' if not present
Noticed while looking into diagnostics on Linux. This gets us closer to working, and is a small fix.
Configuration menu - View commit details
-
Copy full SHA for 9b37f50 - Browse repository at this point
Copy the full SHA 9b37f50View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7090cd - Browse repository at this point
Copy the full SHA e7090cdView commit details -
Accept the service broker pipe name via LSP rather than a switch
By requiring the pipe name to be passed as a switch, we were requiring that the Dev Kit server processes had to be running before we could launch our process. This isn't strictly necessary; by moving to an LSP notification we can connect to it asynchronously once the process is running.
Configuration menu - View commit details
-
Copy full SHA for ea02897 - Browse repository at this point
Copy the full SHA ea02897View commit details -
Update StarredCompletionsAssemblyHelper to deal with missing service …
…brokers Now that we can be in a situation where Dev Kit is installed but we don't have a service broker connection yet, we have to deal with that situation. This ensures we will not fail, but create it once we do have a service broker connection.
Configuration menu - View commit details
-
Copy full SHA for 528530d - Browse repository at this point
Copy the full SHA 528530dView commit details
Commits on May 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 43904bb - Browse repository at this point
Copy the full SHA 43904bbView commit details -
Merged PR 31250: Accept the service broker pipe name via LSP rather t…
…han a switch By requiring the pipe name to be passed as a switch, we were requiring that the Dev Kit server processes had to be running before we could launch our process. This isn't strictly necessary; by moving to an LSP notification we can connect to it asynchronously once the process is running.
Configuration menu - View commit details
-
Copy full SHA for 6a179f5 - Browse repository at this point
Copy the full SHA 6a179f5View commit details -
Merged PR 31233: Don't use a FileTextLoader for dynamic files, which …
…don't exist on disk This pairs with dotnet/razor#8691 and https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/vscode-csharp-next/pullrequest/471570 to solve the generated document sync issues in Razor. This isn't quite the solution we talked about (going back to the TextLoader to make an LSP call) but it gets us over the line until someone on the Roslyn team can advise how to get to that solution, if we think we still want to. Right now every time a change is made, we lose the TextLoader that the document was originally created with. We probably have a few options, but at the end of the day, for Razor generated files, the content in the workspace is correct already and we don't seem to need an LSP call to make things work.
Configuration menu - View commit details
-
Copy full SHA for 01d954f - Browse repository at this point
Copy the full SHA 01d954fView commit details
Commits on May 18, 2023
-
Merged PR 31301: Add session id so we can correlate with green
The typescript side will get the same session id that green uses and pass to us, so we're not generating a random session.
Configuration menu - View commit details
-
Copy full SHA for 1775fde - Browse repository at this point
Copy the full SHA 1775fdeView commit details -
Merged PR 31316: Fix DynamicFileInfo Filepath for Virtual Files
Fix DynamicFileInfo Filepath for Virtual Files and remove workaround in ProtocolConversions.cs
Configuration menu - View commit details
-
Copy full SHA for ff35b0b - Browse repository at this point
Copy the full SHA ff35b0bView commit details -
Merged PR 30952: IntelliCode: Adding GetDescription Method to Starred…
… Completion Provider **Changes** - adding a GetDescription method to starred completion provider that calls our inner GetDescription method - allowing Microsoft.CodeAnalysis.LanguageServer to accesss internals of Microsoft.CodeAnalysis.Features - this is required for us to override the GetDescription method in Microsoft.CodeAnalysis.LanguageServer **Note** - we can't move the StarredCompletionProvider into Microsoft.CodeAnalysis.Features because it relies on StarredCompletionAssemblyHelper, which would introduce a circular dependency between the two - we might be able to move both StarredCompletionAssemblyHelper and StarredCompletionProvider into Microsoft.CodeAnalysis.Features, but we would need to add a bunch of references to enable things like passing the service broker into the dll, which I'm not sure we want to do **Fixes** [Bug 1804646: Starred suggested completion description empty](https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1804646/?view=edit)
Configuration menu - View commit details
-
Copy full SHA for baf347f - Browse repository at this point
Copy the full SHA baf347fView commit details
Commits on May 19, 2023
-
Merged PR 31353: Create Method for Extracting URIString from URI
Configuration menu - View commit details
-
Copy full SHA for e19f650 - Browse repository at this point
Copy the full SHA e19f650View commit details -
Allow --extension instead of --extensions
The command line parsing library expects a switch infront of each extension; you can't do --extensions A.dll B.dll. The name of the switch implies otherwise, so let's name this better.
Configuration menu - View commit details
-
Copy full SHA for e5084b7 - Browse repository at this point
Copy the full SHA e5084b7View commit details
Commits on May 22, 2023
-
Merged PR 31421: Generate assets uses solution instead of project in …
…green (part 2) Previously, generate assets would generate a tasks.json file that only builds the executable project you picked to debug. Now, it uses the solution if there is a solution available. Completes the fix for: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1800252/
Configuration menu - View commit details
-
Copy full SHA for 622e3b5 - Browse repository at this point
Copy the full SHA 622e3b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for af8ec2b - Browse repository at this point
Copy the full SHA af8ec2bView commit details -
Merged PR 31319: Allow --extension instead of --extensions
The command line parsing library expects a switch in front of each extension; you can't do --extensions A.dll B.dll. The name of the switch implies otherwise, so let's name this better.
Configuration menu - View commit details
-
Copy full SHA for 123a85c - Browse repository at this point
Copy the full SHA 123a85cView commit details -
Merged PR 31391: Update GetDocumentIds URI logic
When using source control git compare on VS Code, the LSP request context may contain the wrong document. The original/left side (git://filePath) is specified in the request parameters, but the request context has the new/right side (file://filePath) document. This causes an ArgumentOutOfRange exception because the range requested for the git document might not match the number of lines in the file document. The root cause of this is the use of LocalPaths in the LSP workspace manager. The local paths, which strip out the schema information, don't differentiate between the git and file documents. This means the request context returns the file document when the git document is requested. This fix updates GetDocumentIds to only use local file path for documents of type file. Tested... - Problem source control scenario - New untitled file - Razor file Bug: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1798996/
Becca McHenry committedMay 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 0490d22 - Browse repository at this point
Copy the full SHA 0490d22View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1f0eba - Browse repository at this point
Copy the full SHA e1f0ebaView commit details
Commits on May 23, 2023
-
Merged PR 31465: FIX: Duplicate IntelliCode Initialization Causes Error
- fix for [Bug 1822454: IntelliCode issue on JSON RPC attach - Unable to create the StarredCompletionProvider](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1822454) - we see an error when initialization is done twice because our brokered service can't be attached to twice - returning completionProvider inside lock in case method has already exited successfully
Configuration menu - View commit details
-
Copy full SHA for 2244596 - Browse repository at this point
Copy the full SHA 2244596View commit details -
Merged PR 31357: Emulate soft-selection when filter text is empty
In the gif below, I typed `"` in both cases, the difference is the first time filter text is empty, the second time "s" was typed. You can see the selected item was not committed in the first case. This behavior is consistent with VS The downside of this approach is there's no telling in UI whether the item would only be committed via TAB ![completion-selection.gif](https://dnceng.visualstudio.com/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/git/repositories/7b863b8d-8cc3-431d-b06b-7136cc32bbe6/pullRequests/31357/attachments/completion-selection.gif)
Configuration menu - View commit details
-
Copy full SHA for 73ed405 - Browse repository at this point
Copy the full SHA 73ed405View commit details -
Configuration menu - View commit details
-
Copy full SHA for df5a1ed - Browse repository at this point
Copy the full SHA df5a1edView commit details
Commits on May 25, 2023
-
Merged PR 31498: Fix commit character promotion
Noticed this while working on other bugs. Fix commit character promotion, when promoting the most used commit char array on to the list, if it is not the default one, we need to adjust default items properly.
Configuration menu - View commit details
-
Copy full SHA for e8216a9 - Browse repository at this point
Copy the full SHA e8216a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bafe77 - Browse repository at this point
Copy the full SHA 1bafe77View commit details
Commits on May 26, 2023
-
Merged PR 31561: Call SetErrorMode on Windows
NodeJS launched processes do not have a default error mode of 0 (the system default), so Windows Error Reporting won't work on the server process.
Configuration menu - View commit details
-
Copy full SHA for 8cc1f83 - Browse repository at this point
Copy the full SHA 8cc1f83View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7caf7f - Browse repository at this point
Copy the full SHA b7caf7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb93e47 - Browse repository at this point
Copy the full SHA fb93e47View commit details -
Merged PR 31531: Add assembly loader that loads from C# DevKit shared…
… dependencies directory Will allow us to avoid inserting extra assemblies with Roslyn DevKit that are already in the shared dependencies inserted by vs-green-server. Shared dependencies are loaded only withing the load context of the DevKit extension. Follow ups: - https://devdiv.visualstudio.com/DevDiv/_git/vscode-csharp-next/pullrequest/473154 - https://dev.azure.com/dnceng/internal/_git/dotnet-roslyn/pullrequest/31422
Configuration menu - View commit details
-
Copy full SHA for 4e425f8 - Browse repository at this point
Copy the full SHA 4e425f8View commit details
Commits on Jun 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 661d353 - Browse repository at this point
Copy the full SHA 661d353View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1fa7f8 - Browse repository at this point
Copy the full SHA f1fa7f8View commit details
Commits on Jun 2, 2023
-
Merged PR 30819: EnC brokered service
Adds Hot Reload brokered services to C# DevKit (red in the diagram) ![image (2).png](https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/git/repositories/7b863b8d-8cc3-431d-b06b-7136cc32bbe6/pullRequests/30819/attachments/image%20%282%29.png)
Configuration menu - View commit details
-
Copy full SHA for cc655a9 - Browse repository at this point
Copy the full SHA cc655a9View commit details
Commits on Jun 6, 2023
-
Merge remote-tracking branch 'mirror/features/lsp_tools_host' into de…
…v/dibarbet/merge_lsp_tools_host
Configuration menu - View commit details
-
Copy full SHA for b5e75d9 - Browse repository at this point
Copy the full SHA b5e75d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a9eb9e - Browse repository at this point
Copy the full SHA 6a9eb9eView commit details
Commits on Jun 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2e75cb0 - Browse repository at this point
Copy the full SHA 2e75cb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce16ea - Browse repository at this point
Copy the full SHA 9ce16eaView commit details -
Merge branch 'dev/dibarbet/merge_lsp_tools_host' of https://github.co…
…m/dibarbet/roslyn into dev/dibarbet/merge_lsp_tools_host
Configuration menu - View commit details
-
Copy full SHA for 9401f98 - Browse repository at this point
Copy the full SHA 9401f98View commit details
Commits on Jun 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ba65199 - Browse repository at this point
Copy the full SHA ba65199View commit details