Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main into features/RefReadonly #68486

Merged
merged 503 commits into from
Jun 8, 2023
Merged

Merge main into features/RefReadonly #68486

merged 503 commits into from
Jun 8, 2023

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Jun 8, 2023 •
edited
Loading

No conflicts.

Cosifne and others added 30 commits May 10, 2023 17:29
@Cosifne
Merge pull request dotnet#68160 from Cosifne/dev/shech/FilterProjectO…
63019e9 
…ptionsChange

Add RequiresNonDocumentChangesTag to ProjectOptionsChangeAction
@tmat
Limit amount of tokens used to calculate LCS distance (dotnet#68151)
b404fbe
@CyrusNajmabadi
Fix all support
54d2485
@CyrusNajmabadi
Break out to its own file
f000809
@CyrusNajmabadi
Use a singleton sentinel for empty type-parameters for non-generic na…
236149d 
…med-types and methods. (dotnet#68131)

* Use a singleton for empty type-parameters for named types

* move type parameters down

* Optimize methods as well

* Always create indirection

* Move type

* Apply suggestions from code review

* speeling

* nrt

* Inline

* Simplify

* Change to abstract override
@CyrusNajmabadi
Add fix all tests
81ff0bb
@CyrusNajmabadi
Docs
f67e030
@dotnet-bot
Merge pull request dotnet#68149 from dotnet/merges/release/dev17.4-to…
870c38d 
…-release/dev17.5-vs-deps

Merge release/dev17.4 to release/dev17.5-vs-deps
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/main' into usePrimaryConstructor
7d27257
@CyrusNajmabadi
Fix mapping
7fa3220
@CyrusNajmabadi
Add optino
a3c6b14
@CyrusNajmabadi
Fixup tests
8064c4a
@sbergen @jjonescz
Record added node output states as new (dotnet#66725)
02cf37e 
* Record added node output states as new

The `(EntryState.Modified, EntryState.Added) => IncrementalStepRunReason.Modified` state mapping was recently added in dotnet#61308, but doesn't look correct to me. Since this value is used as the output status, and the outputs are new, I believe the correct state should be `IncrementalStepRunReason.New` instead.

* Update tests that were added since I originally implemented the change

* Update documentation for IncrementalStepRunReason

* Update VB tests also

* Add note about breaking changes with IncrementalStepRunReason

---------

Co-authored-by: Jan Jones <[email protected]>
@jjonescz
Display standalone parameter names by default (dotnet#67857)
1497e87 
* Add a test

* Display standalone parameter names by default

* Document breaking change

* Update tests
@CyrusNajmabadi
Update tests
6028d51
@sharwell
Updates for clarity and consistency
35dcfa7
@Cosifne
Update compiler version
0ad71a3
@Cosifne
Check for 17.6 for LOC
740eaa4
@sharwell
Fix detection of nested symbols in Document Outline
03cf0a1 
Fixes dotnet#66012
Fixes dotnet#66473
@sharwell
Merge pull request dotnet#68068 from sharwell/navigable-document
bafaa31 
Avoid rooting document instances in NavigateToSearchResult
@mavasani
Merge pull request dotnet#67671 from mavasani/Issue67592
c253f13 
Deprecate CompilationWithAnalyzers.IsDiagnosticAnalyzerSuppressed public API
@sharwell
Merge pull request dotnet#68114 from sharwell/short-circuit-2
d0a38b1 
Avoid waiting on the thread pool when there is no work to do
@sharwell
Avoid waiting on the thread pool when there is no work to do
1bd2e9f
@sharwell
Merge pull request dotnet#68094 from sharwell/fix-toolbar
c8277ce 
Use a proper tool bar in Document Outline
@sharwell
Merge pull request dotnet#68107 from sharwell/nested-symbol
ce19d97 
Fix detection of nested symbols in Document Outline
@sharwell
Enable document outline by default
0f54a8e 
Closes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1715901
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/main' into usePrimaryConstructor
dc689df
@sharwell
Implement a feature flag to disable Document Outline if necessary
789f18b 
Closes dotnet#68192
@CyrusNajmabadi
Fix equivalence key
000b6be
@CyrusNajmabadi
Add missing docs
f28b215
jaredpar and others added 12 commits June 7, 2023 11:37
@jaredpar
Disable MacOS on PRs (dotnet#68470)
4ab792a 
Our PRs already run tests on Unix which is a sufficient proxy for Mac
runs. Can leave Mac as CI only and slim down our PR runs
@CyrusNajmabadi
Skip test that is causing issues in CI (dotnet#68468)
78cc604
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/main' into useLocalFunctionVar
cf71b0c
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/main' into norecurse
924092e
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/main' into spellCheckingSmall
2c6de13
@CyrusNajmabadi
Merge pull request dotnet#68448 from CyrusNajmabadi/useLocalFunctionVar
397a7c6 
Fix 'use local function' with implicitly typed lambdas
@AlekseyTs
Only record class can have a copy constructor. (dotnet#68442)
61853f2 
Fixes dotnet#68345.
@AlekseyTs
makeNotNullMembersMaybeNull - skip primary constructor capture fiel…
724a31f 
…ds (dotnet#68441)

Fixes dotnet#68384.
@CyrusNajmabadi
Merge pull request dotnet#68460 from CyrusNajmabadi/norecurse
92d59e5 
Move off of recursion when determining pp-directive information for a file.
@CyrusNajmabadi
Merge pull request dotnet#68426 from CyrusNajmabadi/spellCheckingSmall
4e1b952 
Switch to new lower-overhead spell checking protocol
@jasonmalinowski
Merge pull request dotnet#68452 from jasonmalinowski/symbol-display-s…
91afe09 
…ervice-cleanups-and-perf-improvements

Ensure we only ask for a symbol's documentation comment once
@jjonescz
Merge branch 'main' into RefReadonly-main
980e9cd
@jjonescz jjonescz added the New Feature - Ref Readonly Parameters `ref readonly` parameters label Jun 8, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 8, 2023
@jjonescz jjonescz marked this pull request as ready for review June 8, 2023 08:10
@jjonescz jjonescz requested review from 333fred, dibarbet and a team as code owners June 8, 2023 08:10
@jjonescz jjonescz enabled auto-merge June 8, 2023 08:10
@jjonescz
Copy link
Member Author

jjonescz commented Jun 8, 2023 •
edited
Loading

@dotnet/roslyn-compiler @jcouv @AlekseyTs need a sign-off on a clean merge

@jjonescz jjonescz merged commit 8ca7c0a into dotnet:features/RefReadonly Jun 8, 2023
@jjonescz jjonescz deleted the RefReadonly-main branch June 8, 2023 14:23
@allisonchou allisonchou mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@333fred 333fred Awaiting requested review from 333fred 333fred is a code owner

@dibarbet dibarbet Awaiting requested review from dibarbet dibarbet is a code owner

Assignees
No one assigned
Labels
Area-Infrastructure New Feature - Ref Readonly Parameters `ref readonly` parameters untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.