Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snap 17.7p3 #68821

Merged
merged 823 commits into from
Jun 28, 2023
Merged

Snap 17.7p3 #68821

merged 823 commits into from
Jun 28, 2023

Conversation

RikkiGibson
Copy link
Contributor

No description provided.

CyrusNajmabadi and others added 30 commits June 7, 2023 14:28
@CyrusNajmabadi
Merge pull request #68460 from CyrusNajmabadi/norecurse
92d59e5 
Move off of recursion when determining pp-directive information for a file.
@jaredpar
logging
e59f54c
@CyrusNajmabadi
Merge pull request #68426 from CyrusNajmabadi/spellCheckingSmall
4e1b952 
Switch to new lower-overhead spell checking protocol
@jasonmalinowski
Merge pull request #68452 from jasonmalinowski/symbol-display-service…
91afe09 
…-cleanups-and-perf-improvements

Ensure we only ask for a symbol's documentation comment once
@jaredpar
more
bfcacc2
@jaredpar
fix refs
96e2758
@CyrusNajmabadi
Merge branch 'main' into structureTag3
fd55cba
@dibarbet
Merge branch 'main' into dev/dibarbet/merge_lsp_tools_host
ba65199
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/main' into noThrowDelay
316b1f4
@CyrusNajmabadi
Add dummy callback
1b1c8b7
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/main' into usePrimaryConstruct…
09989fc 
…orKeywordName
@CyrusNajmabadi
docs
08e783f
@CyrusNajmabadi
Revert
a4d55c4
@CyrusNajmabadi
Merge pull request #68390 from CyrusNajmabadi/usePrimaryConstructorKe…
63d4074 
…ywordName

Fix 'use primary constructor' with nested types.
@AlekseyTs
Implement definite assignment and region analysis for inline array ty…
2c31d1c 
…pes (#68339)
@sharwell
Merge pull request #68457 from sharwell/fix-service
ce5a320 
Fix 'Use Local Function' fixer in code style layer
@sharwell
Merge pull request #68338 from sharwell/delays
6079208 
Use DelayTimeSpan where applicable
@AlekseyTs
Support 'foreach' for inline arrays. (#68297)
cf124b4 
https://github.com/dotnet/csharplang/blob/main/proposals/inline-arrays.md#the-foreach-statement
@sharwell
Update to Nerdbank.Streams 2.9.116
352d10c 
Fixes random test failures involving cancellation of ServiceHub requests.
@sharwell
Merge pull request #68492 from sharwell/update-streams
8412ca0 
Update to Nerdbank.Streams 2.9.116
@AlekseyTs
Merge 'main' into InlineArrays
bd4cedd
@CyrusNajmabadi
Update version of roslyn-analyzers that Roslyn itself uses
2cd15d6
@CyrusNajmabadi
Make shared
0642d36
@CyrusNajmabadi
Make static
1c80338
@AlekseyTs
Merge 'main' into InlineArrays (#68496)
c23d2c1
@CyrusNajmabadi
Make static
c9c8838
@CyrusNajmabadi
Make static
2af6113
@CyrusNajmabadi
Make static
fb2330f
@dibarbet
Merge pull request #68461 from dibarbet/dev/dibarbet/merge_lsp_tools_…
384f18b 
…host

Merge internal fork of LSP tools back into Roslyn
@CyrusNajmabadi
Make static
ffae0a9
Miizukii and others added 14 commits June 27, 2023 01:59
@Miizukii @jjonescz @CyrusNajmabadi
Fixed CA1854: Prefer IDictionary.TryGetValue(TKey, out TValue) occurr…
ab87b4f 
…ences (#66515)

* fixed CA1854 occurrences c#

* fixed CA1854 occurrences VB

* VB init with Nothing + fix formatting

* Address PR feedback

* Update src/Workspaces/Core/Portable/Rename/ConflictEngine/RenamedSpansTracker.cs

Co-authored-by: Jan Jones <[email protected]>

* remove redundant ifs

* Apply suggestions from code review

Co-authored-by: CyrusNajmabadi <[email protected]>

---------

Co-authored-by: Jan Jones <[email protected]>
Co-authored-by: CyrusNajmabadi <[email protected]>
@GrahamTheCoder
Fixes SyntaxFactory.UsingDirective overload which always throws (#68762)
87286e9 
Fixes #68761
@tmat
More workarounds for VS Code project system issues (#68792)
bdbf1cb
@mavasani
Roslyn side changes to enable full solution background analysis in LS…
0f3200c 
…P/VSCode

Work towards #68553.
This needs a corresponding change in dotnet/vscode-csharp repo. I verified that this change + the corresponding vscode-csharp change enables FSA support in C# DevKit extension in VSCode.

Needs couple more Roslyn side fixes as a follow-up: #68797 and #68798
@mavasani
Merge pull request #68799 from mavasani/FSA_LSP
5d944ea 
Roslyn side changes to enable full solution background analysis in LSP/VSCode
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
faa8b81 
…626.5 (#68802)

[main] Update dependencies from dotnet/arcade
- Coherency Updates:
  - Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23312.2 to 1.0.0-beta.23319.1 (parent: Microsoft.DotNet.Arcade.Sdk)
@ToddGrun
Update VSTelemetry package version
03e0624 
Should address our side of https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1837883
@arunchndr
Merge pull request #68806 from ToddGrun/dev/toddgrun/UpdateVSTelemetr…
01dc829 
…yPackageVersion

Update VSTelemetry package version
@danmoseley
remove long gone owners (#68755)
5779db1
@davidwengier
Merge pull request #68744 from davidwengier/TokenModifiers
575bc42 
"Fix" LSP semantic token modifiers
@mavasani
Rename background analysis option name
b092535 
Avoid using 'solution crawler' terminology in the option name
@mavasani
Fix test
ffc685c
@AlekseyTs
Include expected custom modifiers for in parameters of virtual oper…
538b4e5 
…ators. (#68808)

Fixes #68767.
@mavasani
Merge pull request #68810 from mavasani/RenameBGOptionName
53ae96e 
Rename background analysis option name
@RikkiGibson RikkiGibson requested review from a team as code owners June 28, 2023 17:26
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 28, 2023
@RikkiGibson RikkiGibson removed request for a team June 28, 2023 17:28
CyrusNajmabadi and others added 2 commits June 28, 2023 10:55
@CyrusNajmabadi
Fix SuppressMessage attributes working on primary constructors (#68706)
02dc119 
* Fix SuppressMessage attributes working on primary constructors

* Simplify

* Simplify

* Use helper

* update docs

* update docs

* Add dedicated tests

* SHare code, add test

* remove using

* Rename
@AlekseyTs
Allow declaring ref fields as elements of inline arrays. (#68820)
7931076 
Closes #68819.
Consumption of such inline array types is still not supported.
@RikkiGibson RikkiGibson merged commit 1f2bdd6 into release/dev17.7 Jun 28, 2023
@RikkiGibson RikkiGibson deleted the merges/main-to-release/dev17.7 branch June 28, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunchndr arunchndr arunchndr approved these changes

Assignees
No one assigned
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.