Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Fix hwintrinsicChild->isContained() assert #96388

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 1, 2024

Backport of #90556 to release/8.0-staging

/cc @EgorBo

Customer Impact

Certain SIMD patterns may produce garbage values on CPUs with AVX-512 (mostly for unoptimized code). This is regression introduced in .NET 8 by AVX512 work.

There were two issues #96381 (customer reported) and #90508

Minimal repro:

double cns = 1.0;
var vec = Vector128.Create(42.0) + 
    Sse3.MoveAndDuplicate(Vector128.CreateScalarUnsafe(cns));
Console.WriteLine(vec);

Prints <42, 43> while <42, 42> is expected.

Testing

A test is added

Risk

Low. It is a simple fix, and the problem reproduces only on machines with AVX512 and with very specific patterns in Tier 0.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 1, 2024
@ghost
Copy link

ghost commented Jan 1, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90556 to release/8.0-staging

/cc @EgorBo

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlossanlop
Copy link
Member

@EgorBo Friendly reminder that Tuesday January 16th 4pm is the Code Complete deadline for the February Release. If all requirements are met, please merge your PR before that date and time to ensure this fix gets included in that Release.

@JulieLeeMSFT
Copy link
Member

@jeffschwMSFT, please consider this for approval.

@JulieLeeMSFT JulieLeeMSFT added the Servicing-consider Issue for next servicing release review label Jan 12, 2024
@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.x milestone Jan 12, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 13, 2024
@jeffschwMSFT jeffschwMSFT modified the milestones: 8.0.x, 8.0.2 Jan 13, 2024
@jeffschwMSFT jeffschwMSFT merged commit 9d77190 into release/8.0-staging Jan 13, 2024
121 of 128 checks passed
@jkotas jkotas deleted the backport/pr-90556-to-release/8.0-staging branch January 20, 2024 03:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants