Remove spacesOss plugin #108975

jportner · 2021-08-17T18:45:48Z

Partially resolves #104152.

Refactor the SpacesContext provider's fetched space data to make it usable by other consumers
Add CopyToSpaceFlyout to the Spaces plugin's public API contract
Change CopyToSpaceFlyout to work more efficiently by using space data that was loaded by the SpacesContext provider
Remove plugin dependencies on spacesOss plugin (from dashboard and savedObjectsManagement plugins)
- Includes: change savedObjectsManagement plugin to register the Spaces columns/actions directly
Remove spacesOss plugin completely
- Includes: moving all types to spaces plugin

This was originally built for only the "share to spaces" components to consume. However, we now have a need for other consumers too. I renamed it to "spacesDataPromise" and I changed the type for each entry, removing the specific "cannotShareToSpace" flag in favor of a generic "isAuthorizedForPurpose" function that can be used for any purpose.

Now uses spacesDataPromise instead of fetching all spaces each time the flyout is opened.

The dashboard and savedObjectsManagement plugins now both depend on the spaces plugin directly!

…ic#109068) * [RAC][Observability] remove severity fields from mapping keep only ALERT_SEVERITY * temporarily remove severity value occurences * remove ALERT_SEVERITY_VALUE occurences, this value is not being read and shown in the Observability alerts table * remove duplicate ALERT_SEVERITY identifier Co-authored-by: Kibana Machine <[email protected]>

…c#109122) * Fix rendering bug on Private Source status * Fix rendering bug on Private Source status * Refactor per code review

…elastic#109039)

This reverts commit c2f3100.

From 160 to 176px. Prevents overlapping of the labels. Fixes elastic#109103.

…lastic#108091) * Adding internal resolve API to resolve rules given an ID * Updating after merge * Updating after merge * Adding resolveRule api to client and adding spacesOss plugin dependency * Handling 404 errors by calling resolve. Updating unit tests * Handling aliasMatch and conflict results * Fixing types * Unit tests for spaces oss components * Adding audit event for resolve Co-authored-by: Kibana Machine <[email protected]>

…c#108720) * [ML] Add tooltip help text * [ML] Remove unused import * [ML] Update tooltip content to be clearer Co-authored-by: Lisa Cawley <[email protected]> Co-authored-by: Lisa Cawley <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>

…07305)

* [TSVB] Supports legends with long values * Add a unit test * Design optimization * Revert changes * Add the missing prop type * Ensure that the limits are respected Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-08-19T08:57:58Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`savedObjectsManagement`	79	82	+3
`spaces`	240	237	-3
`spacesOss`	4	-	-4
total			-4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dashboard`	221.4KB	221.3KB	-172.0B
`savedObjectsManagement`	140.8KB	140.7KB	-81.0B
`spaces`	265.2KB	265.2KB	+3.0B
total			-250.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`savedObjectsManagement`	34.3KB	39.1KB	+4.8KB
`spaces`	42.3KB	35.8KB	-6.5KB
`spacesOss`	2.5KB	-	-2.5KB
total			-4.3KB

Unknown metric groups

API count

id	before	after	diff
`savedObjectsManagement`	96	0	-96
`spaces`	110	198	+88
`spacesOss`	77	-	-77
total			-85

API count missing comments

id	before	after	diff
`savedObjectsManagement`	85	0	-85
`spaces`	4	16	+12
`spacesOss`	10	-	-10
total			-83

References to deprecated APIs

id	before	after	diff
`savedObjectsManagement`	20	0	-20

History

💔 Build #146765 failed 1758d12
💔 Build #146743 failed c6cbe45
💔 Build #146480 failed 4d07617
💔 Build #146420 failed 3baa6a7
💚 Build #146326 succeeded 901aa40

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jportner

Author's notes for reviewers

jportner · 2021-08-19T12:11:52Z

x-pack/plugins/maps/tsconfig.json

+    { "path": "../../../src/plugins/dashboard/tsconfig.json" },
+    { "path": "../../../src/plugins/inspector/tsconfig.json" },
+    { "path": "../../../src/plugins/data/tsconfig.json" },
+    { "path": "../../../src/plugins/ui_actions/tsconfig.json" },
+    { "path": "../../../src/plugins/navigation/tsconfig.json" },
+    { "path": "../../../src/plugins/expressions/tsconfig.json" },
+    { "path": "../../../src/plugins/visualizations/tsconfig.json" },
+    { "path": "../../../src/plugins/embeddable/tsconfig.json" },
+    { "path": "../../../src/plugins/saved_objects/tsconfig.json" },
+    { "path": "../../../src/plugins/share/tsconfig.json" },
+    { "path": "../../../src/plugins/presentation_util/tsconfig.json" },
+    { "path": "../../../src/plugins/home/tsconfig.json" },
+    { "path": "../../../src/plugins/charts/tsconfig.json" },
+    { "path": "../../../src/plugins/usage_collection/tsconfig.json" },
+    { "path": "../../../src/plugins/kibana_react/tsconfig.json" },
+    { "path": "../../../src/plugins/kibana_utils/tsconfig.json" },
+
    { "path": "../features/tsconfig.json" },
    { "path": "../licensing/tsconfig.json" },
    { "path": "../file_upload/tsconfig.json" },
    { "path": "../saved_objects_tagging/tsconfig.json" },
+    { "path": "../security/tsconfig.json" }


@elastic/kibana-gis it seems these TS references were mistakenly omitted from your tsconfig.json file. Speaking with @spalger it seems there is a bug in the TS checker which did not surface until my other (unrelated) changes in this PR.

TL;DR these references should have always been here 👍

jportner · 2021-08-19T12:15:21Z

x-pack/plugins/spaces/public/copy_saved_objects_to_space/lib/process_import_response.ts

+// This is derived from the function of the same name in the savedObjectsManagement plugin
+export function processImportResponse(
+  response: SavedObjectsImportResponse
+): ProcessedImportResponse {
+  const { success, errors = [], successResults = [] } = response;
+  const failedImports = errors.map<FailedImport>(({ error, ...obj }) => ({ obj, error }));
+  return {
+    success,
+    failedImports,
+    successfulImports: successResults,
+  };
+}


I needed to remove this to handle a cyclic dependency between the spaces and savedObjectsManagement plugin.

Since copy-to-space was implemented as a thin veneer over export/import, the CTS flyout used this existing processImportResponse function from the savedObjectsManagement plugin to process the import response.

Turns out we could pare this down quite a bit, we didn't need a lot of what the original function provided for CTS. So I decided to just recreate a CTS-specific function here to remove that problematic dependency 👍

Seems like the most pragmatic approach

jportner · 2021-08-19T12:19:44Z

x-pack/plugins/spaces/public/spaces_context/wrapper_internal.tsx

-async function getShareToSpacesData(
-  spacesManager: SpacesManager,
-  feature?: string
-): Promise<ShareToSpacesData> {
+async function getSpacesData(spacesManager: SpacesManager, feature?: string): Promise<SpacesData> {
  const spaces = await spacesManager.getSpaces({ includeAuthorizedPurposes: true });
  const activeSpace = await spacesManager.getActiveSpace();
  const spacesMap = spaces
-    .map<ShareToSpaceTarget>(({ authorizedPurposes, disabledFeatures, ...space }) => {
+    .map<SpacesDataEntry>(({ authorizedPurposes, disabledFeatures, ...space }) => {
      const isActiveSpace = space.id === activeSpace.id;
-      const cannotShareToSpace = authorizedPurposes?.shareSavedObjectsIntoSpace === false;
      const isFeatureDisabled = feature !== undefined && disabledFeatures.includes(feature);
      return {
        ...space,
        ...(isActiveSpace && { isActiveSpace }),
-        ...(cannotShareToSpace && { cannotShareToSpace }),
        ...(isFeatureDisabled && { isFeatureDisabled }),
+        isAuthorizedForPurpose: (purpose: GetAllSpacesPurpose) =>
+          // If authorizedPurposes is not present, then Security is disabled; normally in a situation like this we would "fail-secure", but
+          // in this case we are dealing with an abstraction over the client-side UI capabilities. There is no chance for privilege
+          // escalation here, and the correct behavior is that if Security is disabled, the user is implicitly authorized to do everything.
+          authorizedPurposes ? authorizedPurposes[purpose] === true : true,
      };
    })
-    .reduce((acc, cur) => acc.set(cur.id, cur), new Map<string, ShareToSpaceTarget>());
+    .reduce((acc, cur) => acc.set(cur.id, cur), new Map<string, SpacesDataEntry>());


This function is run when the SpacesContext provider is first mounted. It fetches all spaces and passes them to consumers via the context value.

This was originally purpose-built for the share-to-space flyout, but I renamed it and added a generic isAuthorizedForPurpose function. I have two motivations behind this:

The CTS flyout can also reuse this data, so we don't need to fetch all spaces every time the flyout is rendered

Other consumers can reuse this data in the future so they don't have to fetch all spaces too

jgowdyelastic

ML changes LGTM

nreese

maps changes LGTM. Thanks for fixing our tsconfig.json file

jbudz

limits.yml LGTM

jportner · 2021-08-19T14:43:13Z

Ugh, I merged upstream and it pulled in those changes. Sorry everyone for unnecessary pings, I'll close this PR and open a new one 😫

jportner added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Aug 17, 2021

jportner force-pushed the issue-104152-refactor-spaces-oss branch from 4d07617 to c6cbe45 Compare August 18, 2021 19:09

jportner added 7 commits August 18, 2021 15:47

Add CopyToSpaceFlyout to spaces public API contract

4c50a07

Change CopyToSpaceFlyout to use data from SpacesContext provider

58301f7

Now uses spacesDataPromise instead of fetching all spaces each time the flyout is opened.

Remove dependencies on spacesOss plugin

c420dbe

The dashboard and savedObjectsManagement plugins now both depend on the spaces plugin directly!

Remove spacesOss plugin

22c1b1c

Remove spaces dependency on savedObjectsManagement

13574cb

Fix ts refs...?

1758d12

jportner force-pushed the issue-104152-refactor-spaces-oss branch from c6cbe45 to 1758d12 Compare August 18, 2021 20:27

mgiota and others added 13 commits August 18, 2021 16:29

Add deprecation notice to dashboard import/export docs. (elastic#108826)

49ba7e7

[Workplace Search] Fix rendering bug on Private Source status (elasti…

83a7720

…c#109122) * Fix rendering bug on Private Source status * Fix rendering bug on Private Source status * Refactor per code review

[Security Solution][Endpoint][Event Filters] Event filters updated UI (…

447ae98

…elastic#109039)

[Fleet] Missing migration backport in 7.14.0 (elastic#109174)

f719aa4

Revert "[build] Remove optimize dir creation (elastic#109014)"

64454f3

This reverts commit c2f3100.

Increase width of service inventory sparkplot columns (elastic#109137)

09f122b

From 160 to 176px. Prevents overlapping of the labels. Fixes elastic#109103.

Fixed flakiness with visualize custom role (elastic#109077)

e7098ad

Co-authored-by: Kibana Machine <[email protected]>

Fix flakiness in load and save agg-based visualizations (elastic#109066)

2172b88

Co-authored-by: Kibana Machine <[email protected]>

[Discover] Unskip discover tab field data functional tests (elastic#1…

544c41e

…07305)

fix tsref? bis

98a3916

This was referenced Aug 19, 2021

Add multi-space support to SO management and import/export API #109196

Closed

Saved objects import/export should include spaces #91615

Open

[TSVB] Long legend values support (elastic#108023)

fe08d0a

* [TSVB] Supports legends with long values * Add a unit test * Design optimization * Revert changes * Add the missing prop type * Ensure that the limits are respected Co-authored-by: Kibana Machine <[email protected]>

Introduce Enroll API endpoint. (elastic#108835)

cb0ce59

jportner requested review from a team as code owners August 19, 2021 12:09

jportner commented Aug 19, 2021

View reviewed changes

jportner requested review from spalger and pgayvallet August 19, 2021 12:33

jgowdyelastic approved these changes Aug 19, 2021

View reviewed changes

afharo and others added 2 commits August 19, 2021 08:40

[Flaky-tests] Fix SOM edit-saved-objects test (elastic#109215)

3cb3984

Merge branch 'master' into pr/jportner/108975

3232947

nreese approved these changes Aug 19, 2021

View reviewed changes

Remove spacesOss dependency from triggers_actions_ui plugin

754d4bc

jbudz approved these changes Aug 19, 2021

View reviewed changes

Expose useSpaces function to external consumers

01a9b86

jportner requested review from a team as code owners August 19, 2021 14:40

jportner requested a review from a team August 19, 2021 14:40

jportner requested review from a team as code owners August 19, 2021 14:40

jportner requested review from a team, ashokaditya and parkiino August 19, 2021 14:40

jportner closed this Aug 19, 2021

jportner mentioned this pull request Aug 19, 2021

Remove spacesOss plugin #109258

Merged

6 tasks

jportner deleted the issue-104152-refactor-spaces-oss branch September 14, 2021 14:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove spacesOss plugin #108975

Remove spacesOss plugin #108975

jportner commented Aug 17, 2021 •

edited

Loading

kibanamachine commented Aug 19, 2021

API count

API count missing comments

References to deprecated APIs

jportner left a comment

jportner Aug 19, 2021 •

edited

Loading

jportner Aug 19, 2021 •

edited

Loading

pgayvallet Aug 19, 2021

jportner Aug 19, 2021

jgowdyelastic left a comment

nreese left a comment

jbudz left a comment

jportner commented Aug 19, 2021

Remove spacesOss plugin #108975

Remove spacesOss plugin #108975

Conversation

jportner commented Aug 17, 2021 • edited Loading

kibanamachine commented Aug 19, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

API count

API count missing comments

References to deprecated APIs

History

jportner left a comment

Choose a reason for hiding this comment

jportner Aug 19, 2021 • edited Loading

Choose a reason for hiding this comment

jportner Aug 19, 2021 • edited Loading

Choose a reason for hiding this comment

pgayvallet Aug 19, 2021

Choose a reason for hiding this comment

jportner Aug 19, 2021

Choose a reason for hiding this comment

jgowdyelastic left a comment

Choose a reason for hiding this comment

nreese left a comment

Choose a reason for hiding this comment

jbudz left a comment

Choose a reason for hiding this comment

jportner commented Aug 19, 2021

jportner commented Aug 17, 2021 •

edited

Loading

jportner Aug 19, 2021 •

edited

Loading

jportner Aug 19, 2021 •

edited

Loading