Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Graph] Make graph edges easier to click #124053

Merged
merged 15 commits into from
Feb 15, 2022
Merged

[Graph] Make graph edges easier to click #124053

merged 15 commits into from
Feb 15, 2022

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jan 28, 2022

Summary

Came out while developing #123966

This PR introduces a secondary transparent edge with a minimum thickness of 15px to simplify the edge click on top of the one shown to the user.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dej611 dej611 added the Feature:Graph Graph application feature label Jan 28, 2022
@dej611
Copy link
Contributor Author

dej611 commented Feb 1, 2022

@elasticmachine merge upstream

@dej611 dej611 added backport:skip This commit does not require backporting Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.1.0 labels Feb 1, 2022
@dej611 dej611 marked this pull request as ready for review February 1, 2022 13:06
@dej611 dej611 requested a review from a team as a code owner February 1, 2022 13:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-graph (Feature:Graph)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal
kertal reviewed Feb 3, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx so much for taking care of this. So it seems to me that while the edge is now easier to click, highlighting when hovering doesn't work anymore? Furthermore, but that's independent of this PR ... selecting an edges seems to work randomly ... does it work for you? Many thx!

graph-highlighting.mp4

@dej611 dej611 requested a review from a team as a code owner February 4, 2022 11:26
@dej611
Copy link
Contributor Author

dej611 commented Feb 4, 2022

The hover behaviour should be fixed now, and as for the selection it applies for the incremented area.

edge_hover

Furthermore, but that's independent of this PR ... selecting an edges seems to work randomly ... does it work for you? Many thx!

From my understanding there's not strictly an edge selection, rather a search on terms intersection when the user selects an edge: sometimes this search returns no result, hence the "selection" (for clarity the Venn diagram on the panel) is not showing up.
The clause for the .gphEdge--selected class is always false as the isSelected prop is never set in the workspace code: I've added edge selection in #123966 as well. I can make a follow up PR with that too if you like it.

@dej611
Copy link
Contributor Author

dej611 commented Feb 7, 2022

@elasticmachine merge upstream

@dej611
Copy link
Contributor Author

dej611 commented Feb 8, 2022

@elasticmachine merge upstream

@dej611
Copy link
Contributor Author

dej611 commented Feb 10, 2022

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Feb 14, 2022

@elasticmachine merge upstream

@kertal kertal self-requested a review February 14, 2022 10:02
kertal
kertal approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTO delayed Code LGTM 👍 no longer you have to be a pixel perfect clicker, so its much more convenient this way. Thx for the clarification, leave it up to you and the time you have available to implement further improvement

@dej611 dej611 added v8.2.0 and removed v8.1.0 labels Feb 15, 2022
@dej611
Copy link
Contributor Author

dej611 commented Feb 15, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 448.4KB 448.8KB +350.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit 57ef9e5 into elastic:main Feb 15, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 15, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into screenshotting/…
11c9878 
…pdf-generation-in-worker-thread

* 'main' of github.com:elastic/kibana: (40 commits)
  Service overview e2e test (elastic#125359)
  [Graph] Make graph edges easier to click (elastic#124053)
  [Reporting] Add additional PNG and PDF metrics  (elastic#125450)
  [APM] Lint rule for explicit return types (elastic#124771)
  [SecuritySolution] Enrich threshold data from correct fields (elastic#125376)
  [Uptime monitor management] Make index template installation retry (elastic#125537)
  [Console] Support suggesting index templates v2 (elastic#124655)
  [Logs UI] Support switching between log source modes (elastic#124929)
  SavedObjects management: change index patterns labels to data views (elastic#125356)
  [ci-stats] add Client class for accessing test group stats (elastic#125164)
  [ML] Use Discover locator in Data Visualizer instead of URL Generator (elastic#124283)
  [Fleet] Add retries when starting docker registry in integration tests (elastic#125530)
  Update osquery.asciidoc to address doc issue (elastic#125425)
  synthetics e2e - use custom location when defined (elastic#125560)
  [ci] Retry failed steps in on-merge pipeline (elastic#125550)
  [babel] Bump babel packages (elastic#125446)
  [DOCS] Updates Upgrade Assistant API status (elastic#125410)
  [DOCS] Minor tweaks to upgrade docs (elastic#125538)
  [Uptime] handle null duration on ping list (elastic#125438)
  [TSVB][Lens] Navigate to Lens with your current configuration (elastic#114794)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/export_types/common/pdf/pdfmaker.ts
#	x-pack/plugins/reporting/server/export_types/printable_pdf/lib/generate_pdf.ts
#	x-pack/plugins/reporting/server/export_types/printable_pdf_v2/lib/generate_pdf.ts
@dej611 dej611 mentioned this pull request Mar 10, 2022
Merged
9 tasks
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment Feature:Graph Graph application feature release_note:enhancement Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dej611 @elasticmachine @kertal @kibana-ci @ryankeairns @tylersmalley @kibanamachine