Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-stats] add Client class for accessing test group stats #125164

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Feb 9, 2022

In order to support pulling test group stats from ci-stats in Kibana code I'd like to add a new CiStatsClient class which exposes non-reporter methods (mostly so we don't bloat or complicate the reporter). This currently just includes one method:

CiStatsClient#getLatestTestGroupStats({
  /** The Kibana branch to get stats for, eg "main" */
  branch: string;
  /** The CI job names to filter builds by, eg "kibana-hourly" */
  ciJobNames: string[];
  /** Filter test groups by group type */
  testGroupType?: string;
})

@spalger spalger added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.0 v8.0.0 v8.1.0 v8.2.0 labels Feb 10, 2022
@spalger spalger marked this pull request as ready for review February 10, 2022 00:40
@spalger spalger requested a review from a team as a code owner February 10, 2022 00:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger
Copy link
Contributor Author

spalger commented Feb 14, 2022

@elasticmachine merge upstream

@spalger spalger enabled auto-merge (squash) February 14, 2022 19:53
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/dev-utils 193 200 +7

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/dev-utils 0 1 +1
Unknown metric groups

API count

id before after diff
@kbn/dev-utils 275 281 +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 48e8a84 into elastic:main Feb 14, 2022
@spalger spalger deleted the implement/ci-stats-client branch February 14, 2022 21:25
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 14, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 14, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 14, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.0
8.1
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 14, 2022
…125586)

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 48e8a84)

Co-authored-by: Spencer <[email protected]>
kibanamachine added a commit that referenced this pull request Feb 14, 2022
…125587)

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 48e8a84)

Co-authored-by: Spencer <[email protected]>
kibanamachine added a commit that referenced this pull request Feb 14, 2022
…125588)

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 48e8a84)

Co-authored-by: Spencer <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 15, 2022
…pdf-generation-in-worker-thread

* 'main' of github.com:elastic/kibana: (40 commits)
  Service overview e2e test (elastic#125359)
  [Graph] Make graph edges easier to click (elastic#124053)
  [Reporting] Add additional PNG and PDF metrics  (elastic#125450)
  [APM] Lint rule for explicit return types (elastic#124771)
  [SecuritySolution] Enrich threshold data from correct fields (elastic#125376)
  [Uptime monitor management] Make index template installation retry (elastic#125537)
  [Console] Support suggesting index templates v2 (elastic#124655)
  [Logs UI] Support switching between log source modes (elastic#124929)
  SavedObjects management: change index patterns labels to data views (elastic#125356)
  [ci-stats] add Client class for accessing test group stats (elastic#125164)
  [ML] Use Discover locator in Data Visualizer instead of URL Generator (elastic#124283)
  [Fleet] Add retries when starting docker registry in integration tests (elastic#125530)
  Update osquery.asciidoc to address doc issue (elastic#125425)
  synthetics e2e - use custom location when defined (elastic#125560)
  [ci] Retry failed steps in on-merge pipeline (elastic#125550)
  [babel] Bump babel packages (elastic#125446)
  [DOCS] Updates Upgrade Assistant API status (elastic#125410)
  [DOCS] Minor tweaks to upgrade docs (elastic#125538)
  [Uptime] handle null duration on ping list (elastic#125438)
  [TSVB][Lens] Navigate to Lens with your current configuration (elastic#114794)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/export_types/common/pdf/pdfmaker.ts
#	x-pack/plugins/reporting/server/export_types/printable_pdf/lib/generate_pdf.ts
#	x-pack/plugins/reporting/server/export_types/printable_pdf_v2/lib/generate_pdf.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.0 v8.0.0 v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants