Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] handle null duration on ping list #125438

Merged
merged 7 commits into from
Feb 14, 2022
Merged

[Uptime] handle null duration on ping list #125438

merged 7 commits into from
Feb 14, 2022

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Feb 11, 2022 •
edited
Loading

Summary

Displays -- on the Ping List Table when monitor duration is null.

Includes a helpful tooltip to help users understand why duration does not exist.

Testing

In order to test this, I manually overwrote the duration of each ping in PingListTable to be null.

In the future, once this PR Is merged, you'll be able to do this by creating a browser monitor with a syntax error, preventing the journey from executing.

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v7.17.1 labels Feb 11, 2022
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner February 11, 2022 20:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

dominiqueclarke
dominiqueclarke commented Feb 11, 2022
View reviewed changes
x-pack/plugins/uptime/public/components/monitor/ping_list/ping_list_table.tsx Outdated
) : (
<EuiToolTip
content={i18n.translate('xpack.uptime.pingList.durationColumnToolTip', {
defaultMessage: 'Duration is unavailable for journeys that do not finish executing',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this logic ever apply to lightweight checks? The content I have now is very specific to journeys

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better to keep error not specific to journeys? Or even keep it as '--'

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #15 / machine learning model management trained models for ML user with read-only access renders expanded row content correctly for model with pipelines

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 737.9KB 738.0KB +109.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit 52e9c51 into elastic:main Feb 14, 2022
@dominiqueclarke dominiqueclarke deleted the fix/uptime-handle-null-duration branch February 14, 2022 17:10
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.2.0

If any of these should not be on your pull request, please manually remove them.

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.0 Backport failed because of merge conflicts
❌ 8.1 Backport failed because of merge conflicts
❌ 7.17 Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 125438

Questions ?

Please refer to the Backport tool documentation

@dominiqueclarke dominiqueclarke mentioned this pull request Feb 14, 2022
Merged
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Feb 14, 2022
@dominiqueclarke
[Uptime] handle null duration on ping list (elastic#125438)
8dfb4cb 
* uptime - handle null duration

* adjust types

* Update x-pack/plugins/uptime/server/lib/synthetics_service/service_api_client.ts

* raise per page of synthetics monitors

* Remove tooltip

(cherry picked from commit 52e9c51)

# Conflicts:
#	x-pack/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Feb 14, 2022
@dominiqueclarke
[Uptime] handle null duration on ping list (elastic#125438)
5d08669 
* uptime - handle null duration

* adjust types

* Update x-pack/plugins/uptime/server/lib/synthetics_service/service_api_client.ts

* raise per page of synthetics monitors

* Remove tooltip

(cherry picked from commit 52e9c51)

# Conflicts:
#	x-pack/plugins/uptime/public/components/monitor/ping_list/ping_list_table.tsx
#	x-pack/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx
#	x-pack/plugins/uptime/server/lib/synthetics_service/synthetics_service.ts
This was referenced Feb 14, 2022
Merged
Merged
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Feb 14, 2022
@dominiqueclarke
[Uptime] handle null duration on ping list (elastic#125438)
bd0faa0 
* uptime - handle null duration

* adjust types

* Update x-pack/plugins/uptime/server/lib/synthetics_service/service_api_client.ts

* raise per page of synthetics monitors

* Remove tooltip

(cherry picked from commit 52e9c51)

# Conflicts:
#	x-pack/plugins/uptime/public/components/monitor/ping_list/ping_list_table.tsx
#	x-pack/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx
#	x-pack/plugins/uptime/server/lib/synthetics_service/synthetics_service.ts
dominiqueclarke added a commit that referenced this pull request Feb 14, 2022
@dominiqueclarke
[Uptime] handle null duration on ping list (#125438) (#125549)
6da02ba 
* uptime - handle null duration

* adjust types

* Update x-pack/plugins/uptime/server/lib/synthetics_service/service_api_client.ts

* raise per page of synthetics monitors

* Remove tooltip

(cherry picked from commit 52e9c51)

# Conflicts:
#	x-pack/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx
dominiqueclarke added a commit that referenced this pull request Feb 14, 2022
@dominiqueclarke
[Uptime] handle null duration on ping list (#125438) (#125552)
bbefaf0 
* uptime - handle null duration

* adjust types

* Update x-pack/plugins/uptime/server/lib/synthetics_service/service_api_client.ts

* raise per page of synthetics monitors

* Remove tooltip

(cherry picked from commit 52e9c51)

# Conflicts:
#	x-pack/plugins/uptime/public/components/monitor/ping_list/ping_list_table.tsx
#	x-pack/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx
#	x-pack/plugins/uptime/server/lib/synthetics_service/synthetics_service.ts
dominiqueclarke added a commit that referenced this pull request Feb 14, 2022
@dominiqueclarke
[7.17] [Uptime] handle null duration on ping list (#125438) (#125556)
dc3fe64 
* [Uptime] handle null duration on ping list (#125438)

* uptime - handle null duration

* adjust types

* Update x-pack/plugins/uptime/server/lib/synthetics_service/service_api_client.ts

* raise per page of synthetics monitors

* Remove tooltip

(cherry picked from commit 52e9c51)

# Conflicts:
#	x-pack/plugins/uptime/public/components/monitor/ping_list/ping_list_table.tsx
#	x-pack/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx
#	x-pack/plugins/uptime/server/lib/synthetics_service/synthetics_service.ts

* Update x-pack/plugins/uptime/public/components/monitor/ping_list/ping_list.tsx
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 15, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into screenshotting/…
11c9878 
…pdf-generation-in-worker-thread

* 'main' of github.com:elastic/kibana: (40 commits)
  Service overview e2e test (elastic#125359)
  [Graph] Make graph edges easier to click (elastic#124053)
  [Reporting] Add additional PNG and PDF metrics  (elastic#125450)
  [APM] Lint rule for explicit return types (elastic#124771)
  [SecuritySolution] Enrich threshold data from correct fields (elastic#125376)
  [Uptime monitor management] Make index template installation retry (elastic#125537)
  [Console] Support suggesting index templates v2 (elastic#124655)
  [Logs UI] Support switching between log source modes (elastic#124929)
  SavedObjects management: change index patterns labels to data views (elastic#125356)
  [ci-stats] add Client class for accessing test group stats (elastic#125164)
  [ML] Use Discover locator in Data Visualizer instead of URL Generator (elastic#124283)
  [Fleet] Add retries when starting docker registry in integration tests (elastic#125530)
  Update osquery.asciidoc to address doc issue (elastic#125425)
  synthetics e2e - use custom location when defined (elastic#125560)
  [ci] Retry failed steps in on-merge pipeline (elastic#125550)
  [babel] Bump babel packages (elastic#125446)
  [DOCS] Updates Upgrade Assistant API status (elastic#125410)
  [DOCS] Minor tweaks to upgrade docs (elastic#125538)
  [Uptime] handle null duration on ping list (elastic#125438)
  [TSVB][Lens] Navigate to Lens with your current configuration (elastic#114794)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/export_types/common/pdf/pdfmaker.ts
#	x-pack/plugins/reporting/server/export_types/printable_pdf/lib/generate_pdf.ts
#	x-pack/plugins/reporting/server/export_types/printable_pdf_v2/lib/generate_pdf.ts
@dominiqueclarke
Copy link
Contributor Author

Tested in production with Kibana on commit ba8c339d84c1d26441f049650296ab4072147128, using a browser monitor that would trigger a syntax error.

Post FF testing looks good to me!

Screen Shot 2022-02-22 at 1 51 05 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam left review comments

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.17.1 v8.0.0 v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dominiqueclarke @elasticmachine @kibana-ci @kibanamachine @shahzad31 @vigneshshanmugam