Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apm: add ECS fields to index pattern #26214

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Conversation

graphaelli
Copy link
Member

This PR updates the Kibana index pattern to include newly introduced fields for APM.

To be backported to 6.x, where these will be aliases.

for elastic/apm-server#1582

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@graphaelli graphaelli added the Team:APM All issues that need APM UI Team support label Nov 26, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@jasonrhodes
Copy link
Member

Here's what I see, does this look correct @graphaelli ?
New field names:

[
  "agent.ephemeral_id",
  "agent.hostname",
  "agent.id",
  "agent.type",
  "agent.version",
  "base.@timestamp",
  "base.labels",
  "base.message",
  "base.tags",
  "cloud.account.id",
  "cloud.availability_zone",
  "cloud.instance.id",
  "cloud.instance.name",
  "cloud.machine.type",
  "cloud.provider",
  "cloud.region",
  "container.id",
  "container.image.name",
  "container.image.tag",
  "container.labels",
  "container.name",
  "container.runtime",
  "destination.domain",
  "destination.geo.city_name",
  "destination.geo.continent_name",
  "destination.geo.country_iso_code",
  "destination.geo.location",
  "destination.geo.region_iso_code",
  "destination.geo.region_name",
  "destination.ip",
  "destination.mac",
  "destination.port",
  "device.hostname",
  "device.ip",
  "device.mac",
  "device.serial_number",
  "device.timezone.offset.sec",
  "device.type",
  "device.vendor",
  "device.version",
  "event.action",
  "event.category",
  "event.created",
  "event.dataset",
  "event.duration",
  "event.hash",
  "event.id",
  "event.module",
  "event.original",
  "event.risk_score",
  "event.risk_score_norm",
  "event.severity",
  "event.type",
  "event.version",
  "file.ctime",
  "file.device",
  "file.extension",
  "file.gid",
  "file.group",
  "file.inode",
  "file.mode",
  "file.mtime",
  "file.owner",
  "file.path",
  "file.path.raw",
  "file.size",
  "file.target_path",
  "file.target_path.raw",
  "file.type",
  "file.uid",
  "geo.city_name",
  "geo.continent_name",
  "geo.country_iso_code",
  "geo.location",
  "geo.region_name",
  "host.os.name",
  "host.timezone.offset.sec",
  "host.type",
  "http.request.method",
  "http.response.body",
  "http.response.status_code",
  "http.version",
  "log.level",
  "log.original",
  "network.direction",
  "network.forwarded_ip",
  "network.inbound.bytes",
  "network.inbound.packets",
  "network.name",
  "network.name.raw",
  "network.outbound.bytes",
  "network.outbound.packets",
  "network.protocol",
  "network.total.bytes",
  "network.total.packets",
  "organization.id",
  "organization.name",
  "os.family",
  "os.kernel",
  "os.name",
  "os.platform",
  "os.version",
  "process.args",
  "process.name",
  "process.pid",
  "process.ppid",
  "process.title",
  "service.ephemeral_id",
  "service.id",
  "service.name",
  "service.state",
  "service.type",
  "service.version",
  "source.domain",
  "source.geo.city_name",
  "source.geo.continent_name",
  "source.geo.country_iso_code",
  "source.geo.location",
  "source.geo.region_iso_code",
  "source.geo.region_name",
  "source.ip",
  "source.mac",
  "source.port",
  "url.fragment",
  "url.hostname",
  "url.href",
  "url.href.raw",
  "url.password",
  "url.path",
  "url.path.raw",
  "url.port",
  "url.query",
  "url.query.raw",
  "url.scheme",
  "url.username",
  "user.email",
  "user.hash",
  "user.id",
  "user.name",
  "user_agent.device",
  "user_agent.major",
  "user_agent.minor",
  "user_agent.name",
  "user_agent.original",
  "user_agent.os.major",
  "user_agent.os.minor",
  "user_agent.os.name",
  "user_agent.os.version",
  "user_agent.patch",
  "user_agent.version"
]

Old field names no longer here:

[
  "beat.version",
  "error.code"
]

Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the lists in my PR comment look correct to @graphaelli, LGTM

@graphaelli
Copy link
Member Author

That's right. error.code will return shortly but with a different type.

@graphaelli graphaelli merged commit 29fb9e2 into elastic:master Nov 27, 2018
@graphaelli graphaelli deleted the apm-ecs-1 branch November 27, 2018 21:37
sebelga added a commit that referenced this pull request Nov 28, 2018
* [APM] Fix horizontal scrollbar being visible in windows 8.1 (#25988)

* [APM] Changed 'Response Time' to 'Duration' in transactions screens (#25990)

* translate InfraOps visualization component (Part 3) (#25213)

* translate InfraOps visualization component (Part 3 - part of folder components)

* update translation of Infra Ops vizualization component (Part 3)

* update translation of Infra Ops vizualization component (Part 3)

* change some ids and add pluralization

* update Infra Ops Part 3 - change some ids, change some intl.formatMessage() to <FormattedMessage> and directly wrap some classes by injectI18n()

* update Infra-III - add static to displayName

* [i18n] Translate Agg_types(part_3) (#26118)

* Translate agg_types - metrics

* Fix issues

* [ML] Aggregate anomalies table data using configured Kibana timezone (#26192)

* [ML] Aggregate anomalies table data using configured Kibana timezone

* [ML] Move dataFormatTz prop out of controller scope

* [ML] Fix alignment of filter icons in anomalies table (#26253)

* [ML] Fix alignment of filter icons in anomalies table

* [ML] Teak y position of icons in expanded row of table

* translate sample data (#26069)

translate sample data

* [ML] Wrap controller initialization in assertions. (#26265)

- The controller tests introduced in #25382 had a flaw: If a controller initialization would fail and throw an error, that test suite wouldn't be able to clean up any stubs. So tests using the same stubs would report and error because the stubs couldn't be wrapped again.
- This PR wraps every controller initialization inside an assertion and catches those errors properly as part of the test.

* [APM] fixes #20145 by displaying span.context.http.url in the span details flyout (#26238)

* Fix spaces license check (#26270)

## Summary

Allows the public spaces API to work with a gold license

Resolves #26271

* Job Info button in Reporting Listing (#25421)

* Job Info button in Reporting Listing

* use lodash directly

* start of flyout use

* description list in flyout

* capitalize

* undefined guard

* expire info on close

* add jest test

* better at error handling + messaging

* Add description for vis types (#26243)

* [migrations] Throw error if reindex task fails (#26062)

Signed-off-by: Tyler Smalley <[email protected]>

* [Reporting] Better logging for waitForSelector failure (#25762)

* [Reporting] Better logging for waitForSelector failure

* break waitForSelector

* experimental changes

* cleanup/consistency

* fix some test report title strings

* test disable chromium

* roll back test code

* take out non-working phantom changes

* roll back disable chromium test

* allow logger to use curried tags

* temporarily re-do report failure-causing change for test

* replace newline with escaped for single log line

* undo test change

* remove obsolete test

* [kbn/pm] allow packages to define extra paths to clean (#26132)

I noticed some discussion about how kbn clean should probably clear out the `.eslintcache` file, since it doesn't handle changes in related modules (for things like the import plugin) and it would be nice if `yarn kbn clean` took care of the issue. I figured it's not a bad idea, but adding `.eslintcache` directly to `@kbn/pm` felt wrong, so instead I've added another config options that can go in the package.json file, `clean.extraPatterns`. This array of patterns is passed into `del()` so that it can include things like negation.

As the name suggests this doesn't override the initial paths, just adds some extras that will be checked and cleared when `yarn kbn clean` is run.

* [config] fix logging.useUTC deprecation unset (#26053)

* Extend precommit hook script to support git GUI apps (#25883)

* feat(NA): extend support from precommit hook to git GUI apps.

* docs(NA): more descriptive error message.

* [DOCS] Clarify monitoring dependencies (#26229)

* apm: add ECS fields to index pattern (#26214)

* support standard license (#26294)

* [kbn-pm] update build

* [eslint] use disallow license header rule (#26309)

Fixes #26295

There are several places where we have accidentally added new license headers with linters but failed to remove old license headers manually. This prevents that by applying the an inverted version of the license headers rule that removed invalid license headers when files are moved.

* Bump node to 8.14.0 (#26313)

Signed-off-by: Tyler Smalley <[email protected]>

* Watch optimizer cache invalidation  (#24172)

* chore(NA): cherry pick work from spencer on impleting the cache invalidation system and merging it with current master.

* feat(NA): add support for dlls bundle into the cache state invalidation system.

* chore(NA): merge with master.

* feat(NA): first working version for the watch cache.

* feat(NA): added logger, correct cache delete and removed last todos.

* feat(NA): remove some useless features for the time being.

* refact(NA): just pass kibanaHapiServer.log function directly instead of an anonimous function that calls the kibanaHapiServer.log one.

* refact(NA): move everything to async.

* refact(NA): remove dll mentions.

* chore(NA): removed types/mkdirp as we dont use mkdirp into typescript.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants