[ILM] TS conversion of Index Management plugin extension #76308

yuliacech · 2020-08-31T17:00:20Z

Summary

This PR converts Index Management plugin extension to TypeScript as an ongoing effort of converting the ILM plugin #74271. No UI/UX changes were made in this PR. To test for any regression, navigate to Index Management plugin and check following features in the Indices tab:

Action button to retry a lifecycle policy (only shown if all indices in the list have a lifecycle phase error)
Action button to add a lifecycle policy (if the index is not managed already)
Action button to delete a lifecycle policy (if the index is managed)
A banner on top of the indices list if there is an index with a lifecycle phase error (an error can be created by setting non existent snapshot policy name in Delete phase, for example)
A section with lifecycle policy information in the Index details flyout (only shown if the index is managed)
A filter for lifecycle status and lifecycle phase

Todo

After this PR and policies table conversion PR #76006 are both merged, a follow-up PR will convert all the remaining js files, such as jest tests, services and helpers, also any remaining any types will be cleaned up to complete #74271

* eui to v28.0.0 * eui to 28.2.0 * euiselectableoptions type update * targeted nohoist * src snapshot updates * x-pack snapshot updates * strong -> mark * upgrade @elastic/charts to v21.0.1 * strong -> mark * fix charts version merge * maps -> add_field_tooltip_popover type update * snapshot update * Fix gridline visibility Co-authored-by: Justin Kambic <[email protected]> Co-authored-by: nickofthyme <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Justin Kambic <[email protected]>

elasticmachine · 2020-08-31T17:21:16Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

…elastic#76252)

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: spalger <[email protected]>

…#76278) * fix URI decoding and editing of a policy which backs up all indices * fix type issue * fix general use of encoding and update decode algo * fix serialisation of snapshots and added a test * Fix test description name * Update attempt_to_uri_decode.ts * catch errors from decoding in the already throwing code Co-authored-by: Elastic Machine <[email protected]>

…tic#76241)

…76259)

* Reconcile request helpers with eslint rules for React hooks. - Add clearer cleanup logic for unmounted components. - Align logic and comments in np_ready_request.ts and original request.ts. * Reorganize modules and convert tests to TS. - Split request.ts into send_request.ts and use_request.ts. - Convert test files into TS. - Relax SendRequestResponse type definition to type error as any instead of expecting an Error, since we weren't actually fulfilling this expectation. * Convert everything to hooks and add test coverage for request behavior. * Fix Watcher memoization bugs.

alisonelizabeth

Great work @yuliacech! I tested locally and did not find any regressions.

I left a few code comments. Also, regarding the use of any for indices - could you utilize this interface in index_management: https://github.com/elastic/kibana/blob/master/x-pack/plugins/index_management/server/types.ts#L29?

alisonelizabeth · 2020-08-31T19:16:06Z

...fecycle_management/public/extend_index_management/components/add_lifecycle_confirm_modal.tsx

+  selectedPolicyName: string;
+  selectedAlias: string;
+  policies: PolicyFromES[];
+  policyError?: string;


nit: might be more clear as policyErrorMessage. I know this was pre-existing, so feel free to ignore 😄

alisonelizabeth · 2020-08-31T19:18:12Z

...x_lifecycle_management/public/extend_index_management/components/index_lifecycle_summary.tsx

-        </EuiDescriptionListDescription>,
-      ];
+      const cell = (
+        <Fragment>


nit: you can also use <></> for fragments

alisonelizabeth · 2020-08-31T19:24:42Z

x-pack/plugins/index_lifecycle_management/public/extend_index_management/index.tsx

      }
    ),
  };
 };

-export const removeLifecyclePolicyActionExtension = ({ indices, reloadIndices }) => {
+export const removeLifecyclePolicyActionExtension = ({ indices, reloadIndices }: any) => {


At the very least, I think this could be improved to:

Suggested change

export const removeLifecyclePolicyActionExtension = ({ indices, reloadIndices }: any) => {

export const removeLifecyclePolicyActionExtension = ({ indices, reloadIndices }: {indices: any; reloadIndices: () => void}) => {

alisonelizabeth · 2020-08-31T19:29:04Z

x-pack/plugins/index_lifecycle_management/public/extend_index_management/index.tsx

 import { retryLifecycleForIndex } from '../application/services/api';
 import { IndexLifecycleSummary } from './components/index_lifecycle_summary';
 import { AddLifecyclePolicyConfirmModal } from './components/add_lifecycle_confirm_modal';
 import { RemoveLifecyclePolicyConfirmModal } from './components/remove_lifecycle_confirm_modal';

+// eslint-disable-next-line @kbn/eslint/no-restricted-paths
+import { ExtensionsSetup } from '../../../index_management/public/services';


I think if you export ExtensionsSetup from x-pack/plugins/index_management/public/index.ts you can remove the eslint-disable.

alisonelizabeth · 2020-08-31T19:52:16Z

...x_lifecycle_management/public/extend_index_management/components/index_lifecycle_summary.tsx

@@ -80,7 +98,7 @@ export class IndexLifecycleSummary extends Component {
  closePhaseExecutionPopover = () => {
    this.setState({ showPhaseExecutionPopover: false });
  };
-  renderStackPopoverButton(ilm) {
+  renderStackPopoverButton(ilm: any) {


can we avoid using any here?

alisonelizabeth · 2020-08-31T19:52:19Z

...x_lifecycle_management/public/extend_index_management/components/index_lifecycle_summary.tsx

-    if (!ilm.phase_execution) {
-      return null;
-    }
+  renderPhaseExecutionPopoverButton(ilm: any) {


can we avoid using any here?

* [Maps] fix duplicate ID's * tslint cleanup * use layer id instead of layer name for popover id * tslint fixes Co-authored-by: Elastic Machine <[email protected]>

…ert with invalid document. (elastic#75929)

…edHosts' to 'xpack.actions.allowedHosts' (elastic#76325)

* Add telemetry around workpad variable usage * Fix typecheck Co-authored-by: Elastic Machine <[email protected]>

…option. (elastic#76061) * Exposed separate from ProxySettings rejectUnauthorized configuration option. * Fixed type checks * fixed tests

* delete src/legacy/ui/public folder * remove jest.mock('ui/XXX'); from tests * adapt stubbedLogstashIndexPatternService * remove delete keys from translation files * fix types import with Capabilities * remove legacy test utils * remove dead file referencing ui/newPlatform * move saved-object-finder styles to timelion plugin

* chore: group tests doing the same This will reduce the time it takes to execute the tests * chore: rephrase step * chore: extract common code to a function Co-authored-by: Elastic Machine <[email protected]>

…6354)

…75537) * add intergration test for install prebuilt timelines * add integration tests * add functional test for export timeline * clean up * asserts the content of the exported timeline * update selector * update selector * reuses the timeline id from the expected exported file Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Gloria Hornero <[email protected]>

yuliacech · 2020-09-01T10:11:16Z

@elasticmachine merge upstream

* cleanup xpack_main legacy plugin, remove capabilities mixin * fix test env * delete injectXpackSignature and related tests

…ndex_management # Conflicts: # x-pack/plugins/snapshot_restore/public/application/lib/index.ts

yuliacech · 2020-09-01T10:27:56Z

@elasticmachine merge upstream

kibanamachine · 2020-09-01T10:35:46Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: e6e5939
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Build metrics

‼️ metrics were not reported for [#76308@e6e5939]

History

💚 Build #71354 succeeded 8ef8841

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

yuliacech and others added 3 commits August 31, 2020 18:55

[ILM] TS conversion of Index Management plugin extension

8ef8841

[ML] Remove "Are you sure" from filter lists (elastic#76180)

20cb816

yuliacech marked this pull request as ready for review August 31, 2020 17:19

yuliacech requested a review from a team as a code owner August 31, 2020 17:19

yuliacech added chore Feature:ILM release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.10.0 v8.0.0 labels Aug 31, 2020

yuliacech mentioned this pull request Aug 31, 2020

TypeScript conversion of Index Lifecycle Management plugin #74271

Closed

14 tasks

patrykkopycinski and others added 8 commits August 31, 2020 19:30

[Security Solution] Refactor FirstLastSeenHost to use Search Strategy (…

047c608

…elastic#76252)

Handle cloud test failures (elastic#74162)

7826246

Co-authored-by: Elastic Machine <[email protected]>

chore(NA): add elastic prefix to eslint-config-kibana (elastic#76059)

0068c87

Co-authored-by: Elastic Machine <[email protected]>

[canvas] remove unused file (elastic#76295)

1e5f5df

Co-authored-by: spalger <[email protected]>

[Security Solution] Refactor Network TLS to use Search Strategy (elas…

ef63dc8

…tic#76241)

replace /elasticsearch/_msearch usages with custom endpoint (elastic#…

325b82b

…76259)

alisonelizabeth reviewed Aug 31, 2020

View reviewed changes

nreese and others added 8 commits August 31, 2020 14:19

[Maps] fix duplicate EuiPopover id's (elastic#76202)

3dc2c70

* [Maps] fix duplicate ID's * tslint cleanup * use layer id instead of layer name for popover id * tslint fixes Co-authored-by: Elastic Machine <[email protected]>

Add cacheClear & cacheDelete methods (elastic#76306)

de9b7a4

Added validation to display an error when creating index action in al…

a8b2810

…ert with invalid document. (elastic#75929)

Added deprecation for renaming config option 'xpack.actions.whitelist…

08f9dcc

…edHosts' to 'xpack.actions.allowedHosts' (elastic#76325)

[Canvas] Add telemetry around workpad variable usage (elastic#75683)

7b807b7

* Add telemetry around workpad variable usage * Fix typecheck Co-authored-by: Elastic Machine <[email protected]>

Exposed separate from ProxySettings rejectUnauthorized configuration …

630d2d5

…option. (elastic#76061) * Exposed separate from ProxySettings rejectUnauthorized configuration option. * Fixed type checks * fixed tests

allow multiple registration of the same feature (elastic#76272)

086e488

mdelapenya and others added 3 commits September 1, 2020 10:10

[APM UI] Rephrase BDD steps for RUM scenarios (elastic#72492)

69461cc

* chore: group tests doing the same This will reduce the time it takes to execute the tests * chore: rephrase step * chore: extract common code to a function Co-authored-by: Elastic Machine <[email protected]>

restore dummy documentation_links.ts file to fix doc build (elastic#7…

ec1c158

…6354)

pgayvallet and others added 3 commits September 1, 2020 12:19

xpack_main legacy plugin pre-removal cleanup (elastic#76257)

d802bf0

* cleanup xpack_main legacy plugin, remove capabilities mixin * fix test env * delete injectXpackSignature and related tests

[ILM] TS conversion of Index Management plugin extension

6daf79f

Merge remote-tracking branch 'origin/ilm_index_management' into ilm_i…

283d74c

…ndex_management # Conflicts: # x-pack/plugins/snapshot_restore/public/application/lib/index.ts

yuliacech requested review from a team as code owners September 1, 2020 10:22

yuliacech requested a review from a team September 1, 2020 10:22

yuliacech requested a review from a team as a code owner September 1, 2020 10:22

yuliacech requested a review from a team September 1, 2020 10:22

yuliacech requested review from a team as code owners September 1, 2020 10:22

yuliacech requested a review from a team September 1, 2020 10:22

yuliacech requested a review from a team as a code owner September 1, 2020 10:22

Merge branch 'master' into ilm_index_management

e6e5939

yuliacech closed this Sep 1, 2020

yuliacech mentioned this pull request Sep 2, 2020

[ILM] TS conversion of Index Management plugin extension #76517

Merged

yuliacech deleted the ilm_index_management branch September 3, 2020 13:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ILM] TS conversion of Index Management plugin extension #76308

[ILM] TS conversion of Index Management plugin extension #76308

yuliacech commented Aug 31, 2020 •

edited

Loading

elasticmachine commented Aug 31, 2020

alisonelizabeth left a comment

alisonelizabeth Aug 31, 2020

alisonelizabeth Aug 31, 2020

alisonelizabeth Aug 31, 2020

alisonelizabeth Aug 31, 2020

alisonelizabeth Aug 31, 2020

alisonelizabeth Aug 31, 2020

yuliacech commented Sep 1, 2020

yuliacech commented Sep 1, 2020

kibanamachine commented Sep 1, 2020

	export const removeLifecyclePolicyActionExtension = ({ indices, reloadIndices }: any) => {
	export const removeLifecyclePolicyActionExtension = ({ indices, reloadIndices }: {indices: any; reloadIndices: () => void}) => {

[ILM] TS conversion of Index Management plugin extension #76308

[ILM] TS conversion of Index Management plugin extension #76308

Conversation

yuliacech commented Aug 31, 2020 • edited Loading

Summary

Todo

elasticmachine commented Aug 31, 2020

alisonelizabeth left a comment

Choose a reason for hiding this comment

alisonelizabeth Aug 31, 2020

Choose a reason for hiding this comment

alisonelizabeth Aug 31, 2020

Choose a reason for hiding this comment

alisonelizabeth Aug 31, 2020

Choose a reason for hiding this comment

alisonelizabeth Aug 31, 2020

Choose a reason for hiding this comment

alisonelizabeth Aug 31, 2020

Choose a reason for hiding this comment

alisonelizabeth Aug 31, 2020

Choose a reason for hiding this comment

yuliacech commented Sep 1, 2020

yuliacech commented Sep 1, 2020

kibanamachine commented Sep 1, 2020

💔 Build Failed

Failed CI Steps

Build metrics

History

yuliacech commented Aug 31, 2020 •

edited

Loading