This repository has been archived by the owner on May 24, 2022. It is now read-only.
Review comments for 208 #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
+ Coverage 61.72% 61.87% +0.15%
==========================================
Files 88 88
Lines 4345 4344 -1
==========================================
+ Hits 2682 2688 +6
+ Misses 1328 1324 -4
+ Partials 335 332 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
gentle ping @marcoguerri |
|
Sorry for the latency, trying to put out some urgent fires internally. Will tentatively allocate some time by EOD to review this. |
|
this was reverted and being reintroduced in #232 , i incorporated all the changes there. |
xaionaro
pushed a commit
to xaionaro-facebook/contest
that referenced
this pull request
Mar 12, 2021
With inter-step state serialization This is take 2, incorporating a fix for facebookarchive#228 and comments from facebookarchive#219 Modified by: Dmitrii Okunev <[email protected]>
xaionaro
pushed a commit
to xaionaro-facebook/contest
that referenced
this pull request
Mar 13, 2021
With inter-step state serialization This is take 2, incorporating a fix for facebookarchive#228 and comments from facebookarchive#219
llogen
pushed a commit
to 9elements/contest
that referenced
this pull request
Aug 4, 2021
With inter-step state serialization This is take 2, incorporating a fix for facebookarchive#228 and comments from facebookarchive#219
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review comments for #208 that was closed prematurely