This repository has been archived by the owner on May 24, 2022. It is now read-only.
test_runner: Unit test to highlight pipeline bug #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pipeline fails if the last step takes longer than the shutdown timeout. This test triggers that condition. Interestingly, it can fail in two different ways! A regular unit test failure like we saw testing, and also a full blown panic for senging on a closed channel :(
facebook-github-bot
added
the
CLA Signed
|
This is just to demonstrate the problem, no need to review/merge for now |
|
incorporated into #232 |
xaionaro
pushed a commit
to xaionaro-facebook/contest
that referenced
this pull request
Mar 12, 2021
With inter-step state serialization This is take 2, incorporating a fix for facebookarchive#228 and comments from facebookarchive#219 Modified by: Dmitrii Okunev <[email protected]>
xaionaro
pushed a commit
to xaionaro-facebook/contest
that referenced
this pull request
Mar 13, 2021
With inter-step state serialization This is take 2, incorporating a fix for facebookarchive#228 and comments from facebookarchive#219
llogen
pushed a commit
to 9elements/contest
that referenced
this pull request
Aug 4, 2021
With inter-step state serialization This is take 2, incorporating a fix for facebookarchive#228 and comments from facebookarchive#219
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipeline fails if the last step takes longer than the shutdown timeout.
This test triggers that condition. Interestingly, it can fail in two different ways!
A regular unit test failure like we saw testing, and also a full blown panic for senging on a closed channel :(