New TestRunner implementation #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With inter-step state serialization This is take 2, incorporating a fix for facebookarchive#228 and comments from facebookarchive#219
xaionaro
pushed a commit
that referenced
this pull request
Oct 26, 2021
When a target is already locked, the logs and status did not expose enough information about what is holding the lock. This commit adds such information. Tested by running two concurrent jobs. Server logs: ``` [2020-08-13T11:01:39+02:00] ERROR pkg/jobmanager: run #1: cannot fetch targets for test 'literal test': lock request: target already locked: Target{Name: "example.org", ID: "1234", FQDN: ""} (lock: {owner:68 lockedAt:{wall:13818554647487406031 ext:67386579246 loc:0xc8c420} expiresAt:{wall:13818554711911929595 ext:127386593370 loc:0xc8c420}}) ``` Status: ``` $ ./contestcli-http status 69 | jq '.Data.Status.StateErrMsg' Requesting URL http://localhost:8080/status with requestor ID 'contestcli-http' with params: requestor: [contestcli-http] jobID: [69] The server responded with status 200 OK"run #1: cannot fetch targets for test 'literal test': lock request: target already locked: Target{Name: \"example.org\", ID: \"1234\", FQDN: \"\"} (lock: {owner:68 lockedAt:{wall:13818554647487406031 ext:67386579246 loc:0xc8c420} expiresAt:{wall:13818554711911929595 ext:127386593370 loc:0xc8c420}})" ``` Signed-off-by: Andrea Barberio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With inter-step state serialization
This is take 2, incorporating a fix for facebookarchive#228 and comments from facebookarchive#219