DisplayList SaveLayer (and root layer) read-back flags #53104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It occurs to me that I need to forward the flags for the root layer of a child DL into the current layer in DrawDisplayList(). And the latest commit includes a fix and unit tests for this now... |
jonahwilliams
approved these changes
May 30, 2024
chingjun
pushed a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2024
…149357) flutter/engine@de07179...bf2e32d 2024-05-30 [email protected] DisplayList SaveLayer (and root layer) read-back flags (flutter/engine#53104) 2024-05-30 [email protected] Roll Skia from 7cfb0898ac15 to 188ad395c3e7 (2 revisions) (flutter/engine#53127) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (#53119)" (flutter/engine#53128) 2024-05-30 [email protected] Roll Skia from 75cf7d351b02 to 7cfb0898ac15 (3 revisions) (flutter/engine#53126) 2024-05-30 [email protected] Fuchsia api level 18 (flutter/engine#53115) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] enable Impeller by default on Android. (#53099)" (flutter/engine#53125) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Disable Impeller when the manifest explicitly disables it (#53108)" (flutter/engine#53124) 2024-05-30 [email protected] Roll Skia from eadc654480ed to 75cf7d351b02 (2 revisions) (flutter/engine#53120) 2024-05-30 [email protected] Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter/engine#53119) 2024-05-30 [email protected] add SemanticsAction.focus (flutter/engine#53094) 2024-05-30 [email protected] Roll Skia from 693d9362f0f6 to eadc654480ed (3 revisions) (flutter/engine#53117) 2024-05-30 [email protected] [Flutter GPU] Upload `flutter_gpu.zip` upon successful completion of ci/android_debug. (flutter/engine#53107) 2024-05-30 [email protected] Roll Skia from 949b8cefbf87 to 693d9362f0f6 (2 revisions) (flutter/engine#53114) 2024-05-30 [email protected] Disable Impeller when the manifest explicitly disables it (flutter/engine#53108) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#149357) flutter/engine@de07179...bf2e32d 2024-05-30 [email protected] DisplayList SaveLayer (and root layer) read-back flags (flutter/engine#53104) 2024-05-30 [email protected] Roll Skia from 7cfb0898ac15 to 188ad395c3e7 (2 revisions) (flutter/engine#53127) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter#53119)" (flutter/engine#53128) 2024-05-30 [email protected] Roll Skia from 75cf7d351b02 to 7cfb0898ac15 (3 revisions) (flutter/engine#53126) 2024-05-30 [email protected] Fuchsia api level 18 (flutter/engine#53115) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] enable Impeller by default on Android. (flutter#53099)" (flutter/engine#53125) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Disable Impeller when the manifest explicitly disables it (flutter#53108)" (flutter/engine#53124) 2024-05-30 [email protected] Roll Skia from eadc654480ed to 75cf7d351b02 (2 revisions) (flutter/engine#53120) 2024-05-30 [email protected] Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter/engine#53119) 2024-05-30 [email protected] add SemanticsAction.focus (flutter/engine#53094) 2024-05-30 [email protected] Roll Skia from 693d9362f0f6 to eadc654480ed (3 revisions) (flutter/engine#53117) 2024-05-30 [email protected] [Flutter GPU] Upload `flutter_gpu.zip` upon successful completion of ci/android_debug. (flutter/engine#53107) 2024-05-30 [email protected] Roll Skia from 949b8cefbf87 to 693d9362f0f6 (2 revisions) (flutter/engine#53114) 2024-05-30 [email protected] Disable Impeller when the manifest explicitly disables it (flutter/engine#53108) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
…53151) Use the flags in #53104 + context capabilities to determine if we need to begin the first pass as an offscreen. Part of flutter/flutter#142054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DisplayListBuilder now tracks the blend mode(s) used for its contents and whether it contains a child SaveLayer that uses a backdrop filter - both conditions that could require the graphics engine to use a different type of layer to satisfy the requests.
blend modes are tracked as the "highest" blend mode enum used by any content (defaults to kClear) as the enum values tend to be ordered so that larger values will tend to require more complicated render-target accesses.
The root layer of the DisplayList can be queried for both conditions on the root layer using methods on the DisplayList class.