Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fuchsia api level 18 #53115

Merged
merged 3 commits into from
May 30, 2024
Merged

Fuchsia api level 18 #53115

merged 3 commits into from
May 30, 2024

Conversation

jrwang
Copy link
Contributor

@jrwang jrwang commented May 30, 2024 •
edited
Loading

b/335285098

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

zijiehe-google-com
zijiehe-google-com approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@zijiehe-google-com zijiehe-google-com left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@jrwang jrwang merged commit f7fccbf into flutter:main May 30, 2024
26 checks passed
@jrwang jrwang deleted the fuchsia_api_level_18 branch May 30, 2024 18:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2024
@engine-flutter-autoroll
f7fccbf7f Fuchsia api level 18 (flutter/engine#53115)
e1cf4d1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2024
@engine-flutter-autoroll
f7fccbf7f Fuchsia api level 18 (flutter/engine#53115)
a795141
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2024
@engine-flutter-autoroll
f7fccbf7f Fuchsia api level 18 (flutter/engine#53115)
b27293f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2024
@engine-flutter-autoroll
f7fccbf7f Fuchsia api level 18 (flutter/engine#53115)
fe4a1df
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2024
Merged
chingjun pushed a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2024
@engine-flutter-autoroll @chingjun
f7fccbf7f Fuchsia api level 18 (flutter/engine#53115)
f043abd
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 30, 2024
@engine-flutter-autoroll
Roll Flutter Engine from de07179371f8 to bf2e32dfd5a2 (14 revisions) (#…
53ced2a 
…149357)

flutter/engine@de07179...bf2e32d

2024-05-30 [email protected] DisplayList SaveLayer (and root layer) read-back flags (flutter/engine#53104)
2024-05-30 [email protected] Roll Skia from 7cfb0898ac15 to 188ad395c3e7 (2 revisions) (flutter/engine#53127)
2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (#53119)" (flutter/engine#53128)
2024-05-30 [email protected] Roll Skia from 75cf7d351b02 to 7cfb0898ac15 (3 revisions) (flutter/engine#53126)
2024-05-30 [email protected] Fuchsia api level 18 (flutter/engine#53115)
2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] enable Impeller by default on Android. (#53099)" (flutter/engine#53125)
2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Disable Impeller when the manifest explicitly disables it (#53108)" (flutter/engine#53124)
2024-05-30 [email protected] Roll Skia from eadc654480ed to 75cf7d351b02 (2 revisions) (flutter/engine#53120)
2024-05-30 [email protected] Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter/engine#53119)
2024-05-30 [email protected] add SemanticsAction.focus (flutter/engine#53094)
2024-05-30 [email protected] Roll Skia from 693d9362f0f6 to eadc654480ed (3 revisions) (flutter/engine#53117)
2024-05-30 [email protected] [Flutter GPU] Upload `flutter_gpu.zip` upon successful completion of ci/android_debug. (flutter/engine#53107)
2024-05-30 [email protected] Roll Skia from 949b8cefbf87 to 693d9362f0f6 (2 revisions) (flutter/engine#53114)
2024-05-30 [email protected] Disable Impeller when the manifest explicitly disables it (flutter/engine#53108)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@engine-flutter-autoroll @victorsanni
Roll Flutter Engine from de07179371f8 to bf2e32dfd5a2 (14 revisions) (f…
1f1768c 
…lutter#149357)

flutter/engine@de07179...bf2e32d

2024-05-30 [email protected] DisplayList SaveLayer (and root layer) read-back flags (flutter/engine#53104)
2024-05-30 [email protected] Roll Skia from 7cfb0898ac15 to 188ad395c3e7 (2 revisions) (flutter/engine#53127)
2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter#53119)" (flutter/engine#53128)
2024-05-30 [email protected] Roll Skia from 75cf7d351b02 to 7cfb0898ac15 (3 revisions) (flutter/engine#53126)
2024-05-30 [email protected] Fuchsia api level 18 (flutter/engine#53115)
2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] enable Impeller by default on Android. (flutter#53099)" (flutter/engine#53125)
2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Disable Impeller when the manifest explicitly disables it (flutter#53108)" (flutter/engine#53124)
2024-05-30 [email protected] Roll Skia from eadc654480ed to 75cf7d351b02 (2 revisions) (flutter/engine#53120)
2024-05-30 [email protected] Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter/engine#53119)
2024-05-30 [email protected] add SemanticsAction.focus (flutter/engine#53094)
2024-05-30 [email protected] Roll Skia from 693d9362f0f6 to eadc654480ed (3 revisions) (flutter/engine#53117)
2024-05-30 [email protected] [Flutter GPU] Upload `flutter_gpu.zip` upon successful completion of ci/android_debug. (flutter/engine#53107)
2024-05-30 [email protected] Roll Skia from 949b8cefbf87 to 693d9362f0f6 (2 revisions) (flutter/engine#53114)
2024-05-30 [email protected] Disable Impeller when the manifest explicitly disables it (flutter/engine#53108)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zijiehe-google-com zijiehe-google-com zijiehe-google-com approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrwang @zijiehe-google-com