Reverts "Disable Impeller when the manifest explicitly disables it (#53108)" #53124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
auto-submit
bot
added
the
revert of
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
approved these changes
May 30, 2024
auto-submit
bot
deleted the
revert_8da25dc953a030551fe32b91d7ae4ec08c70760f
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
chingjun
pushed a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2024
…149357) flutter/engine@de07179...bf2e32d 2024-05-30 [email protected] DisplayList SaveLayer (and root layer) read-back flags (flutter/engine#53104) 2024-05-30 [email protected] Roll Skia from 7cfb0898ac15 to 188ad395c3e7 (2 revisions) (flutter/engine#53127) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (#53119)" (flutter/engine#53128) 2024-05-30 [email protected] Roll Skia from 75cf7d351b02 to 7cfb0898ac15 (3 revisions) (flutter/engine#53126) 2024-05-30 [email protected] Fuchsia api level 18 (flutter/engine#53115) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] enable Impeller by default on Android. (#53099)" (flutter/engine#53125) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Disable Impeller when the manifest explicitly disables it (#53108)" (flutter/engine#53124) 2024-05-30 [email protected] Roll Skia from eadc654480ed to 75cf7d351b02 (2 revisions) (flutter/engine#53120) 2024-05-30 [email protected] Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter/engine#53119) 2024-05-30 [email protected] add SemanticsAction.focus (flutter/engine#53094) 2024-05-30 [email protected] Roll Skia from 693d9362f0f6 to eadc654480ed (3 revisions) (flutter/engine#53117) 2024-05-30 [email protected] [Flutter GPU] Upload `flutter_gpu.zip` upon successful completion of ci/android_debug. (flutter/engine#53107) 2024-05-30 [email protected] Roll Skia from 949b8cefbf87 to 693d9362f0f6 (2 revisions) (flutter/engine#53114) 2024-05-30 [email protected] Disable Impeller when the manifest explicitly disables it (flutter/engine#53108) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#149357) flutter/engine@de07179...bf2e32d 2024-05-30 [email protected] DisplayList SaveLayer (and root layer) read-back flags (flutter/engine#53104) 2024-05-30 [email protected] Roll Skia from 7cfb0898ac15 to 188ad395c3e7 (2 revisions) (flutter/engine#53127) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter#53119)" (flutter/engine#53128) 2024-05-30 [email protected] Roll Skia from 75cf7d351b02 to 7cfb0898ac15 (3 revisions) (flutter/engine#53126) 2024-05-30 [email protected] Fuchsia api level 18 (flutter/engine#53115) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] enable Impeller by default on Android. (flutter#53099)" (flutter/engine#53125) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Disable Impeller when the manifest explicitly disables it (flutter#53108)" (flutter/engine#53124) 2024-05-30 [email protected] Roll Skia from eadc654480ed to 75cf7d351b02 (2 revisions) (flutter/engine#53120) 2024-05-30 [email protected] Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter/engine#53119) 2024-05-30 [email protected] add SemanticsAction.focus (flutter/engine#53094) 2024-05-30 [email protected] Roll Skia from 693d9362f0f6 to eadc654480ed (3 revisions) (flutter/engine#53117) 2024-05-30 [email protected] [Flutter GPU] Upload `flutter_gpu.zip` upon successful completion of ci/android_debug. (flutter/engine#53107) 2024-05-30 [email protected] Roll Skia from 949b8cefbf87 to 693d9362f0f6 (2 revisions) (flutter/engine#53114) 2024-05-30 [email protected] Disable Impeller when the manifest explicitly disables it (flutter/engine#53108) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #53108
Initiated by: jonahwilliams
Reason for reverting: Probably --no-enable-impeller isn't working
Original PR Author: jiahaog
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
After #53099, impeller is always enabled, even if the manifest disables it using
io.flutter.embedding.android.EnableImpeller.This PR causes it to respect the manifest value if it is explicitly disabled.
Fixes b/343603270
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.