[various] Clean up deprecated_member_use ignores
#6123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
added
override: no versioning needed
stuartmorgan
requested review from
jmagman,
bparrishMines,
yjbanov,
Hixie,
tarrinneal,
chunhtai,
domesticmouse and
gspencergoog
as code owners
github-actions
bot
added
p: web_benchmarks
p: flutter_markdown
p: flutter_image
p: rfw
|
Version/changelog exemptions: The only non comment/formatting change is updating the constraints of |
jmagman
approved these changes
Feb 14, 2024
stuartmorgan
added
the
autosubmit
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 15, 2024
flutter/packages@a864254...ef349be 2024-02-15 [email protected] [url_launcher] Replace deprecated RouteInformation APIs (flutter/packages#6127) 2024-02-15 [email protected] [rfw] Replace deprecated `textScaleFactor` (flutter/packages#6130) 2024-02-15 [email protected] [flutter_adaptive_scaffold] Replace deprecated APIs (flutter/packages#6129) 2024-02-14 [email protected] Roll Flutter from eb5d0a4 to a628814 (72 revisions) (flutter/packages#6118) 2024-02-14 [email protected] [flutter_migrate] Replace deprecated APIs (flutter/packages#6128) 2024-02-14 [email protected] [flutter_image] Replace deprecated APIs (flutter/packages#6126) 2024-02-14 [email protected] [tools] Ignore analysis options files in .symlinks (flutter/packages#6119) 2024-02-14 [email protected] [various] Clean up `deprecated_member_use` ignores (flutter/packages#6123) 2024-02-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.0 to 3.24.1 (flutter/packages#6121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
As of flutter#6111 `deprecated_member_use` is no longer on in the repository, so we no longer need (most; see below) of these annotations. Since we will not be annotating deprecated usage going forward, the associated comments with TODOs have also been removed, for consistency with the new process. This also opportunistically removes `deprecated_member_use_from_same_package` everywhere, since that has been disabled for a long time, so they were cruft. I have ensured that issues are filed for all of these usages, with the new `p: deprecated api` tag, per the new process for tracking deprecated APIs that is now described in the Ecosystem gardener rotation handbook. (In summary: there will be a manual weekly process of checking for new deprecations and filing them, and the [update-stable-in-this-repo process](https://github.com/flutter/flutter/wiki/Updating-Packages-repo-for-a-stable-release) will involve causing anything that is unblocked to be re-triaged.) The only annotations that are left are for cases where we have integration tests testing deprecated APIs in that package, as those are false positives; they are conceptually `deprecated_member_use_from_same_package` and aren't tech debt (or used by clients), but technically are from a different package since integration tests are in the example app. This will prevent them from showing up in the manual weekly check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #6111
deprecated_member_useis no longer on in the repository, so we no longer need (most; see below) of these annotations. Since we will not be annotating deprecated usage going forward, the associated comments with TODOs have also been removed, for consistency with the new process. This also opportunistically removesdeprecated_member_use_from_same_packageeverywhere, since that has been disabled for a long time, so they were cruft.I have ensured that issues are filed for all of these usages, with the new
p: deprecated apitag, per the new process for tracking deprecated APIs that is now described in the Ecosystem gardener rotation handbook. (In summary: there will be a manual weekly process of checking for new deprecations and filing them, and the update-stable-in-this-repo process will involve causing anything that is unblocked to be re-triaged.)The only annotations that are left are for cases where we have integration tests testing deprecated APIs in that package, as those are false positives; they are conceptually
deprecated_member_use_from_same_packageand aren't tech debt (or used by clients), but technically are from a different package since integration tests are in the example app. This will prevent them from showing up in the manual weekly check.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).