Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[url_launcher] Replace deprecated RouteInformation APIs #6127

Merged

Conversation

stuartmorgan
Copy link
Contributor

Update for
https://docs.flutter.dev/release/breaking-changes/route-information-uri and makes 3.13 the minimum supported version accordingly.

Fixes flutter/flutter#124045

Pre-launch Checklist

@stuartmorgan
Copy link
Contributor Author

This should be a no-op functionally, since the first non-assert code in the called method is uri ??= Uri.parse(location!); and that's the only use of location, so we're just doing the same thing the method would do with the deprecated param.

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!!

(How did this surface? did we add some new lints, or did that SystemNavigatorApi get deprecated recently?)

@stuartmorgan
Copy link
Contributor Author

It was surfaced at deprecation time by the deprecated_member_use lint; there's just no longer an annotation here due to #6123 and #6111

Now that we no longer have that lint, there's a manual process for tracking deprecations instead (at least for now; TBD if Flutter-wide tooling will be built), and so I'm doing a quick sprint to clean up the ones I can easily fix now to reduce the scope of the manual tracking.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 15, 2024
@auto-submit auto-submit bot merged commit ef349be into flutter:main Feb 15, 2024
79 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 15, 2024
flutter/packages@a864254...ef349be

2024-02-15 [email protected] [url_launcher] Replace deprecated RouteInformation APIs (flutter/packages#6127)
2024-02-15 [email protected] [rfw] Replace deprecated `textScaleFactor` (flutter/packages#6130)
2024-02-15 [email protected] [flutter_adaptive_scaffold] Replace deprecated APIs (flutter/packages#6129)
2024-02-14 [email protected] Roll Flutter from eb5d0a4 to a628814 (72 revisions) (flutter/packages#6118)
2024-02-14 [email protected] [flutter_migrate] Replace deprecated APIs (flutter/packages#6128)
2024-02-14 [email protected] [flutter_image] Replace deprecated APIs (flutter/packages#6126)
2024-02-14 [email protected] [tools] Ignore analysis options files in .symlinks (flutter/packages#6119)
2024-02-14 [email protected] [various] Clean up `deprecated_member_use` ignores (flutter/packages#6123)
2024-02-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.0 to 3.24.1 (flutter/packages#6121)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: url_launcher
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[go_router][url_launcher] migrate deprecated RouteInformation.location usage
2 participants