Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rfw] Replace deprecated textScaleFactor #6130

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Feb 14, 2024

Replaces the deprecated textScaleFactor with a linear TextScaler.

Updates the minimum deployment version to 3.16 where the new API was added.

Part of flutter/flutter#143400

Pre-launch Checklist

Replaces the deprecated `textScaleFactor` with a linear `TextScaler`.

Updates the minimum deployment version to 3.13 where the new API was
added.

Part of flutter/flutter#143400
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan
Copy link
Contributor Author

test-exempt: code refactor with no semantic change

@github-actions github-actions bot added the p: rfw Remote Flutter Widgets label Feb 14, 2024
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM

@Hixie
Copy link
Contributor

Hixie commented Feb 14, 2024

Not sure why the analyzer doesn't like it though.

@stuartmorgan
Copy link
Contributor Author

Huh, I was trusting the deprecation message that said This feature was deprecated after v3.12.0-2.0.pre. which should have put that change in 3.13. But looking at the official breaking change docs it was in 3.16 rather than 3.13. 🤷🏻

I'll update the PR to rev the min supported version up to 3.16 instead. Legacy analysis bots FTW!

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 15, 2024
@auto-submit auto-submit bot merged commit 4035b62 into flutter:main Feb 15, 2024
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 15, 2024
flutter/packages@a864254...ef349be

2024-02-15 [email protected] [url_launcher] Replace deprecated RouteInformation APIs (flutter/packages#6127)
2024-02-15 [email protected] [rfw] Replace deprecated `textScaleFactor` (flutter/packages#6130)
2024-02-15 [email protected] [flutter_adaptive_scaffold] Replace deprecated APIs (flutter/packages#6129)
2024-02-14 [email protected] Roll Flutter from eb5d0a4 to a628814 (72 revisions) (flutter/packages#6118)
2024-02-14 [email protected] [flutter_migrate] Replace deprecated APIs (flutter/packages#6128)
2024-02-14 [email protected] [flutter_image] Replace deprecated APIs (flutter/packages#6126)
2024-02-14 [email protected] [tools] Ignore analysis options files in .symlinks (flutter/packages#6119)
2024-02-14 [email protected] [various] Clean up `deprecated_member_use` ignores (flutter/packages#6123)
2024-02-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.0 to 3.24.1 (flutter/packages#6121)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Replaces the deprecated `textScaleFactor` with a linear `TextScaler`.

Updates the minimum deployment version to 3.16 where the new API was added.

Part of flutter/flutter#143400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: rfw Remote Flutter Widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants