Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] fix "autoConsume" param in "buyConsumable" #3957

Merged
merged 4 commits into from
Jun 2, 2021
Merged

[in_app_purchase] fix "autoConsume" param in "buyConsumable" #3957

merged 4 commits into from
Jun 2, 2021

Conversation

qwert2603
Copy link
Contributor

@qwert2603 qwert2603 commented May 21, 2021 •
edited
Loading

Fix ignoring "autoConsume" param in "InAppPurchase.instance.buyConsumable".

Fixes flutter/flutter#83035

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label May 21, 2021
@qwert2603 qwert2603 marked this pull request as ready for review May 21, 2021 16:03
@qwert2603
Copy link
Contributor Author

Hello! Do I need to update CHANGELOG.md or version in pubspec.yaml for these changes?

@mvanbeusekom
Copy link
Contributor

Hello! Do I need to update CHANGELOG.md or version in pubspec.yaml for these changes?

Hi @qwert2603, thank you for the pull-request. The changes look good, but yes please also update the CHANGELOG.md and the pubspec.yaml. You can update to version 1.0.1.

mvanbeusekom
mvanbeusekom suggested changes May 25, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a small merge conflict on the pubspec.yaml. Could you please rebase your branch with the master branch and update the PR?

Otherwise the PR looks good and I can merge it when the conflict is resolved. And thank you for contributing.

@qwert2603
Copy link
Contributor Author

@mvanbeusekom merge conflict resolved. Thanks for review :)

mvanbeusekom
mvanbeusekom approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 25, 2021
@mvanbeusekom
Copy link
Contributor

Thank you @qwert2603. I have approved the PR and added the wait for tree to go green label. This should merge your PR automatically if all CI tasks are ran successfully.

@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows Plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 25, 2021
@stuartmorgan
Copy link
Contributor

I've filed an infra bug about the Windows issue, which is unrelated to this PR. I'll update here once it's resolved.

@stuartmorgan
Copy link
Contributor

Apologies, but another change that updated the version to 1.0.1 landed in the meantime. Could you update this to 1.0.2 in the pubspec and CHANGELOG? Once that's done I can land this.

@qwert2603 qwert2603 closed this May 27, 2021
@qwert2603 qwert2603 reopened this May 27, 2021
@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 27, 2021
@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: no and removed cla: yes labels Jun 1, 2021
@ditman

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 1, 2021
@ditman
Copy link
Member

ditman commented Jun 2, 2021

I've rebased this PR, I should be able to land + publish in a few hours.

@ditman ditman merged commit c1c4653 into flutter:master Jun 2, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 2, 2021
@engine-flutter-autoroll
c1c4653 [in_app_purchase] fix "autoConsume" param in "buyConsumable" (f…
4ce7f35 
…lutter/plugins#3957)
@ditman
Copy link
Member

ditman commented Jun 2, 2021

https://pub.dev/packages/in_app_purchase/changelog#102

fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jun 2, 2021
@engine-flutter-autoroll
c1c4653 [in_app_purchase] fix "autoConsume" param in "buyConsumable" (f…
d9dfe38 
…lutter/plugins#3957) (#83760)
yasargil added a commit to yasargil/plugins that referenced this pull request Jun 2, 2021
@yasargil
Merge branch 'master' into gmain
9d6ff71 
* master: (131 commits)
  [in_app_purchase] fix "autoConsume" param in "buyConsumable" (flutter#3957)
  [video_player_web] fix: set autoplay to false during initialization (flutter#3985)
  [multiple_web] Adapt web PlatformView widgets to work slotted. (flutter#3964)
  [url_launcher] Add iOS unit and UI tests (flutter#3987)
  [image_picker] Change storage location for camera captures to internal cache on Android, to comply with new Google Play storage requirements.  (flutter#3956)
  [script/tool] Use 'dart pub' instead of deprecated 'pub' (flutter#3991)
  [video_player] Add iOS unit and UI tests (flutter#3986)
  Add pubspec convention checks (flutter#3984)
  Enable pubspec dependency sorting lint (flutter#3983)
  [image_picker] Migrate maven repo from jcenter to mavenCentral (flutter#3915)
  [video_player] Update README.md (flutter#3975)
  [script/tool] speed up the pub get portion of the analyze command (flutter#3982)
  Revert commit e742a7b (flutter#3976)
  Added support to request list of purchases (flutter#3944)
  [google_maps_flutter] Add iOS unit and UI tests (flutter#3978)
  Added Windows to the description (flutter#3936)
  use 'flutter pub get' for both dart and flutter packages (flutter#3973)
  [camera] android-rework part 3: Android exposure related features (flutter#3797)
  Remove exoplayer workaround from everything but video_player (flutter#3980)
  Allow reverts when checking versions (flutter#3981)
  ...
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@qwert2603 @fotiDim
[in_app_purchase] fix "autoConsume" param in "buyConsumable" (flutter…
903de6d 
…#3957)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@LHLL LHLL Awaiting requested review from LHLL

Assignees
No one assigned
Labels
cla: yes p: in_app_purchase waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[in_app_purchase] "buyConsumable" ignores "autoConsume" param
5 participants
@qwert2603 @mvanbeusekom @fluttergithubbot @stuartmorgan @ditman