Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[multiple_web] Adapt web PlatformView widgets to work slotted. #3964

Merged
merged 8 commits into from
Jun 1, 2021
Merged

[multiple_web] Adapt web PlatformView widgets to work slotted. #3964

merged 8 commits into from
Jun 1, 2021

Conversation

ditman
Copy link
Member

@ditman ditman commented May 22, 2021 •
edited
Loading

Similarly to flutter/packages#364, this PR adapts the HtmlElementView-based web plugins to the new incoming changes in master:

  • Ensure HtmlElementView root is 100% width/height of the space allocated by the framework.

(Part of flutter/flutter#80524)

And opportunistically fixes some issues "while we're there":

  • URL Launcher:
    • Add a Link widget to the example app (there used to be an issue, can't find it)
  • Video Player:
  • Google Maps:
    • Endorse web plugin: Removed because of problems in the google_maps_flutter integration tests, that need some extra code to work on the Web.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label May 22, 2021
@ditman ditman changed the title [multiple] Adapt the web PlatformView-based widgets to the new framework. [multiple] Adapt web PlatformView widgets to work as SLOTS. May 22, 2021
@ditman ditman changed the title [multiple] Adapt web PlatformView widgets to work as SLOTS. [multiple] Adapt web PlatformView widgets to work slotted. May 22, 2021
@ditman ditman force-pushed the shadow_dom_tweaks branch 2 times, most recently from bc1ae80 to 4a74560 Compare May 27, 2021 00:59
@ditman ditman requested a review from stuartmorgan May 27, 2021 18:56
@ditman ditman changed the title [multiple] Adapt web PlatformView widgets to work slotted. [multiple_web] Adapt web PlatformView widgets to work slotted. May 27, 2021
@ditman ditman marked this pull request as ready for review May 27, 2021 18:57
@ditman ditman requested a review from cyanglaz as a code owner May 27, 2021 18:57
@stuartmorgan
Copy link
Contributor

Video Player:

You'll need to update .cirrus.yml; this test wasn't actually run:

running drive-examples --web --exclude file_selector,image_picker_for_web,shared_preferences_web,video_player_web

@ditman
Copy link
Member Author

ditman commented May 27, 2021 •
edited
Loading

You'll need to update .cirrus.yml; this test wasn't actually run:

Thanks for pointing me to that @stuartmorgan! I wasn't aware of that variable. I've removed video_player_web from there, tests should have run now.

Edit: They did!

stuartmorgan
stuartmorgan approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/video_player/video_player_web/example/README.md Show resolved Hide resolved
@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 28, 2021
@ditman ditman merged commit 004485c into flutter:master Jun 1, 2021
@ditman ditman deleted the shadow_dom_tweaks branch June 1, 2021 22:21
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 1, 2021
@engine-flutter-autoroll
004485c [multiple_web] Adapt web PlatformView widgets to work slotted. (
663b60f 
flutter/plugins#3964)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jun 1, 2021
@engine-flutter-autoroll
004485c [multiple_web] Adapt web PlatformView widgets to work slotted. (
9c0dd6f 
flutter/plugins#3964) (#83747)
yasargil added a commit to yasargil/plugins that referenced this pull request Jun 2, 2021
@yasargil
Merge branch 'master' into gmain
9d6ff71 
* master: (131 commits)
  [in_app_purchase] fix "autoConsume" param in "buyConsumable" (flutter#3957)
  [video_player_web] fix: set autoplay to false during initialization (flutter#3985)
  [multiple_web] Adapt web PlatformView widgets to work slotted. (flutter#3964)
  [url_launcher] Add iOS unit and UI tests (flutter#3987)
  [image_picker] Change storage location for camera captures to internal cache on Android, to comply with new Google Play storage requirements.  (flutter#3956)
  [script/tool] Use 'dart pub' instead of deprecated 'pub' (flutter#3991)
  [video_player] Add iOS unit and UI tests (flutter#3986)
  Add pubspec convention checks (flutter#3984)
  Enable pubspec dependency sorting lint (flutter#3983)
  [image_picker] Migrate maven repo from jcenter to mavenCentral (flutter#3915)
  [video_player] Update README.md (flutter#3975)
  [script/tool] speed up the pub get portion of the analyze command (flutter#3982)
  Revert commit e742a7b (flutter#3976)
  Added support to request list of purchases (flutter#3944)
  [google_maps_flutter] Add iOS unit and UI tests (flutter#3978)
  Added Windows to the description (flutter#3936)
  use 'flutter pub get' for both dart and flutter packages (flutter#3973)
  [camera] android-rework part 3: Android exposure related features (flutter#3797)
  Remove exoplayer workaround from everything but video_player (flutter#3980)
  Allow reverts when checking versions (flutter#3981)
  ...
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@ditman @fotiDim
[multiple_web] Adapt web PlatformView widgets to work slotted. (flutt…
827cadb 
…er#3964)

* [url_launcher_web] Make Link take 100% width/height of the PlatformView.
* [google_maps_flutter_web] Make Map take 100% width/height of the PlatformView.
* [video_player_web] Make Video take 100% width/height of the PlatformView.
* [video_player_web] Move tests to integration_test style so they run in CI.
* [url_launcher] Add link example
@abnerh69
Copy link

Is this chat still opened? I am trying to avoid reload of iframe url using master/stable channel but can't make it works with slot like you said. Please, help!

@stuartmorgan
Copy link
Contributor

@abnerh69 This isn't a chat, it's a resolved pull request. Try https://flutter.dev/community#community-grid for help with your code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
cla: yes p: google_maps_flutter p: url_launcher p: video_player platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ditman @stuartmorgan @abnerh69