Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player_web] fix: set autoplay to false during initialization #3985

Merged
merged 3 commits into from
Jun 1, 2021
Merged

[video_player_web] fix: set autoplay to false during initialization #3985

merged 3 commits into from
Jun 1, 2021

Conversation

felangel
Copy link
Contributor

@felangel felangel commented May 27, 2021 •
edited by ditman
Loading

Set autoplay to false during web video initialization to address issues of video not playing in Chrome and Safari on iOS. Tested on both iOS Chrome and Safari and the fix appears to work.

List which issues are fixed by this PR. You must list at least one issue.

Part of: flutter/flutter#47030

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label May 27, 2021
@felangel felangel mentioned this pull request May 27, 2021
Open
@ditman ditman self-requested a review May 27, 2021 21:42
ditman
ditman approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (I've removed the "Closes" link, until people in that ticket verify that this actually fixes their issues)

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 1, 2021
@ditman ditman merged commit 93d6791 into flutter:master Jun 1, 2021
@felangel felangel deleted the fix/video-player-web-autoplay branch June 1, 2021 22:53
@felangel felangel restored the fix/video-player-web-autoplay branch June 1, 2021 22:53
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 2, 2021
@engine-flutter-autoroll
93d6791 [video_player_web] fix: set autoplay to false during initiali…
c8fdcbb 
…zation (flutter/plugins#3985)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jun 2, 2021
@engine-flutter-autoroll
93d6791 [video_player_web] fix: set autoplay to false during initiali…
6858b25 
…zation (flutter/plugins#3985) (#83756)
yasargil added a commit to yasargil/plugins that referenced this pull request Jun 2, 2021
@yasargil
Merge branch 'master' into gmain
9d6ff71 
* master: (131 commits)
  [in_app_purchase] fix "autoConsume" param in "buyConsumable" (flutter#3957)
  [video_player_web] fix: set autoplay to false during initialization (flutter#3985)
  [multiple_web] Adapt web PlatformView widgets to work slotted. (flutter#3964)
  [url_launcher] Add iOS unit and UI tests (flutter#3987)
  [image_picker] Change storage location for camera captures to internal cache on Android, to comply with new Google Play storage requirements.  (flutter#3956)
  [script/tool] Use 'dart pub' instead of deprecated 'pub' (flutter#3991)
  [video_player] Add iOS unit and UI tests (flutter#3986)
  Add pubspec convention checks (flutter#3984)
  Enable pubspec dependency sorting lint (flutter#3983)
  [image_picker] Migrate maven repo from jcenter to mavenCentral (flutter#3915)
  [video_player] Update README.md (flutter#3975)
  [script/tool] speed up the pub get portion of the analyze command (flutter#3982)
  Revert commit e742a7b (flutter#3976)
  Added support to request list of purchases (flutter#3944)
  [google_maps_flutter] Add iOS unit and UI tests (flutter#3978)
  Added Windows to the description (flutter#3936)
  use 'flutter pub get' for both dart and flutter packages (flutter#3973)
  [camera] android-rework part 3: Android exposure related features (flutter#3797)
  Remove exoplayer workaround from everything but video_player (flutter#3980)
  Allow reverts when checking versions (flutter#3981)
  ...
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@felangel @fotiDim
[video_player_web] fix: set autoplay to false during initialization (f…
a8d818f 
…lutter#3985)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
cla: yes p: video_player platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felangel @ditman