This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Attempt to fix flaky new Android test #6831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recently added "recording with image stream" test is very flaky, often throwing on `stop`. This is a speculative fix for that flake based on the documentation of `stop` indicating that it will throw if nothing has been recorded.
|
I'll run this in presubmit a few times to see if it passes reliably before proceeding. |
11 tasks
|
I've done three runs (two master, one stable), and all three passed on both devices. I checked the logs and they never did the internal one-time deflake re-run either. That's much better than what we've been seeing in CI since it landed, so this looks very promising. I'll do one more run of each, but I think we can go ahead and land this. |
|
Landing on red since the red since the red is the flake that it looks (🤞🏻) like this fixes. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 13, 2022
* 13818023c [camera] Attempt to fix flaky new Android test (flutter/plugins#6831) * da4321d01 [google_maps_flutter] Modified `README.md` to fix minor syntax issues (flutter/plugins#6631) * e8c9731f1 Roll Flutter from eefbe85 to bd0791b (25 revisions) (flutter/plugins#6832) * 2eb616545 Reland "[google_maps_flutter] ios: re-enable test with popup #5312" (flutter/plugins#6783) * 738bd91d8 Update FlutterFire link (flutter/plugins#6835) * ec2041f82 Roll Flutter from bd0791b to 15af817 (27 revisions) (flutter/plugins#6837)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#116996) * 13818023c [camera] Attempt to fix flaky new Android test (flutter/plugins#6831) * da4321d01 [google_maps_flutter] Modified `README.md` to fix minor syntax issues (flutter/plugins#6631) * e8c9731f1 Roll Flutter from eefbe85 to bd0791b (25 revisions) (flutter/plugins#6832) * 2eb616545 Reland "[google_maps_flutter] ios: re-enable test with popup flutter#5312" (flutter/plugins#6783) * 738bd91d8 Update FlutterFire link (flutter/plugins#6835) * ec2041f82 Roll Flutter from bd0791b to 15af817 (27 revisions) (flutter/plugins#6837)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
The recently added "recording with image stream" test is very flaky, often throwing on `stop`. This is a speculative fix for that flake based on the documentation of `stop` indicating that it will throw if nothing has been recorded.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently added "recording with image stream" test is very flaky, often throwing on
stop. This is a speculative fix for that flake based on the documentation ofstopindicating that it will throw if nothing has been recorded.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).