Revert "fix: journals as invoice throwing validation error" (backport #…

…1192) (#1194) This reverts commit 50eaaca. (cherry picked from commit 1bcc636) Co-authored-by: ruthra kumar <[email protected]>
frappe · Dec 19, 2023 · 71913e8 · 71913e8
1 parent ed63f5a
commit 71913e8
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/hrms/overrides/employee_payment_entry.py b/hrms/overrides/employee_payment_entry.py
@@ -42,7 +42,7 @@ def set_missing_ref_details(
 				)
 
 				for field, value in ref_details.items():
-					if d.exchange_gain_loss is not None:
+					if d.exchange_gain_loss:
 						# for cases where gain/loss is booked into invoice
 						# exchange_gain_loss is calculated from invoice & populated
 						# and row.exchange_rate is already set to payment entry's exchange rate