Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Meeting Notes November 15, 2019

Jump to bottom
Jim Ciallella edited this page Dec 9, 2019 · 8 revisions

Before you dive into the notes, please make sure you have read the following:

Agenda

  • Intros
  • Demos
  • Assigning Issues and PRs

In Attendance

Design Demo

  • vkWeb and Madalena shared their work on the Figma mockups
  • Quincy suggested other views, like "My Events", for the MVP

Authentication

  • Questions were raised about if we're going to use more than Google and email sign-up.
  • Quincy said in his freeCodeCamp experience he's found people forget what they used if there are too many 3rd party auth options.
  • Quincy suggested fewer auth options to start because of the extra support and confusion when people forget.
  • Nikhil suggested the database be built to allow for multiple providers. Others confirmed the schema is already built with this in mind.
  • The MVP will only offer Google authentication and no stand-alone email authentication.

Review of Issues and PRs

Quincy lead through the open issues and PRs to see about closing these or assigning reviewers.

  • #166
    • We talked about using hooks and class components. Nikhil asked if we should use the older class components vs function components w/ Hooks.
    • React 16.8 introduced life-cycle hooks. Classes have not been retired, but the newer hooks are a direction forward in React.
    • Hooks are believed to be more performant, cleaner / shorter, and more readable.
    • Material UI has transition to 100% hooks
    • Class components can still be used if hooks aren't performant enough, or if there's another reason to avoid hooks.
    • Nikhil said we also need to decide on useSelector or useDispatch, as raised by Zeko369.
    • Timmy Chen shared #123 which confirmed the support of hooks
    • Jacob Bogers said React hooks also improves some flicker effects
    • Quincy put a call for a vote from those who have a technical opinion and Hooks got all the votes as the default pattern.
    • Resolution: Hooks are the norm and classes can still be used when needed
    • #166 had a vote on Thunk vs Redux. Thunk won. Quincy said since Fran @Zeko369 is the reviewer that he should talk with @Shub1427 and make the final decision.
  • #162
    • we need to build in relationships and convert to snake_case
    • Fran is going to help with it and Quincy said Fran will be the final reviewer on the PR
  • #161
    • Fran has had trouble with both sequelize-cli and sequelize-cli-typescript
    • There's been issues related to Babel.
    • Quincy said he knows the creator of Babel and can ask for help.
    • Fran suggested converting to Typescript and compiling it down to ES 6
    • Nikhil offered to help and be a reviewer.
  • #159
    • Layout work that hasn't been updated in 10 days
    • Arial and Nikhil offered to help be a reviewer
  • #146 - Jacob was set as the reviewer
  • #140
  • #139 - Timmy is the primary and Fran will be the reviewer
  • Cecilia asked what we could do to help new developers get familiar the codebase. Quincy suggested people can use the existing fCC Twitch.tv streaming account to livestream their work and/or watching other developers' streams.
  • #169
    • Quincy prefers to look at the PRs for who is contributing and doesn't see a need, at least now, for a core team and more hierarchy and "status" positions
    • Timmy suggested issues be more clearly labeled as to-dos (e.g. client-side work should include mocks/etc)
    • Timmy suggested we close stale PRs (e.g. older than 7 days)
  • #40 - Quincy closed it because it's on the roadmap, but we will get to it after the MVP
  • "On the Roadmap" Github tag was removed and only "Roadmap" is now used
  • #11 - there is now a Discord #introductions channel
  • We talked about the Discord channel re-organizations
    • The README has been updated to send Discord visitors directly to the new #welcome channel, which has a read-only welcome message.
    • It was suggested to move the UI Discord into a channel in the main Discord and Timmy has setup #design
    • Jim (allella) will continue to triage newbies in any channel and we can add a channel for basic questions only if/as the volume dictates a need.
    • As we've already been doing, when we get random (not about Chapter) questions in Discord or Github, then we'll try to help the person, rather than just telling them "you're in the wrong place"
  • #23 - Quincy suggested as few services as possible
  • For inactive, general issues Quincy suggested putting a "Roadmap" label on it so we can look back at these issues after the MVP
  • #21 - Quincy said we'd start with English for the MVP and will add an internationalization package afterwards
  • #36 - Added a Roadmap tag and closed
  • #44 - For the MVP we'll accept a Google Analytics. In the future we'll have a textarea to allow people to enter in their own header and footer snippets, like used on Ghost.
  • Kudos to Sonicrida for organizing the Discord channels

Wiki Documentation

  • The #47 Roadmap has a task to create documentation in the Wiki.
  • Chris (not present) has lead the earlier documentation and seemed interested to continue in that role.
  • Jim offered to help review documentation.
  • Quincy suggested stubbing out the documentation even before there is a working app so we are thinking through the problems.

Next Meeting

  • We have already sent out a calendar invite for 2 weeks from now on Sat Nov 30, 2019 1:30pm – 2:30pm Eastern Time - New York

Documentation Topics

Meeting Notes

Clone this wiki locally