Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jest): update dependencies, update config #7872

Merged
merged 6 commits into from
Sep 17, 2018
Merged

chore(jest): update dependencies, update config #7872

merged 6 commits into from
Sep 17, 2018

Conversation

azdanov
Copy link
Contributor

@azdanov azdanov commented Sep 4, 2018

Repeat of #7434.

@azdanov
Copy link
Contributor Author

azdanov commented Sep 4, 2018

I have issues when upgrading to jest "jest": "^23.5.0" and "jest-cli": "^23.5.0".

Snapshot Summary
 › 53 snapshots failed from 5 test suites. Inspect your code changes or run `npm run jest -- -u` to update them.

Test Suites: 5 failed, 81 passed, 86 total
Tests:       53 failed, 559 passed, 612 total
Snapshots:   53 failed, 233 passed, 286 total
Time:        25.248s
Ran all test suites.

@azdanov azdanov changed the title chore(jest): remove redundancies from jest.config chore(jest): update dependencies, update config Sep 4, 2018
@azdanov
Copy link
Contributor Author

azdanov commented Sep 4, 2018

I've updated jest and jest-cli. Tests should fail since something is different with snapshots. Need a manual review of the differences.

If it's safe I will push an updated version of snapshots.

@pieh
Copy link
Contributor

pieh commented Sep 4, 2018

I think it's safe to update snapshots - it seems as result of this change in jest jestjs/jest#6244 which added results to spied/mocked function snapshots (in addition to calls that were there earlier)

@azdanov
Copy link
Contributor Author

azdanov commented Sep 5, 2018

@pieh Thanks for heads up!

I've updated all the snapshots.

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks @azdanov 🎉

* master: (50 commits)
  [v2] [gatsby-plugin-offline] fix: improve service worker initial caching (#8183)
  Fix typos on "Creating Global Styles" page (#8197)
  Fix my name on v2 blog post (#8196)
  Updating Hopper and adding Narative built_by (#8180)
  correct my English name (#8179)
  Change blog post path
  chore(release): Publish
  Add v2 release blog post (#8171)
  [www] Fix appearance of first-level sidebar nav items that link to a page and contain subitems (#8170)
  Offline plugin fetch error (#8158)
  Add Nike Just Do It & Hopper to site showcase (#8168)
  fix autolink-headers for in page hash navigation (#8154)
  fix ToC links in migration guide (#8157)
  [www] Fix header background for paginated "Blog" pages (#8042)
  [www][docs] Fix link to "Optimize Prefetching with Guess.js" (#8137)
  [v2] [scripts] feat: create build-examples script and fix some examples (#8130)
  Small updates to next.gatsbyjs.org (#8134)
  Update headless-cms.md (#8072)
  Update creating-dynamically-rendered-navigation.md (#7823)
  Site Showcase - new featured sites and edited tags (#8133)
  ...

# Conflicts:
#	jest.config.js
#	yarn.lock
@m-allanson m-allanson merged commit b36a051 into gatsbyjs:master Sep 17, 2018
@stefanprobst stefanprobst mentioned this pull request Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants