Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartsim-plugin windows build fixes #148

Merged
merged 3 commits into from
Nov 3, 2020

Conversation

scpeters
Copy link
Member

These are some fixes needed to compile against dartsim on Windows, as mentioned in #87. Though dartsim version 6.9.4 is now available in vcpkg, this version is missing some needed fixes (dartsim/dart#1510, dartsim/dart#1513), so I recommend building dart's master branch from source in a colcon workspace alongside this branch. Unfortunately, dart still seems to have some runtime errors (dartsim/dart#1522), so all the tests that use the dartsim-plugin currently fail, but at least the build succeeds.

The fixes include:

* Build dartsim and test plugins with /permissive- with MSVC
  due to dartsim/dart#753

* Disable C4250 compiler warnings.

* Create unversioned dartsim plugin by copy rather than
  symlink, since symlinks require extra permissions on
  Windows. This copies the TPE approach.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters added DART DART engine Windows Windows support labels Oct 28, 2020
@scpeters scpeters requested a review from JShep1 October 28, 2020 00:25
@scpeters scpeters requested a review from mxgrey as a code owner October 28, 2020 00:25
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🔮 dome Ignition Dome labels Oct 28, 2020
Copy link

@JShep1 JShep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these fixes allow me to build against dart. Although, it should be important to note that ign-physics now won't compile since it uses @azeey / Ignition's fork (https://github.com/ignition-forks/dart) and not the standard dart master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DART DART engine 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants