Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dart-bullet dependency to CI #239

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Add dart-bullet dependency to CI #239

merged 1 commit into from
Mar 24, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Needed to fix building from source.

I'm not sure why CI didn't catch this on #225.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added bug Something isn't working beta Targeting beta release of upcoming collection labels Mar 24, 2021
@chapulina chapulina requested a review from adlarkin March 24, 2021 21:13
@chapulina chapulina requested a review from mxgrey as a code owner March 24, 2021 21:13
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #239 (830c2cd) into main (b10a4c3) will not change coverage.
The diff coverage is n/a.

❗ Current head 830c2cd differs from pull request most recent head 3c0a038. Consider uploading reports for the commit 3c0a038 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   82.23%   82.23%           
=======================================
  Files         109      109           
  Lines        4396     4396           
=======================================
  Hits         3615     3615           
  Misses        781      781           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10a4c3...3c0a038. Read the comment docs.

@adlarkin
Copy link
Contributor

Works for me on Focal. Let me check Bionic to be extra safe. Stay tuned...

@chapulina chapulina merged commit 3c2de8b into main Mar 24, 2021
@chapulina chapulina deleted the chapulina/4/dart_bullet branch March 24, 2021 22:59
@scpeters
Copy link
Member

we may need to update the debian metadata for focal since the most recent nightly build failed

@adlarkin
Copy link
Contributor

we may need to update the debian metadata for focal since the most recent nightly build failed

I went ahead and made a PR with a potential fix in gazebo-release/ign-physics4-release#7 if you would like to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants