2 ➡️ 3 #262
Merged
2 ➡️ 3 #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: claireyywang <[email protected]> Signed-off-by: anindex <[email protected]> Co-authored-by: anindex <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Claire Wang <[email protected]> Co-authored-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-physics3 #262 +/- ##
================================================
- Coverage 83.27% 74.38% -8.89%
================================================
Files 106 115 +9
Lines 3951 4697 +746
================================================
+ Hits 3290 3494 +204
- Misses 661 1203 +542
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Jun 17, 2021
ahcorde
requested changes
Jun 17, 2021
There was a problem hiding this comment.
macos is failing on dart
/Users/jenkins/workspace/ignition_physics-ci-pr_any-homebrew-amd64/ign-physics/test/plugins/DARTDoublePendulum.cc:78:37: error: no member named 'setLimitEnforcement' in 'dart::dynamics::Joint'
this->robot->getJoint(i)->setLimitEnforcement(false);
~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.
make[2]: *** [test/plugins/CMakeFiles/MockDoublePendulum.dir/DARTDoublePendulum.cc.o] Error 1
make[1]: *** [test/plugins/CMakeFiles/MockDoublePendulum.dir/all] Error 2
scpeters
added a commit
to scpeters/ign-physics
that referenced
this pull request
Jun 17, 2021
Copied from gazebosim#262. Signed-off-by: Steve Peters <[email protected]>
|
back-porting deprecation fix to |
Copied from #262. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapuina/2_to_3
branch
from
71423bf
to
8cc844f
Compare
|
Updated this PR to include #263 |
|
@scpeters , can we get this one in to fix the new warnings? |
scpeters
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-physics2toign-physics3Branch comparison: ign-physics3...ign-physics2
Merging forward because I'd like to make a 3,X release including Bullet, see gazebo-release/ign-physics3-release#3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸