-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 ➡️ 3 #262
2 ➡️ 3 #262
Conversation
Signed-off-by: claireyywang <[email protected]> Signed-off-by: anindex <[email protected]> Co-authored-by: anindex <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Claire Wang <[email protected]> Co-authored-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-physics3 #262 +/- ##
================================================
- Coverage 83.27% 74.38% -8.89%
================================================
Files 106 115 +9
Lines 3951 4697 +746
================================================
+ Hits 3290 3494 +204
- Misses 661 1203 +542
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macos is failing on dart
/Users/jenkins/workspace/ignition_physics-ci-pr_any-homebrew-amd64/ign-physics/test/plugins/DARTDoublePendulum.cc:78:37: error: no member named 'setLimitEnforcement' in 'dart::dynamics::Joint'
this->robot->getJoint(i)->setLimitEnforcement(false);
~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.
make[2]: *** [test/plugins/CMakeFiles/MockDoublePendulum.dir/DARTDoublePendulum.cc.o] Error 1
make[1]: *** [test/plugins/CMakeFiles/MockDoublePendulum.dir/all] Error 2
Copied from gazebosim#262. Signed-off-by: Steve Peters <[email protected]>
back-porting deprecation fix to |
Copied from #262. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
71423bf
to
8cc844f
Compare
Updated this PR to include #263 |
@scpeters , can we get this one in to fix the new warnings? |
➡️ Forward port
Port
ign-physics2
toign-physics3
Branch comparison: ign-physics3...ign-physics2
Merging forward because I'd like to make a 3,X release including Bullet, see gazebo-release/ign-physics3-release#3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸