Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 ➡️ 3 #269

Merged
merged 2 commits into from
Jun 22, 2021
Merged

2 ➡️ 3 #269

merged 2 commits into from
Jun 22, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-physics2 to ign-physics3

Branch comparison: ign-physics3...ign-physics2

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

scpeters and others added 2 commits June 19, 2021 19:17
@scpeters
Use slip compliance API's available in upstream dartsim release (#265)
020ed14 
* Use [gs]etPrimarySlipCompliance with dart 6.10.0

These APIs are used in the upstream release of dartsim 6.10.0
and have been recently added to our fork, so start using them.

* Improve slip compliance test coverage

Signed-off-by: Steve Peters <[email protected]>
@chapulina
2 ➡️ 3
3ea5bb1 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from scpeters June 22, 2021 19:44
@chapulina chapulina requested a review from mxgrey as a code owner June 22, 2021 19:44
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jun 22, 2021
@codecov
Copy link

codecov bot commented Jun 22, 2021 •
edited
Loading

Codecov Report

Merging #269 (4cc3093) into ign-physics3 (2c7b829) will increase coverage by 0.24%.
The diff coverage is 100.00%.

❗ Current head 4cc3093 differs from pull request most recent head 3ea5bb1. Consider uploading reports for the commit 3ea5bb1 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics3     #269      +/-   ##
================================================
+ Coverage         74.38%   74.63%   +0.24%     
================================================
  Files               115      115              
  Lines              4697     4703       +6     
================================================
+ Hits               3494     3510      +16     
+ Misses             1203     1193      -10
Impacted Files Coverage Δ
dartsim/src/SDFFeatures.cc 67.89% <100.00%> (ø)
dartsim/src/ShapeFeatures.cc 43.04% <100.00%> (+6.62%) ⬆️
include/ignition/physics/detail/Shape.hh 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7b829...3ea5bb1. Read the comment docs.

@chapulina chapulina merged commit 1a58f73 into ign-physics3 Jun 22, 2021
@chapulina chapulina deleted the chapulina/2_to_3 branch June 22, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

@mxgrey mxgrey Awaiting requested review from mxgrey mxgrey is a code owner

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @ahcorde @scpeters