Bazel updates for garden #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## gz-physics6 #513 +/- ##
===============================================
+ Coverage 78.52% 78.68% +0.15%
===============================================
Files 140 140
Lines 7670 7655 -15
===============================================
Hits 6023 6023
+ Misses 1647 1632 -15 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Carroll <[email protected]> Update for upstream Signed-off-by: Michael Carroll <[email protected]> Fix test includes Signed-off-by: Michael Carroll <[email protected]> Fix install directory Signed-off-by: Michael Carroll <[email protected]> Fix installation directories Signed-off-by: Michael Carroll <[email protected]> Set resource paths Signed-off-by: Michael Carroll <[email protected]> Remaining test refactor Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/garden_bazel
branch
from
ad7d7a4
to
19c4d52
Compare
Merged
This cleans up physics tests in a few ways: Consolidate TestUtilities.hh and test/Utils.hh Move test headers to test/include/test Move mock headers to test/include/mock Create an INTERFACE library for test/mock headers that sets common compiler definitions as well as common libraries to link against Remove all instances of hardcoded world names or resource names and instead use constants. Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
iche033
approved these changes
Jan 30, 2024
It's because I had this targeted to the test_cleanup branch initially, it's a checker problem. |
|
@osrf-jenkins retest this please |
scpeters
reviewed
Feb 6, 2024
| @@ -27,6 +27,7 @@ | |||
|
|
|||
| #define GZ_PHYSICS_VERSION "${PROJECT_VERSION}" | |||
| #define GZ_PHYSICS_VERSION_FULL "${PROJECT_VERSION_FULL}" | |||
| #define GZ_PHYSICS_VERSION_NAMESPACE v${PROJECT_VERSION_MAJOR} | |||
There was a problem hiding this comment.
per gazebosim/gz-cmake#412, this breaks ABI
it looks like this PR was merged even with a broken ABI build
mjcarroll
added a commit
that referenced
this pull request
Feb 6, 2024
This reverts commit 1016539. Signed-off-by: Michael Carroll <[email protected]>
scpeters
pushed a commit
that referenced
this pull request
Feb 6, 2024
This reverts commit 1016539. Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
added a commit
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.