-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel updates for garden #513
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## gz-physics6 #513 +/- ##
===============================================
+ Coverage 78.52% 78.68% +0.15%
===============================================
Files 140 140
Lines 7670 7655 -15
===============================================
Hits 6023 6023
+ Misses 1647 1632 -15 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Carroll <[email protected]> Update for upstream Signed-off-by: Michael Carroll <[email protected]> Fix test includes Signed-off-by: Michael Carroll <[email protected]> Fix install directory Signed-off-by: Michael Carroll <[email protected]> Fix installation directories Signed-off-by: Michael Carroll <[email protected]> Set resource paths Signed-off-by: Michael Carroll <[email protected]> Remaining test refactor Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
ad7d7a4
to
19c4d52
Compare
This cleans up physics tests in a few ways: Consolidate TestUtilities.hh and test/Utils.hh Move test headers to test/include/test Move mock headers to test/include/mock Create an INTERFACE library for test/mock headers that sets common compiler definitions as well as common libraries to link against Remove all instances of hardcoded world names or resource names and instead use constants. Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Built fine and tests passed with the garden
branch in gz-bazel. Not sure why the abi checker job is failing.
It's because I had this targeted to the test_cleanup branch initially, it's a checker problem. |
@osrf-jenkins retest this please |
@@ -27,6 +27,7 @@ | |||
|
|||
#define GZ_PHYSICS_VERSION "${PROJECT_VERSION}" | |||
#define GZ_PHYSICS_VERSION_FULL "${PROJECT_VERSION_FULL}" | |||
#define GZ_PHYSICS_VERSION_NAMESPACE v${PROJECT_VERSION_MAJOR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per gazebosim/gz-cmake#412, this breaks ABI
it looks like this PR was merged even with a broken ABI build
This reverts commit 1016539. Signed-off-by: Michael Carroll <[email protected]>
This reverts commit 1016539. Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
No description provided.