Added altimeter sensor inspector #1172

nkoenig · 2021-11-06T01:11:09Z

Signed-off-by: Nate Koenig [email protected]

🎉 New feature

Summary

Builds on #1171 by adding a GUI inspector for altimeters.

This PR also demonstrates how to add a new component inspector element.

Test it

ign gazebo -v 4 sensors.sdf
Take note of the output from ign model -m sensors_box -l link -s altimeter
Select the altimeter sensor in the entity tree.
Make some changes to the values in the component inspector.
Rerun ign model -m sensors_box -l link -s altimeter and you should see the changes.

Checklist

Signed all commits for DCO
Added tests
Added example and/or tutorial
Updated documentation (as needed)
Updated migration guide (as needed)
codecheck passed (See contributing)
All tests passed (See test coverage)
While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Michael Carroll <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>

…nrobotics/ign-gazebo into air_pressure_component_inspector

src/gui/plugins/component_inspector/Altimeter.cc

Signed-off-by: Louise Poubel <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>

…nrobotics/ign-gazebo into air_pressure_component_inspector

Signed-off-by: Nate Koenig <[email protected]>

codecov · 2021-11-17T20:26:37Z

Codecov Report

Merging #1172 (b4fd7b2) into model_editor (9d4cd24) will decrease coverage by 0.13%.
The diff coverage is 11.66%.

@@               Coverage Diff                @@
##           model_editor    #1172      +/-   ##
================================================
- Coverage         61.14%   61.00%   -0.14%     
================================================
  Files               264      265       +1     
  Lines             21025    21085      +60     
================================================
+ Hits              12855    12863       +8     
- Misses             8170     8222      +52

Impacted Files	Coverage Δ
src/gui/plugins/component_inspector/Altimeter.cc	`10.16% <10.16%> (ø)`
.../plugins/component_inspector/ComponentInspector.cc	`5.91% <100.00%> (+0.17%)`	⬆️
src/EntityComponentManager.cc	`87.74% <0.00%> (+0.12%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4cd24...b4fd7b2. Read the comment docs.

iche033

looks good to me.

* Model editor: Add links to model (#1165) * add an add entity button to component inspector. Currently only enabled for models Signed-off-by: Ian Chen <[email protected]> * add model editor gui plugin that inserts visuals to the scene in the render thread Signed-off-by: Ian Chen <[email protected]> * write to ECM Signed-off-by: Ian Chen <[email protected]> * support adding light links Signed-off-by: Ian Chen <[email protected]> * notify other GUI plugins of added/removed entities via GUI events Signed-off-by: Ashton Larkin <[email protected]> * use const ref for constructor input params Signed-off-by: Ashton Larkin <[email protected]> * guarantee 64 bit entity IDs with gazebo::Entity instead of unsigned int Signed-off-by: Ashton Larkin <[email protected]> * testing makr as new entity func Signed-off-by: Ian Chen <[email protected]> * rm printouts Signed-off-by: Ian Chen <[email protected]> * register type Signed-off-by: Ian Chen <[email protected]> * refactor render util Signed-off-by: Ian Chen <[email protected]> * workaround for avoiding crash on exit Signed-off-by: Ian Chen <[email protected]> * refactor, comment out unused menu items Signed-off-by: Ian Chen <[email protected]> * remove commented out code, add CreateLight function Signed-off-by: Ian Chen <[email protected]> * add model editor src files Signed-off-by: Ian Chen <[email protected]> * remove more commented out code Signed-off-by: Ian Chen <[email protected]> * use entity instead of entity name (#1176) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Add link menu updates (#1177) * use entity instead of entity name Signed-off-by: Nate Koenig <[email protected]> * Update link add menu Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Ian Chen <[email protected]> * fix adding ellipsoid Signed-off-by: Ian Chen <[email protected]> * merge model_editor into component_inspector Signed-off-by: Ian Chen <[email protected]> * fixing warnings Signed-off-by: Ian Chen <[email protected]> * Adjust tool tips Signed-off-by: Nate Koenig <[email protected]> * fix adding light Signed-off-by: Ian Chen <[email protected]> * Fix codecheck Signed-off-by: Nate Koenig <[email protected]> * Fixed documentation Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Ashton Larkin <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Support recreating model entities (#1170) * add recreate component and implement recreate entities functionality, add test Signed-off-by: Ian Chen <[email protected]> * update test and make recreate entities with same name work Signed-off-by: Ian Chen <[email protected]> * revert add include Signed-off-by: Ian Chen <[email protected]> * style Signed-off-by: Ian Chen <[email protected]> * Support editing air pressure sensor in the GUI Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Fix lint Signed-off-by: Michael Carroll <[email protected]> * Update sensor icon Signed-off-by: Nate Koenig <[email protected]> * Move AirPressure functions out of ComponentInspector (#1179) Signed-off-by: Louise Poubel <[email protected]> * Fix get decimals, and address comments Signed-off-by: Nate Koenig <[email protected]> * cleanup and simplification Signed-off-by: Nate Koenig <[email protected]> * check recreate comp in ancestor Signed-off-by: Ian Chen <[email protected]> * require sdf 12.1.0 Signed-off-by: Nate Koenig <[email protected]> * Revert sdf version requirement Signed-off-by: Nate Koenig <[email protected]> * Fix codecheck Signed-off-by: Nate Koenig <[email protected]> * revert my bad merge Signed-off-by: Nate Koenig <[email protected]> * remvoe sensor icon Signed-off-by: Nate Koenig <[email protected]> * Together (#1187) * add an add entity button to component inspector. Currently only enabled for models Signed-off-by: Ian Chen <[email protected]> * add model editor gui plugin that inserts visuals to the scene in the render thread Signed-off-by: Ian Chen <[email protected]> * write to ECM Signed-off-by: Ian Chen <[email protected]> * support adding light links Signed-off-by: Ian Chen <[email protected]> * notify other GUI plugins of added/removed entities via GUI events Signed-off-by: Ashton Larkin <[email protected]> * use const ref for constructor input params Signed-off-by: Ashton Larkin <[email protected]> * guarantee 64 bit entity IDs with gazebo::Entity instead of unsigned int Signed-off-by: Ashton Larkin <[email protected]> * testing makr as new entity func Signed-off-by: Ian Chen <[email protected]> * rm printouts Signed-off-by: Ian Chen <[email protected]> * register type Signed-off-by: Ian Chen <[email protected]> * refactor render util Signed-off-by: Ian Chen <[email protected]> * workaround for avoiding crash on exit Signed-off-by: Ian Chen <[email protected]> * refactor, comment out unused menu items Signed-off-by: Ian Chen <[email protected]> * remove commented out code, add CreateLight function Signed-off-by: Ian Chen <[email protected]> * add model editor src files Signed-off-by: Ian Chen <[email protected]> * remove more commented out code Signed-off-by: Ian Chen <[email protected]> * use entity instead of entity name (#1176) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Add link menu updates (#1177) * use entity instead of entity name Signed-off-by: Nate Koenig <[email protected]> * Update link add menu Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Ian Chen <[email protected]> * fix adding ellipsoid Signed-off-by: Ian Chen <[email protected]> * merge model_editor into component_inspector Signed-off-by: Ian Chen <[email protected]> * fixing warnings Signed-off-by: Ian Chen <[email protected]> * Adjust tool tips Signed-off-by: Nate Koenig <[email protected]> * fix adding light Signed-off-by: Ian Chen <[email protected]> * Fix codecheck Signed-off-by: Nate Koenig <[email protected]> * Fixed documentation Signed-off-by: Nate Koenig <[email protected]> * Working on model creation Signed-off-by: Nate Koenig <[email protected]> * Fix build Signed-off-by: Nate Koenig <[email protected]> * Added debug statements Signed-off-by: Nate Koenig <[email protected]> * use each no cache Signed-off-by: Ian Chen <[email protected]> * fix removing component from view Signed-off-by: Ian Chen <[email protected]> * Fix physics Signed-off-by: Nate Koenig <[email protected]> * Fix codecheck Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Ashton Larkin <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Address comments Signed-off-by: Nate Koenig <[email protected]> * update cameras list on sensor removal Signed-off-by: Ian Chen <[email protected]> * update cameras list on sensor removal Signed-off-by: Ian Chen <[email protected]> * Require sensors 6.1 Signed-off-by: Nate Koenig <[email protected]> * sensors 6.0.1 Signed-off-by: Nate Koenig <[email protected]> * Test model recreation with jointed models Signed-off-by: Michael Carroll <[email protected]> * Fix multiple joints with same names There was an issue in searching for joint parent_link and child_link frames if there was another model with the same frame names. This will correctly search for frame entity ids that are children of the same model. Signed-off-by: Michael Carroll <[email protected]> * Recreate entities joints (#1206) * Test model recreation with jointed models * Fix multiple joints with same names There was an issue in searching for joint parent_link and child_link frames if there was another model with the same frame names. This will correctly search for frame entity ids that are children of the same model. Signed-off-by: Michael Carroll <[email protected]> * Fix the ecm test, which had bad parent-child relationships between links and joints Signed-off-by: Nate Koenig <[email protected]> * Added test for world joints Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Ashton Larkin <[email protected]> * Support editing air pressure sensor in the GUI (#1171) * Support editing air pressure sensor in the GUI Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Fix lint Signed-off-by: Michael Carroll <[email protected]> * Update sensor icon Signed-off-by: Nate Koenig <[email protected]> * Move AirPressure functions out of ComponentInspector (#1179) Signed-off-by: Louise Poubel <[email protected]> * Fix get decimals, and address comments Signed-off-by: Nate Koenig <[email protected]> * cleanup and simplification Signed-off-by: Nate Koenig <[email protected]> * Require sdf 12.1.0 Signed-off-by: Nate Koenig <[email protected]> * missign width Signed-off-by: Nate Koenig <[email protected]> * Added simulation state aware spin box Signed-off-by: Nate Koenig <[email protected]> * Remove console output Signed-off-by: Nate Koenig <[email protected]> * Added state awareness to add entity button Signed-off-by: Nate Koenig <[email protected]> * Fix codecheck Signed-off-by: Nate Koenig <[email protected]> * Remove extra variable Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Added altimeter sensor inspector (#1172) * Support editing air pressure sensor in the GUI Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Added altimeter sensor inspector Signed-off-by: Nate Koenig <[email protected]> * Fix lint Signed-off-by: Michael Carroll <[email protected]> * Update sensor icon Signed-off-by: Nate Koenig <[email protected]> * Move AirPressure functions out of ComponentInspector (#1179) Signed-off-by: Louise Poubel <[email protected]> * Fix get decimals, and address comments Signed-off-by: Nate Koenig <[email protected]> * cleanup and simplification Signed-off-by: Nate Koenig <[email protected]> * Require sdf 12.1.0 Signed-off-by: Nate Koenig <[email protected]> * missign width Signed-off-by: Nate Koenig <[email protected]> * Added simulation state aware spin box Signed-off-by: Nate Koenig <[email protected]> * Merged Signed-off-by: Nate Koenig <[email protected]> * merged Signed-off-by: Nate Koenig <[email protected]> * Remove console output Signed-off-by: Nate Koenig <[email protected]> * alphabetize Signed-off-by: Nate Koenig <[email protected]> * Documentation Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Added magnetometer inspector (#1173) * Support editing air pressure sensor in the GUI Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Added altimeter sensor inspector Signed-off-by: Nate Koenig <[email protected]> * Added magnetometer inspector Signed-off-by: Nate Koenig <[email protected]> * Fix lint Signed-off-by: Michael Carroll <[email protected]> * Update sensor icon Signed-off-by: Nate Koenig <[email protected]> * Move AirPressure functions out of ComponentInspector (#1179) Signed-off-by: Louise Poubel <[email protected]> * Fix get decimals, and address comments Signed-off-by: Nate Koenig <[email protected]> * cleanup and simplification Signed-off-by: Nate Koenig <[email protected]> * Require sdf 12.1.0 Signed-off-by: Nate Koenig <[email protected]> * missign width Signed-off-by: Nate Koenig <[email protected]> * Added simulation state aware spin box Signed-off-by: Nate Koenig <[email protected]> * Merged Signed-off-by: Nate Koenig <[email protected]> * merged Signed-off-by: Nate Koenig <[email protected]> * Remove console output Signed-off-by: Nate Koenig <[email protected]> * alphabetize Signed-off-by: Nate Koenig <[email protected]> * Fix build Signed-off-by: Nate Koenig <[email protected]> * alphabetize Signed-off-by: Nate Koenig <[email protected]> * Cleanup build Signed-off-by: Nate Koenig <[email protected]> * Missing print call Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Add IMU component inspector (#1191) * Support editing air pressure sensor in the GUI Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Added altimeter sensor inspector Signed-off-by: Nate Koenig <[email protected]> * Added magnetometer inspector Signed-off-by: Nate Koenig <[email protected]> * Fix lint Signed-off-by: Michael Carroll <[email protected]> * Update sensor icon Signed-off-by: Nate Koenig <[email protected]> * Move AirPressure functions out of ComponentInspector (#1179) Signed-off-by: Louise Poubel <[email protected]> * Fix get decimals, and address comments Signed-off-by: Nate Koenig <[email protected]> * cleanup and simplification Signed-off-by: Nate Koenig <[email protected]> * Require sdf 12.1.0 Signed-off-by: Nate Koenig <[email protected]> * missign width Signed-off-by: Nate Koenig <[email protected]> * Added simulation state aware spin box Signed-off-by: Nate Koenig <[email protected]> * Merged Signed-off-by: Nate Koenig <[email protected]> * merged Signed-off-by: Nate Koenig <[email protected]> * Remove console output Signed-off-by: Nate Koenig <[email protected]> * alphabetize Signed-off-by: Nate Koenig <[email protected]> * Fix build Signed-off-by: Nate Koenig <[email protected]> * Add IMU component inspector Signed-off-by: Nate Koenig <[email protected]> * alphabetize Signed-off-by: Nate Koenig <[email protected]> * Cleanup build Signed-off-by: Nate Koenig <[email protected]> * Missing print call Signed-off-by: Nate Koenig <[email protected]> * Fix all codecheck issues Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Added lidar component inspector (#1203) * Support editing air pressure sensor in the GUI Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Added altimeter sensor inspector Signed-off-by: Nate Koenig <[email protected]> * Added magnetometer inspector Signed-off-by: Nate Koenig <[email protected]> * Fix lint Signed-off-by: Michael Carroll <[email protected]> * Update sensor icon Signed-off-by: Nate Koenig <[email protected]> * Move AirPressure functions out of ComponentInspector (#1179) Signed-off-by: Louise Poubel <[email protected]> * Fix get decimals, and address comments Signed-off-by: Nate Koenig <[email protected]> * cleanup and simplification Signed-off-by: Nate Koenig <[email protected]> * Require sdf 12.1.0 Signed-off-by: Nate Koenig <[email protected]> * missign width Signed-off-by: Nate Koenig <[email protected]> * Added simulation state aware spin box Signed-off-by: Nate Koenig <[email protected]> * Merged Signed-off-by: Nate Koenig <[email protected]> * merged Signed-off-by: Nate Koenig <[email protected]> * Remove console output Signed-off-by: Nate Koenig <[email protected]> * alphabetize Signed-off-by: Nate Koenig <[email protected]> * Fix build Signed-off-by: Nate Koenig <[email protected]> * Add IMU component inspector Signed-off-by: Nate Koenig <[email protected]> * Added lidar component inspector Signed-off-by: Nate Koenig <[email protected]> * Fix codecheck Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Model Editor: Add Joints to model (#1196) * Model Editor: Add Joints to model Signed-off-by: Michael Carroll <[email protected]> * Lint Signed-off-by: Michael Carroll <[email protected]> * Style and documentation Signed-off-by: Nate Koenig <[email protected]> * Suppress physics warnings on newly-created joints Signed-off-by: Michael Carroll <[email protected]> * Added a header Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Allow user to modify joint type (#1198) * Support editing air pressure sensor in the GUI Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Add noise to qrc Signed-off-by: Nate Koenig <[email protected]> * Fix lint Signed-off-by: Michael Carroll <[email protected]> * Update sensor icon Signed-off-by: Nate Koenig <[email protected]> * Move AirPressure functions out of ComponentInspector (#1179) Signed-off-by: Louise Poubel <[email protected]> * Fix get decimals, and address comments Signed-off-by: Nate Koenig <[email protected]> * cleanup and simplification Signed-off-by: Nate Koenig <[email protected]> * Require sdf 12.1.0 Signed-off-by: Nate Koenig <[email protected]> * missign width Signed-off-by: Nate Koenig <[email protected]> * Added simulation state aware spin box Signed-off-by: Nate Koenig <[email protected]> * Remove console output Signed-off-by: Nate Koenig <[email protected]> * Allow user to modify joint type Signed-off-by: Michael Carroll <[email protected]> * Updated to use a separate class, and consolidate the look Signed-off-by: Nate Koenig <[email protected]> * Added recreate to joint add Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Add sensors to a link via the GUI (#1188) * add an add entity button to component inspector. Currently only enabled for models Signed-off-by: Ian Chen <[email protected]> * add model editor gui plugin that inserts visuals to the scene in the render thread Signed-off-by: Ian Chen <[email protected]> * write to ECM Signed-off-by: Ian Chen <[email protected]> * get updated GUI ECM info in world control CB Signed-off-by: Ashton Larkin <[email protected]> * support adding light links Signed-off-by: Ian Chen <[email protected]> * working on adding tests Signed-off-by: Ashton Larkin <[email protected]> * remove TODO note, issue fixed by #1131 Signed-off-by: Ashton Larkin <[email protected]> * notify other GUI plugins of added/removed entities via GUI events Signed-off-by: Ashton Larkin <[email protected]> * use const ref for constructor input params Signed-off-by: Ashton Larkin <[email protected]> * guarantee 64 bit entity IDs with gazebo::Entity instead of unsigned int Signed-off-by: Ashton Larkin <[email protected]> * testing makr as new entity func Signed-off-by: Ian Chen <[email protected]> * rm printouts Signed-off-by: Ian Chen <[email protected]> * register type Signed-off-by: Ian Chen <[email protected]> * refactor render util Signed-off-by: Ian Chen <[email protected]> * apply GUI ECM's diff to server ECM at end of pause interval Signed-off-by: Ashton Larkin <[email protected]> * use gui event to update server Signed-off-by: Ashton Larkin <[email protected]> * Working on sensor addition and editing Signed-off-by: Nate Koenig <[email protected]> * handle step and support original control service Signed-off-by: Ashton Larkin <[email protected]> * Reduced code duplication Signed-off-by: Nate Koenig <[email protected]> * Set gazebo's default to use the event based system Signed-off-by: Nate Koenig <[email protected]> * Testing things out Signed-off-by: Nate Koenig <[email protected]> * updates Signed-off-by: Nate Koenig <[email protected]> * workaround for avoiding crash on exit Signed-off-by: Ian Chen <[email protected]> * refactor, comment out unused menu items Signed-off-by: Ian Chen <[email protected]> * remove commented out code, add CreateLight function Signed-off-by: Ian Chen <[email protected]> * add model editor src files Signed-off-by: Ian Chen <[email protected]> * remove more commented out code Signed-off-by: Ian Chen <[email protected]> * Fix build Signed-off-by: Nate Koenig <[email protected]> * use entity instead of entity name Signed-off-by: Nate Koenig <[email protected]> * Update link add menu Signed-off-by: Nate Koenig <[email protected]> * Updates Signed-off-by: Nate Koenig <[email protected]> * Added back in sensor menu Signed-off-by: Nate Koenig <[email protected]> * Updates Signed-off-by: Nate Koenig <[email protected]> * Updates Signed-off-by: Nate Koenig <[email protected]> * Updates Signed-off-by: Nate Koenig <[email protected]> * use entity instead of entity name (#1176) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Adding sensors Signed-off-by: Nate Koenig <[email protected]> * Add link menu updates (#1177) * use entity instead of entity name Signed-off-by: Nate Koenig <[email protected]> * Update link add menu Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Ian Chen <[email protected]> * fix adding ellipsoid Signed-off-by: Ian Chen <[email protected]> * merge model_editor into component_inspector Signed-off-by: Ian Chen <[email protected]> * fixing warnings Signed-off-by: Ian Chen <[email protected]> * Adjust tool tips Signed-off-by: Nate Koenig <[email protected]> * Updates Signed-off-by: Nate Koenig <[email protected]> * updates Signed-off-by: Nate Koenig <[email protected]> * updates Signed-off-by: Nate Koenig <[email protected]> * Adding lidar menu Signed-off-by: Nate Koenig <[email protected]> * alphabetize Signed-off-by: Nate Koenig <[email protected]> * Comment out sensors not supported Signed-off-by: Nate Koenig <[email protected]> * Added segmentation camera Signed-off-by: Nate Koenig <[email protected]> * fix id Signed-off-by: Nate Koenig <[email protected]> * fix codecheck Signed-off-by: Nate Koenig <[email protected]> * Fix submenue Signed-off-by: Nate Koenig <[email protected]> * Remove lidar menu, and address comments Signed-off-by: Nate Koenig <[email protected]> * fix codecheck Signed-off-by: Nate Koenig <[email protected]> * Merged Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Ashton Larkin <[email protected]> Co-authored-by: Ashton Larkin <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Support setting pose on links, visuals, collision via the GUI (#1230) * Working on pose modification Signed-off-by: Nate Koenig <[email protected]> * Support setting pose on links, visuals, collision via the GUI Signed-off-by: Nate Koenig <[email protected]> * Fix test Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * alphabetize Signed-off-by: Nate Koenig <[email protected]> * Pimplize a class and added units, and 'joint' Signed-off-by: Nate Koenig <[email protected]> * remove laser Signed-off-by: Nate Koenig <[email protected]> * Added extra note Signed-off-by: Nate Koenig <[email protected]> * Addressing comments Signed-off-by: Nate Koenig <[email protected]> * Allow models to transform Signed-off-by: Nate Koenig <[email protected]> * remove console log Signed-off-by: Nate Koenig <[email protected]> * rename componentinspector in qml Signed-off-by: Nate Koenig <[email protected]> * Update based on comments Signed-off-by: Nate Koenig <[email protected]> * Don't publish ECM changes when paused Signed-off-by: Nate Koenig <[email protected]> * Apply patch Signed-off-by: Nate Koenig <[email protected]> * Fix joint type dropdown Signed-off-by: Nate Koenig <[email protected]> * Joint type spacing Signed-off-by: Nate Koenig <[email protected]> * Fix codecheck Signed-off-by: Nate Koenig <[email protected]> * editor changes Signed-off-by: Nate Koenig <[email protected]> * Recereate on sensors Signed-off-by: Nate Koenig <[email protected]> * Don't allow world as child link Signed-off-by: Nate Koenig <[email protected]> * Fix scene broadcaster test, and add another modelcommandapi test Signed-off-by: Nate Koenig <[email protected]> * Added model command api gpu lidar test Signed-off-by: Nate Koenig <[email protected]> * use MAX_VALUE Signed-off-by: Nate Koenig <[email protected]> * Added units to model command Signed-off-by: Nate Koenig <[email protected]> * Fix tests Signed-off-by: Nate Koenig <[email protected]> * Added ProcessNewWorldControlState test Signed-off-by: Nate Koenig <[email protected]> * Update test/worlds/gpu_lidar.sdf Co-authored-by: Louise Poubel <[email protected]> * Removed comments and plugins Signed-off-by: Nate Koenig <[email protected]> * Update comments Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Ashton Larkin <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Ashton Larkin <[email protected]>

Nate Koenig added 4 commits November 5, 2021 17:44

Support editing air pressure sensor in the GUI

18b26c2

Signed-off-by: Nate Koenig <[email protected]>

Add noise to qrc

1477a68

Signed-off-by: Nate Koenig <[email protected]>

Add noise to qrc

92bed4e

Signed-off-by: Nate Koenig <[email protected]>

Added altimeter sensor inspector

da30432

Signed-off-by: Nate Koenig <[email protected]>

nkoenig requested a review from chapulina as a code owner November 6, 2021 01:11

nkoenig mentioned this pull request Nov 6, 2021

Support editing air pressure sensor in the GUI #1171

Merged

8 tasks

mjcarroll and others added 3 commits November 8, 2021 07:39

Merge branch 'ign-gazebo6' into air_pressure_component_inspector

d553e8f

Fix lint

103cdf0

Signed-off-by: Michael Carroll <[email protected]>

Merge branch 'ign-gazebo6' into air_pressure_component_inspector

c4eb390

chapulina added GUI Gazebo's graphical interface (not pure Ignition GUI) sensors Sensors and sensor data labels Nov 8, 2021

Nate Koenig added 2 commits November 8, 2021 10:51

Update sensor icon

2029d2b

Signed-off-by: Nate Koenig <[email protected]>

Merge branch 'air_pressure_component_inspector' of github.com:ignitio…

9fa9a84

…nrobotics/ign-gazebo into air_pressure_component_inspector

ahcorde requested changes Nov 8, 2021

View reviewed changes

src/gui/plugins/component_inspector/Altimeter.cc Show resolved Hide resolved

chapulina and others added 4 commits November 9, 2021 08:09

Move AirPressure functions out of ComponentInspector (#1179)

2d8d50f

Signed-off-by: Louise Poubel <[email protected]>

Fix get decimals, and address comments

1a3b5ee

Signed-off-by: Nate Koenig <[email protected]>

merged

8d0b08d

Signed-off-by: Nate Koenig <[email protected]>

cleanup and simplification

5c0a4c0

Signed-off-by: Nate Koenig <[email protected]>

nkoenig mentioned this pull request Nov 9, 2021

Prepare for 12.1.0 release gazebosim/sdformat#743

Merged

6 tasks

Nate Koenig added 9 commits November 9, 2021 13:35

Require sdf 12.1.0

9e7250d

Signed-off-by: Nate Koenig <[email protected]>

missign width

d552603

Signed-off-by: Nate Koenig <[email protected]>

Merge branch 'air_pressure_component_inspector' of github.com:ignitio…

686d384

…nrobotics/ign-gazebo into air_pressure_component_inspector

Merge branch 'ign-gazebo6' into air_pressure_component_inspector

00ecb2b

Added simulation state aware spin box

fbfbe49

Signed-off-by: Nate Koenig <[email protected]>

merged

736318c

Signed-off-by: Nate Koenig <[email protected]>

Merged

2dba44f

Signed-off-by: Nate Koenig <[email protected]>

Merged

f901480

Signed-off-by: Nate Koenig <[email protected]>

merged

30bec80

Signed-off-by: Nate Koenig <[email protected]>

Nate Koenig added 3 commits November 10, 2021 16:11

Remove console output

8e4c87b

Signed-off-by: Nate Koenig <[email protected]>

Merge branch 'air_pressure_component_inspector' into altimeter_inspector

4d934fb

alphabetize

a4f8336

Signed-off-by: Nate Koenig <[email protected]>

chapulina added editor Tools to edit entities in simulation 🏯 fortress Ignition Fortress labels Nov 11, 2021

Base automatically changed from air_pressure_component_inspector to model_editor November 17, 2021 19:05

Nate Koenig added 2 commits November 17, 2021 11:10

merged with model_inspector

d3cb2af

Signed-off-by: Nate Koenig <[email protected]>

Documentation

b4fd7b2

Signed-off-by: Nate Koenig <[email protected]>

nkoenig requested a review from iche033 November 17, 2021 19:15

iche033 approved these changes Nov 18, 2021

View reviewed changes

nkoenig merged commit 0cc0c56 into model_editor Nov 18, 2021

nkoenig deleted the altimeter_inspector branch November 18, 2021 15:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added altimeter sensor inspector #1172

Added altimeter sensor inspector #1172

nkoenig commented Nov 6, 2021

codecov bot commented Nov 17, 2021 •

edited

Loading

iche033 left a comment

Added altimeter sensor inspector #1172

Added altimeter sensor inspector #1172

Conversation

nkoenig commented Nov 6, 2021

🎉 New feature

Summary

Test it

Checklist

codecov bot commented Nov 17, 2021 • edited Loading

Codecov Report

iche033 left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 17, 2021 •

edited

Loading