Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 ➡️ 6 #811

Merged
merged 50 commits into from
May 19, 2021
Merged

5 ➡️ 6 #811

merged 50 commits into from
May 19, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gazebo5 to main

Branch comparison: main...ign-gazebo5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

chapulina and others added 30 commits March 17, 2021 19:25
Signed-off-by: Louise Poubel <[email protected]>
…Features (#690)

* GetContactsFromLastStepFeature made optional

Signed-off-by: Tomas Lorente <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>
* Add sensors to scene broadcaster

Signed-off-by: Nate Koenig <[email protected]>

* Update src/systems/scene_broadcaster/SceneBroadcaster.cc

Co-authored-by: Michael Carroll <[email protected]>

* Fix codecheck

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: Michael Carroll <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
…#674)

* set particle scatter ratio through sdf

Signed-off-by: Ian Chen <[email protected]>

* address feedback

Signed-off-by: Ian Chen <[email protected]>

* add todo note about merging forward

Signed-off-by: Ian Chen <[email protected]>

Co-authored-by: Ashton Larkin <[email protected]>
…ility with Protobuf CMake config (#715)

Signed-off-by: Silvio Traversaro <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Only set them if they are strictly positive.

Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
* ecm's ChangedState to contain modified components

Signed-off-by: Jenn Nguyen <[email protected]>

* updated log_system test

Signed-off-by: Jenn Nguyen <[email protected]>

* removed unnecessary calls

Signed-off-by: Jenn Nguyen <[email protected]>

Co-authored-by: Ian Chen <[email protected]>
* Prepare for 4.7.0

Signed-off-by: Nate Koenig <[email protected]>

* Added placeholder

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
* add enable/disable diffdrive

Signed-off-by: Guillaume Doisy <[email protected]>

* remove debug

Signed-off-by: Guillaume Doisy <[email protected]>

* do not subscribe to enable if topic is empty

Signed-off-by: Guillaume Doisy <[email protected]>

* add test

Signed-off-by: Guillaume Doisy <[email protected]>

* lint and style

Signed-off-by: Guillaume Doisy <[email protected]>

* change enable type to bool and renamed to enabled

Signed-off-by: Guillaume Doisy <[email protected]>
* Create Initial Odometry Publisher system plugin

Add code for initial plugin that gets position from Pose component and
calculates velocities based on rolling mean from displacement data.

Signed-off-by: Maganty Rushyendra <[email protected]>

* Remove Linear and Angular Velocity components

Also renames frames in Odometry msg to include model name, and makes
various style changes.

Signed-off-by: Maganty Rushyendra <[email protected]>

* Get World pose instead of pose of robot base frame

Signed-off-by: Maganty Rushyendra <[email protected]>

* Add documentation for variables and functions

Includes minor stylistic changes.

Signed-off-by: Maganty Rushyendra <[email protected]>

* Check for valid odomTopic and update copyright year

Signed-off-by: Maganty Rushyendra <[email protected]>

* Add tests for OdometryPublisherSystem and fix velocity calculation bug

Swap X and Y linear velocities when calculating odometry velocities
relative to robotBaseFrame.

Signed-off-by: Maganty Rushyendra <[email protected]>

Co-authored-by: ahcorde <[email protected]>
* Patch particle emitter2 service

Signed-off-by: Nate Koenig <[email protected]>

* Remove condition variable

Signed-off-by: Nate Koenig <[email protected]>

* Set emitter frame and relative pose

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Michael Carroll <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 7, 2021
jennuine and others added 2 commits May 11, 2021 15:49
* fixed included nested model expansion

Signed-off-by: Jenn Nguyen <[email protected]>

* added resource path to test

Signed-off-by: Jenn Nguyen <[email protected]>

* use orig URIs & support multi level nesting

Signed-off-by: Jenn Nguyen <[email protected]>

* save fuel version when enabled

Signed-off-by: Jenn Nguyen <[email protected]>

* retrieve uri from map

Signed-off-by: Jenn Nguyen <[email protected]>

* copy included element

Signed-off-by: Jenn Nguyen <[email protected]>

* clear attributes before copying include element

Signed-off-by: Jenn Nguyen <[email protected]>
chapulina added a commit that referenced this pull request May 12, 2021
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

The homebrew build should be fixed by osrf/homebrew-simulation#1456.

I think the rest looks good!

@scpeters
Copy link
Member

The homebrew build should be fixed by osrf/homebrew-simulation#1456.

I think the rest looks good!

osrf/homebrew-simulation#1456 has been merged, so I restarted the homebrew build (after wiping out the workspace)

@scpeters
Copy link
Member

scpeters commented May 14, 2021

The homebrew build should be fixed by osrf/homebrew-simulation#1456.
I think the rest looks good!

osrf/homebrew-simulation#1456 has been merged, so I restarted the homebrew build (after wiping out the workspace)

homebrew build is still failing because sdformat12 formula is out of date. I've opened osrf/homebrew-simulation#1459 as a potential solution

@chapulina
Copy link
Contributor Author

homebrew build is still failing because sdformat12 formula is out of date. I've opened osrf/homebrew-simulation#1459 as a potential solution

Same for ign-physics5 to fix the velocity_control test: osrf/homebrew-simulation#1460

* Export only submesh if selected
* Add test case for the PR
* Attempting a unified solution

Signed-off-by: Jorge Perez <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
@scpeters
Copy link
Member

homebrew build is still failing because sdformat12 formula is out of date. I've opened osrf/homebrew-simulation#1459 as a potential solution

Same for ign-physics5 to fix the velocity_control test: osrf/homebrew-simulation#1460

that has been merged so I retried the home-brew jenkins build to see if the velocity control test is fixed:

@scpeters
Copy link
Member

the PERFORMANCE_level_manager test failed in both bionic GitHub actions runs, so I filed #826 to track it

I think any other test failures are flaky. I'm going to merge

@scpeters scpeters merged commit fbf14ec into main May 19, 2021
@scpeters scpeters deleted the chapulina/5_to_6 branch May 19, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.